Since the default argument count is ":1" these listeners never
see interfaces so they can be called over the new event and the
old one can be deprecated.
Some services are global so calling them to reconfigure for each interface
is suboptimal. We can move these to a mapped event with all the interfaces
to reload at once which avoids useless cycles and race conditions.
Tried to check PID and avoid start without family association
but extending to pass the address family made more sense so we
can always restart to ensure addresses and routes are matching.
More work needed but as discussed with @swhite2 we want this here
before we work on the UX part. These types of notifications need
more screen presence and are non-dismissable.
While here kill an oddity assignment with constant() use.
And adjust comments still refering to "LiveCD" since we have a DVD
image nowadays and the live mode works on all install media.
This probably needs more engineering later on which makes
it a little harder to ship but in reality we want people
to run the portable command easily in order to unbreak their
environments as pkg-upgrade tripping over its own temporary
files and directories keeps happening in user reports.
While here use "-s" while at it to speed up the script call.
This also pertains to "-e" which is its sibling.
If widgets fail to load for any reason, the tick routine simply continues
without interruption. This commit makes sure that the visual error
state isn't stuck and switches back to widget output when possible.
The easiest way to reproduce this is to simply disconnect from
the network while having the dashboard open.
Minor temporary fix in case /var/db/rrd/updaterrd.sh doesn't exist. All of this will vanish soon, so it isn't worth the effort of chaging the file mode and retesting.
ref https://github.com/opnsense/core/issues/7753
As discussed with @AdSchellevis make this a reality for
PPP/PPTP/L2TP, but leave PPPoE as is for now. This
allows inline creation of PPPoE to remain for the time
being.
Inline removal, OTOH, is removed hereby since buggy.
This change reflects what PPP is actually capable off under
the hood and no functional changes intended.
You could still post a different type but since the goal is
to get rid of posting anything related to PPP this will make
it easier to judge if people actually used this.
We want to avoid modifying ports for the PPP devices and
rearrange the type feed slightly. Most of the PHP warnings
on this page relate to PPP trickery that will go away.
Next step will be only offering the matching IPv4/6 types.
Fix one valid warning while here.