15133 Commits

Author SHA1 Message Date
Franco Fichtner
23dc326bb3 src: whitespace vs. stable 2023-03-24 10:22:36 +01:00
Franco Fichtner
f6bf94c8c9 ui: whitespace 2023-03-24 09:59:52 +01:00
Ad Schellevis
4082fb4283 System/Logging - timezone parsing issue for zones west of UTC [-]. closes https://github.com/opnsense/core/pull/6443 2023-03-24 09:27:42 +01:00
Franco Fichtner
dfa4bbdfd3 unbound: avoid trailing URL slashes, restrict ACL to single page
Looks like advanced page doesn't have its own ACL entry since 33a253a7487f592
but it probably should still have it?
2023-03-24 09:05:27 +01:00
Ad Schellevis
fa30a8c1e4 Lobby: Dashboard - fix openvpn status reference 2023-03-23 19:46:00 +01:00
kulikov-a
9473b40e9a
Dashboard / widgets / OpenVPN - typo (#6438) 2023-03-23 19:01:06 +01:00
Franco Fichtner
019ea52790 system: do not detach on defer ##6351
Same as filter_configure() now.
2023-03-23 15:59:57 +01:00
Franco Fichtner
ea10c72f7d system: looks like we mask "loss" when "delay" is also reported
Add a new status although we didn't want to extend the functionality,
but this does look like a bug when loss indicator is used but not
properly reported.

PR: https://github.com/opnsense/core/issues/6231
2023-03-23 09:09:32 +01:00
NOYB
e790c17786
Firewall/Alias - replace 'T' with space for timestamp display 2023-03-23 08:52:30 +01:00
Franco Fichtner
c9e78e2cd1 plugins: trailing whitespace 2023-03-22 21:41:32 +01:00
Franco Fichtner
589d57028b ipsec: switcheroo for #6372 2023-03-22 20:55:45 +01:00
Ad Schellevis
9f2ad523b5 Reporting/Health - sort interfaces by description. closes https://github.com/opnsense/core/issues/6434
As we rather don't want to change the api dataformat too much at the moment, we could sort by description in the controller for packets and traffic and move the interface mapping into the getRRDlistAction() response. This should keep all backwards compatible and offers improved sorting with limited impact.
2023-03-22 14:42:46 +01:00
Franco Fichtner
16492ceddd src: whitespace cleanups 2023-03-22 09:14:05 +01:00
Ad Schellevis
38dfe47258 Firewall: Aliases - leave out fractional seconds from timestamps. closes https://github.com/opnsense/core/pull/6432 2023-03-22 08:59:04 +01:00
Franco Fichtner
33ad50456a system: defer start of lighttpd on newwanip event #6351
Looks like improvements in 23.1.4 made the problem worse, indicating
that the direction this is going is a bit doubtful.  Instead, funnel
the restart through configd to reach some state of serialization
similar to what filter_configure() is doing.

While here move the service definition to the correct file.
2023-03-22 08:00:57 +01:00
Franco Fichtner
bbbed94a93 Revert "dhcp: radvd HUP brings back the infamous "can't join ipv6-allrouters" error"
This reverts commit 38049e4ea8b342b6c5f7705e69c2e0034dc67914.
This can be fixed in radvd.
2023-03-21 21:18:53 +01:00
Franco Fichtner
b50e529511 openvpn: style sweep 2023-03-21 19:50:50 +01:00
Franco Fichtner
38049e4ea8 dhcp: radvd HUP brings back the infamous "can't join ipv6-allrouters" error
PR: https://forum.opnsense.org/index.php?topic=33148.0
2023-03-21 19:05:10 +01:00
Ad Schellevis
c8970545a7 VPN: OpenVPN: Connection Status - empty (null || '') on start/stop/restart should respond with an error. as discussed with @fichtner 2023-03-21 16:32:13 +01:00
Ad Schellevis
b9a1633a18 VPN: OpenVPN: Connection Status - refactor to MVC closes https://github.com/opnsense/core/issues/6382
o rename virtual_addr --> virtual_address in status call out
o add new endpoints to search connections and routes, kill sessions and service control
o remove old status page status_openvpn.php and change ACL and Menu registration
o offer two tab view on sessions / routes
o service controls (restart/start/stop) are shown for non client based records (p2p and client mode) or when no clients are connected.
2023-03-21 15:25:59 +01:00
Franco Fichtner
2d31af2a5e firewall: remove debug 2023-03-21 10:07:42 +01:00
Franco Fichtner
cc6857e597 ui: since touched make it 100% correct 2023-03-21 09:56:33 +01:00
Franco Fichtner
25f7d0e407 unbound: use deferred.reject() to clear spinner 2023-03-21 09:50:43 +01:00
Franco Fichtner
3032474e9f unbound: fix typo and adjust message
Try to to point user to do something and instead just tell them why
this cannot be accepted.
2023-03-21 09:31:00 +01:00
Franco Fichtner
0a43ee9041 unbound: validation message can trigger twice, but it's only about the port 2023-03-21 09:25:41 +01:00
Franco Fichtner
97e683e99d Revert "unbound: fixup defaults in migration and namespace changes"
This reverts commit ffc1c438e02ae209b8ad690907d3fad8f74a6248 to be able
to test the migration easily.  We didn't set the full data (at least
local_zone_type was missing) but then again we do not have to.

Also seeing that we did not have OPNsense section before or version
attribute let us try to keep this status quo for a little longer.
2023-03-21 09:15:29 +01:00
Franco Fichtner
7e470ec60b unbound: according to model this value is required/has a default
For the function maybe it's better to pass a model than read MVC data
via legacy config access.
2023-03-21 09:11:22 +01:00
Franco Fichtner
d0553f74d5 system: yep, need script_output 2023-03-21 08:47:35 +01:00
Franco Fichtner
66c93c6835 system: also add status since we have it 2023-03-21 08:45:56 +01:00
Franco Fichtner
c02198fa58 firmware: extend messages for subscription errors; closes #6373 2023-03-21 08:37:13 +01:00
Ad Schellevis
4ef3c1fbe8 Interfaces: Virtual IPs: Settings - ip alias + vhid validation issue, likely fix for https://github.com/opnsense/core/issues/6422 2023-03-20 20:19:43 +01:00
Franco Fichtner
d22144e3a9 unbound: simplify description and remove hint 2023-03-20 10:44:36 +01:00
Stephan de Wit
bc05c8f59d unbound: general: update port description and default to disabled 2023-03-20 10:06:54 +01:00
Stephan de Wit
e9285f254b unbound: blocklists: adjust to rename 2023-03-20 09:15:49 +01:00
Franco Fichtner
e2d0376e0c system: service API cleanups 2023-03-20 09:14:39 +01:00
Stephan de Wit
b8d3e6a7ef unbound: blocklists: lowercase all domains
while here, also add size check to cached blocklists, as they might be empty
due to network errors.
2023-03-20 09:05:52 +01:00
Franco Fichtner
667b50d564 network time: fix minor warnings in code 2023-03-20 08:41:56 +01:00
Stephan de Wit
ffc1c438e0 unbound: fixup defaults in migration and namespace changes 2023-03-17 15:57:30 +01:00
Franco Fichtner
a50897b517 firmware: make error messages for subscriptions clearer #6373
These are the backend issues we have been having.  We can improve the
messages later, perhaps add better instructions.
2023-03-17 10:03:41 +01:00
Franco Fichtner
42e519d089 firmware: add advanced/help toggles, cancel button #6373 2023-03-17 08:45:26 +01:00
Ad Schellevis
d1468a3f82 Interfaces: Diagnostics: Ping - minor adjustments for https://github.com/opnsense/core/issues/6378, limit the maximum runtime to a day, fix form help an add source address 2023-03-16 21:35:15 +01:00
Franco Fichtner
ffcda5bd14 system: fix ACL, copied from @adschellevis ;) 2023-03-16 21:05:18 +01:00
Ad Schellevis
83ccec4330 Interfaces: Diagnostics: Ping - refactor diagnostics tool (https://github.com/opnsense/core/issues/6378) 2023-03-16 20:23:22 +01:00
Ad Schellevis
f7d7dafccd stylefix 2023-03-16 17:30:42 +01:00
Franco Fichtner
617bd3faf5 system: convert widget to API use with aut-refresh; closes #6376 2023-03-16 12:56:47 +01:00
Ad Schellevis
b528952260 VPN/OpenVPN - add missing static-challenge parsing, should fix https://forum.opnsense.org/index.php?topic=32939.msg159861#msg159861 2023-03-16 10:26:43 +01:00
Ad Schellevis
3f7452cb0b System: Settings: Tunables - prevent applying tunables which are already set, this should fix some issues with buggy drivers resetting when setting a tunable to the value it already had. 2023-03-16 10:19:22 +01:00
Ad Schellevis
4b2b600509 VPN/OpenVPN - reintroduce "cipher" keyword for older clients. closes https://github.com/opnsense/core/issues/6420 partly reverts 1e28d5b352 , only remove "none" cipher for now and assure its not being set by default for new connections. 2023-03-16 09:37:06 +01:00
Franco Fichtner
9f771860a7 system: disable checkboxes in service list but keep visually appealing padding 2023-03-16 09:07:06 +01:00
Franco Fichtner
e42b8a3018 unbound: move this here
Perhaps we should break with the "empty" default value as the model is
more capable of ensuring defaults and it avoids a bit of bootstrapping
in cases we need to read a value.  Port 53 is not likely going to change
away for DNS.
2023-03-16 08:50:47 +01:00