13593 Commits

Author SHA1 Message Date
Franco Fichtner
17b294b38e system: generic rewrite of ssh advanced opts
o Batch the backend call calling from GUI once and
  only if needed from configuration.
o Turn the configuration into a generic loop.
o Move advanced options to the back of the configuration.
o Warning level for both log messages.
2022-01-18 16:42:16 +01:00
Franco Fichtner
7e1e676b53 src: style sweep 2022-01-18 15:19:36 +01:00
Manuel Faux
3b164749d3
Allow to configure SSH setting PubkeyAcceptedAlgorithms via GUI (#5400)
As OpenSSH 8.8 disables RSA signatures using the SHA-1 hash algorithm
by default some older SSH clients might not be able to connect to
OPNsense anymore. Therefore, it might be needed to manually modify the
PubkeyAcceptedAlgorithms sshd config option.

Prevent generating of invalid configuration values for dynamic
crypto parameters (KexAlgorithms, Ciphers, MACs, HostKeyAlgorithms and
PubkeyAcceptedAlgorithms).
2022-01-18 15:14:59 +01:00
kulikov-a
20744fcdbb
Backend.php: syslog-ng migration (#5383) 2022-01-18 14:53:40 +01:00
agh1467
dedb117935 dnsmasq: no hosts option; closes #5374
* Add checkbox to enable --no-hosts command line option
2022-01-18 13:59:46 +01:00
Franco Fichtner
2fdaab1552 system: separate core and thread count
Some people find it confusing that "cores" references threads.
2022-01-18 12:11:26 +01:00
Franco Fichtner
494733dbd5 interfaces: correct comment
First spot is CREATION, second one is CONFIGURATION
2022-01-18 10:50:14 +01:00
Ad Schellevis
d256abe769 Interfaces / VXLAN - move vxlan_prepare prepare up in order to be able to combine it with bridging.
(so we don't forget when working on https://github.com/opnsense/core/issues/5411)
2022-01-18 10:47:20 +01:00
NOYB
f0235a79d0
DNS Rebind Check Case Sensitivity (#5484) 2022-01-18 08:40:15 +01:00
Franco Fichtner
f59b712f68 firewall: copy+paste fail 2022-01-18 07:59:57 +01:00
Franco Fichtner
272b47312a ui: whitespace sweep 2022-01-18 07:57:06 +01:00
Franco Fichtner
26e3670284 firewall: belongs to 21fe4db493594 #5467 2022-01-18 07:49:07 +01:00
Markus Reiter
f7de23e9bd Fix CARP PPP hook. 2022-01-18 06:41:38 +01:00
Ad Schellevis
59ae021d5a MVC - ModelRelationField, small cleanups and simplifications for https://github.com/opnsense/core/pull/5429 2022-01-17 21:30:36 +01:00
agh1467
9c28a6eaa2
mvc: Add BlankDesc to ModelRelationField (#5429)
* mv: Add BlankDesc to ModelRelationField

* Add BlankDesc option for ModelRelationField types.
* Copied from BaseListField type.

* mvc: refactor ModelRelationField and add unit test

This follows the refactor effort in #3252 where
ModelRelationField was excluded.

* ModelRelationField.php
  * Extend from BaseListField type
  * Remove vars which are inherited from BaseListField
  * Remove functions which are inherited from BaseListField
  * Add $internalCacheOption for internal manipulation
  * Comments throughout

* ModelRelationFieldTest.php
  * Add comments for all test to described in plain language
  * Add a few tests focused on BlankDesc
  * Add some more sort related tests
  * Add some other possible scenarios
2022-01-17 22:15:04 +01:00
Manuel Faux
683128ba76
Move storing jQuery Bootgrid settings in browser from core to bootgrid (#5443)
* Move storing jQuery Bootgrid settings in browser from core to bootgrid

- Update of jquery.bootgrid.js from 1.3.5 to 1.4.0 (opnsense/jquery-bootgrid#5)
- Removing of equivalent functionality from opnsense_bootgrid_plugin.js

* Bugfix when restoring row count to pre-select entry in dropdown
2022-01-17 20:09:06 +01:00
Ad Schellevis
c30e535ac9 IDPS - ET Pro telemetry 5 uses the new name scheme of version 6, which we accidentially didn't take under account when migrating ET-open. make sure we do fetch the new rulesets as being published for 6 (related to https://github.com/opnsense/core/pull/5482) 2022-01-17 18:28:27 +01:00
Franco Fichtner
68775a50e8 system: fix warnings that only appear when validation fails 2022-01-17 17:35:05 +01:00
Pierre Fèvre
981373b4cd system: allow additional search domain; closes #5102 2022-01-17 17:35:05 +01:00
Ad Schellevis
62f1a9d811 Refactor web application security measures, closes https://github.com/opnsense/core/issues/5481 2022-01-17 17:15:14 +01:00
Franco Fichtner
df7882cfa9 network time: remove PID if it is generally unreliable; closes #5214 2022-01-17 16:46:25 +01:00
Franco Fichtner
a94c63b2b7 dhcp: kill "static" mode, move flags to advanced #5185
While technically not correct to make flags "AdvDeprecatePrefix"
and "AdvRemoveRoute" we simply use it to overwrite the existing
defaults which depend on CARP-or-not situation in the address
being used.

There was an extensive discussion about what it should and should
not do but the only way to keep the current defaults AND provide
requested overrides is this one.

The valid values are either "off" or "on", but no validation
takes place as customary to this page's advanced options. Use
with care.
2022-01-17 16:19:14 +01:00
Franco Fichtner
21fe4db493 system: shared forwarding to #5467 2022-01-17 15:46:35 +01:00
Ad Schellevis
e1a3c402fc dyndns - remove dyndns references as they should manage themselves. closes https://github.com/opnsense/core/issues/5434 2022-01-17 14:48:37 +01:00
Franco Fichtner
aa2625998d system: cache obfuscated version info from syslog-ng binary #5371
It changes with each build since it has a rebuild date but most
of the time it is not being reinstalled.  Besides this helps testing
and is relatively portable since we don't rely on the actual content.
2022-01-17 13:45:37 +01:00
Franco Fichtner
766dc45283 system: remove system_arp_wrong_if() in favour of #5467
It applies all sysctls on interfaces settings save but there
isn't much of a point splitting the functionality or hardcoding
yet another spot with the required sysctls.
2022-01-17 12:37:15 +01:00
Franco Fichtner
8c71359163 system: prevent more than one default route by default
PR: https://forum.opnsense.org/index.php?topic=26341.0
2022-01-17 12:27:58 +01:00
Ad Schellevis
cb73aa736d Reporting: Traffic - Total IN/OUT reporting same (total) values, closes https://github.com/opnsense/core/issues/5479 2022-01-07 20:28:37 +01:00
Ad Schellevis
bcf8e4f6c1 Framework - Logging : when the default severity level is different than "Warning" because the application doesn't send anything else out, make sure to push these defaults via the controller. style fix previous 2022-01-07 19:23:37 +01:00
Ad Schellevis
b39b8f22c9 Framework - Logging : when the default severity level is different than "Warning" because the application doesn't send anything else out, make sure to push these defaults via the controller. closes https://github.com/opnsense/core/pull/5472
In a future version we might want to be able to ship metadata per log view, in which case the service binding and defaults should be provided from there.
2022-01-07 18:24:40 +01:00
Franco Fichtner
88334b838a system: sync recovery contents with FreeBSD 13
/etc/ttys has two more entries one of which we add conditionally
and the other one we don't need so for now don't add these two.

When we rework the code in system.inc we can include them later
in the new way.
2022-01-14 11:52:50 +01:00
Franco Fichtner
50204d822b system: forgot to switch these as not "gateway" address 2022-01-13 12:22:22 +01:00
Franco Fichtner
6dba59f279 system: use correct IPv6 interface
Suspicion confirmed that e.g. 6RD misses the wrong interface.
Just run the code when necessary instead of caching it for
a situation that isn't matching.
2022-01-13 12:15:37 +01:00
Franco Fichtner
61e0b950cc system: remove problematic "validation"
We do validate later when we try to restore anyway.  It even has
the same validation message...

PR: https://forum.opnsense.org/index.php?topic=26325.0
2022-01-13 11:43:11 +01:00
Zsolt Zsiros
a0cddb683c
services/ntp - detach limited from kod, correct help text (#5473) 2022-01-13 11:28:02 +01:00
Franco Fichtner
600dc95b58 system: annotate problematic code
See: https://forum.opnsense.org/index.php?topic=26296.0
2022-01-11 20:15:23 +01:00
Franco Fichtner
61720fe233 scripts: tabs vs. spaces 2022-01-11 11:22:03 +01:00
Franco Fichtner
6806f624b7 system: add msdosfs and sort array
Since /boot/efi is the default in FreeBSD 13 and will be
auto-mounted through /etc/fstab it makes sense to show it
in the dashboard as an active partition.
2022-01-10 13:07:37 +01:00
Ad Schellevis
fb041467bf
IDPS : fix typo in https://github.com/opnsense/core/pull/5413 2022-01-08 21:17:01 +00:00
Franco Fichtner
2a970b568a src: style sweep 2022-01-07 12:24:18 +01:00
Franco Fichtner
c3d96426a3 Revert "fix copy-and-paste error in help div"
This reverts commit b2bca01f9ca5bcdfc7ea66df6f32b74bfaf8c488.
Actually there is no way to toggle these two so this is expected.
2022-01-07 12:10:45 +01:00
Franco Fichtner
5b77e24fa6 importer: issue with display when no ZFS is there 2022-01-07 10:45:34 +01:00
Franco Fichtner
d84768c82c ipsec: a long long time ago, I can't still remember...
See: https://github.com/opnsense/src/commit/18b9d9d9365
2022-01-07 10:00:41 +01:00
Franco Fichtner
c17899c76c firmware: almost there 2022-01-07 09:53:51 +01:00
Ad Schellevis
7672d54c78 IPsec: FreeBSD 13 compatibility fixes, closes https://github.com/opnsense/core/issues/5450, https://github.com/opnsense/core/issues/5464
o remove unsupported algorithms, which have been removed in https://cgit.freebsd.org/src/commit/?id=16aabb761c0a
o make sure to load the ipsec module similatr to what the new rc scripts do (https://github.com/freebsd/freebsd-ports/commit/3b35676c7a812c7)
o while here, simplify the algo selector and remove the weird checkbox/select options, keep backward compatibility for aes key key lengths.
2022-01-06 14:14:25 +01:00
Paolo Asperti
8222c6517e
add API call api/diagnostics/interface/get_interface_config (#5448)
exposes system ifconfig to the API
2022-01-06 09:04:03 +01:00
Franco Fichtner
7d7db31673 LICENSE: sync 2022-01-05 09:37:37 +01:00
Franco Fichtner
a8c6bd924d system: display system tunables as well
This sort of completes the previous effort to improve the
sysctl handling.  The idea to embed sysctls into the config.xml
is certainly valid, but for some values we needed more leeway
for system defaults and changing them over time, which lead
to this state where we can drop config.xml default tunables
since the system will now apply and display then for the same
visibility but offer less incentive to change these values.

One thing missing here is adding a system tunable override
(plus sign) for system values, but we shall deal with this later
because for now they can always be added manually by copy+paste.
2022-01-05 09:33:22 +01:00
Franco Fichtner
1ccfd260e9 firmware: show "misconfigured" first before defaulting to "orphaned"
The reason for this is the plugin conflict dialog pops up but it is
unclear what it wants.  Once reset the orphaned status will be dispayed.
2022-01-05 08:36:05 +01:00
Franco Fichtner
a7ad2845a1 mvc: translate screen reader labels where we can 2022-01-05 07:54:38 +01:00