17249 Commits

Author SHA1 Message Date
Stephan de Wit
095e26f809 dashboard: restructure previous 2024-09-04 11:06:50 +02:00
Stephan de Wit
ae2f17957f dashboard: do not save x/y coordinates on smaller screens 2024-09-04 11:01:57 +02:00
Franco Fichtner
4421914442 system: update comment on temperature stats collection 2024-09-03 20:57:09 +02:00
Franco Fichtner
6f21218193 system: remove RRD temp read from temperature.sh 2024-09-03 14:48:07 +02:00
Monviech
9a71a3919e
dashboard: Construct Wireguard.js row ID from if+public-key (#7838)
* dashboard: Construct Wireguard.js row ID from if+public-key to ensure uniqueness when public keys are reused.

* dashboard: Wireguard.js use concatenated string for uniqueId
2024-09-03 13:41:49 +02:00
Franco Fichtner
87b8999d99 network time: reduce diff with previous, change to query property 2024-09-03 12:48:57 +02:00
doktornotor
7f0871c21f
Enable restrict noquery by default for ntpd (#7830)
See #7832
2024-09-03 10:59:18 +02:00
Franco Fichtner
40db484e07 interfaces: minimize reload exposure on interface apply
Refine this after consulting @adschellevis on the main concern of the
code here.
2024-09-03 10:04:11 +02:00
Franco Fichtner
6fb56e5668 intrusion detection: since we add Required=Y we better bump the version 2024-09-03 08:22:51 +02:00
Franco Fichtner
c1609c9055 interfaces: replace 'newwanip_map' from interface apply
This always bugged me: 'newwanip_map' is called when e.g. DHCP is
done but here we just do it async to start something.  This doesn't
make sense, because eventually it triggers twice.

What rc.reload_all and setports.php do is call 'local' and I think
that makes sense.
2024-09-03 08:18:12 +02:00
Franco Fichtner
2dbd793dfe reporting: add executable flag for lint reasons 2024-09-03 08:01:33 +02:00
Franco Fichtner
3476d11a0a reporting: scrub rrd.inc use 2024-09-02 21:27:26 +02:00
Franco Fichtner
89a97ddb28 system: remove rrd_create_gateway_quality(), it's gone? ;) 2024-09-02 21:15:59 +02:00
Franco Fichtner
fcd54e4549 shell: configuration is static here, no need to restart cron/rrd 2024-09-02 21:10:16 +02:00
Franco Fichtner
ecf987820d reporting: style sweep 2024-09-02 21:06:03 +02:00
Ad Schellevis
895e58ff25
Reporting / rrd - refactor existing code (#7836)
Add RRD package with a simple factory class and a basic construct to define different rrd output types we support.
This package contains the following:

* RRD/Types -- Output definitions, responsible for generating RRD structures and feeding data
* RRD/Stats -- Statistics gathering classes
* Factory -- binds types and statistics together. 

On my end on a simple test this is roughly 40% faster than running /var/db/rrd/updaterrd.sh, which makes caching of metadata (config access) less relevant.

The new script should be able to replace all existing rrd cruft and supports a debug mode to find discrepanties between defined outputs in types and collected data in stats.

```
Usage: updaterrd.php [-h] [-d]
            -d debug mode, output errors to stdout
```
2024-09-02 16:40:47 +02:00
Franco Fichtner
54ccb747cd system: handle stale "pfsyncinterfaces" and improve workflow
PR: https://forum.opnsense.org/index.php?topic=42549.0
2024-09-02 12:03:24 +02:00
Franco Fichtner
4c07de7e34 interfaces: remove deprecated "vpn" event
Everything has been converted and plugins do not ship with a
"vpn" event.  "newwanip" is similar and the plugins have been
ensured to be moved to the new one in 24.7.3 already.
2024-09-02 09:25:58 +02:00
Ad Schellevis
f29d93198d System: Trust: Certificates - map derivative field cert_type to expose purpose to the userinterface. closes https://github.com/opnsense/core/issues/7835 2024-09-02 09:18:30 +02:00
Franco Fichtner
0e2812220d interfaces: drop the unmapped events from newwanip scripts 2024-09-02 09:17:29 +02:00
Franco Fichtner
f24d93b8ea openvpn: forgot to switch to mapped event 2024-09-02 09:16:50 +02:00
Franco Fichtner
c17d021b4c interfaces: add proper validation for 6RD and 6to4
Also bring in 947e61b1a5e6fe5 done on stable and refine it further.
So it turns out these run on IPv4 but are immune to "IPv4 connectivity"
switch for better or worse.

PR: https://forum.opnsense.org/index.php?topic=42081.msg211015#msg211015
2024-09-02 09:04:30 +02:00
Ad Schellevis
7d5d2f26b5 VPN: OpenVPN: Connection Status - add username field to the grid, closes https://github.com/opnsense/core/issues/7834
Although we recommend using matching CN's and usernames, it is possible to share a certificate. Since the datafeed already contains the username, let's add the field to the grid.
2024-09-01 21:05:53 +02:00
Ad Schellevis
0227780bbe Reporting / rrd - remove non existing 3g statistics 2024-09-01 14:00:54 +02:00
Franco Fichtner
919fc15fe7 interfaces: rename this correctly, strictly part of pf(sync) 2024-09-01 10:54:46 +02:00
Franco Fichtner
ab3bf029ca interfaces: another cleanup 2024-09-01 10:51:23 +02:00
Franco Fichtner
a3400ea974 interfaces: same same 2024-09-01 10:50:01 +02:00
Franco Fichtner
82397315c0 interfaces: rename two variables for clarity 2024-08-31 13:23:36 +02:00
Ad Schellevis
8d4c1108bf Services: Intrusion Detection: Administration - reorganise settings page with headers (https://github.com/opnsense/core/pull/7775) 2024-08-31 09:33:25 +02:00
Toby Chen
ee15b216aa
IDS: Support configurating eve-log for HTTP and TLS (#7775)
Add the appropriate front end controls and backend template for setting up TLS and HTTP monitoring for Suricata's eve-log.
2024-08-31 09:32:58 +02:00
Franco Fichtner
296399a741 dhcp: fix v6 similar to v4 in c2f7998c70e7a5; closes #7828 2024-08-30 20:39:12 +02:00
Ad Schellevis
9f43314246 Services: Intrusion Detection: Administration - fix regression in https://github.com/opnsense/core/pull/7667, closes https://github.com/opnsense/core/issues/7826 2024-08-29 21:09:14 +02:00
Ad Schellevis
4ee5390318 System: Settings: Administration - SSL Ciphers. When only selecting TLS1.3 ciphers, make sure to only allow 1.3 as well (otherwise default !TLS1.3 will be accepted as well). 2024-08-29 17:00:16 +02:00
Stephan de Wit
7f21da5d0d dashboard: use built-in controller logic for JSON decoding 2024-08-29 13:27:24 +02:00
Franco Fichtner
090c6518d7 interfaces: fix issue with PPP port not being posted; closes #7823
Unify the situation for 'ppp_port' vs 'ports' use by using the latter
as is.  One of the issues of this page always was inconsistency after
all.  Then also zap the validation that causes the changes not to be
accepted.  In theory it's posted anyway but that has been the case for
PPPoE/L2TP/PPTP since the fork.
2024-08-29 09:29:53 +02:00
Franco Fichtner
ba72ab76d3 system: remove (inconsistent) prefix from default snapshot names
Also want to avoid confusion about "BE" meaning business edition.
2024-08-29 08:47:39 +02:00
Nigel Jones
5e5cab98b4
unbound: discard-timeout (#7512)
* unbound: discard-timeout

Signed-off-by: Nigel Jones <nigel.l.jones+git@gmail.com>

* Update src/opnsense/mvc/app/models/OPNsense/Unbound/Unbound.xml

Co-authored-by: Franco Fichtner <franco@lastsummer.de>

* unbound: update field help text

---------

Signed-off-by: Nigel Jones <nigel.l.jones+git@gmail.com>
Co-authored-by: Franco Fichtner <franco@lastsummer.de>
Co-authored-by: Stephan de Wit <stephan.de.wit@deciso.com>
2024-08-28 14:40:29 +02:00
Franco Fichtner
95ad427723 src: style sweep 2024-08-28 14:38:19 +02:00
Stephan de Wit
186cc36a14 dashboard: fix ACL check on dashboard restore and add safety check for save action
Parsing the persisted dashboard requires decoding it, which by extension means we don't need to encode it anymore when returning the dashboard. In all cases, this commit now makes sure that dashboard is filtered according to access rights.

While here, invalid input can be filtered out partly by check the result of json_decode(), so do this when saving the widgets.
2024-08-28 14:16:57 +02:00
Franco Fichtner
ce9ed275d0 system: fix PHP error and annotate a tiny bit more #7027 2024-08-28 11:42:42 +02:00
Franco Fichtner
c0bee56c10 system: manual gateway switch via cron for #7027 2024-08-28 10:13:34 +02:00
Franco Fichtner
0b42c910c4 firmware: typo 2024-08-27 12:20:39 +02:00
Franco Fichtner
8b7510a3a6 firmware: use full plugin names now and make sure to zap whitespace; closes #7818 2024-08-27 12:10:41 +02:00
Franco Fichtner
d1c7ed00ab firmware: collect plugin conflicts and remove them #7818
Also let conficts generate with its sibilings so we can remove
all of that code from the register script.  Most things are
fixed automatically now.
2024-08-27 11:01:48 +02:00
Franco Fichtner
7dc89a322d firmware: make conflicts known, better way for #7195 via #7818 2024-08-27 09:42:11 +02:00
Franco Fichtner
ccac4779b7 interfaces: introduce vpn_map event
There appear to be no callers in plugins.  We could argue
that the vpn/vpn_map event isn't really needed as it brings
just OpenVPN, IPsec and WireGuard to the table, but we can
decide on this later.
2024-08-26 23:29:32 +02:00
Franco Fichtner
0e4cb12f3f ipsec: unfortunately the previous was never empty()
PR: https://forum.opnsense.org/index.php?topic=42407.0
2024-08-26 20:26:26 +02:00
Franco Fichtner
1717cf05b5 system: in style we trust 2024-08-26 19:57:12 +02:00
Franco Fichtner
178ef826f7 ipsec: fix off-by-section in ipsec migration
PR: https://forum.opnsense.org/index.php?topic=42407.0
2024-08-26 19:56:10 +02:00
Ad Schellevis
7993a82e84 VPN: IPsec: Advanced Settings - minor regression in https://github.com/opnsense/core/issues/7648 , ike_name and log_level should be moved to daemon section. 2024-08-26 16:15:10 +02:00