lucaspalomodevelop/opnsense-core
1
0
Fork 0
mirror of https://github.com/lucaspalomodevelop/opnsense-core.git synced 2026-03-13 00:07:27 +00:00
Code Issues Packages Projects Releases Wiki Activity

interfaces: prevent CARP IP removal when VHID group is in use by IP alias

Browse Source
This commit is contained in:
Stephan de Wit 2024-09-09 14:53:05 +02:00
parent ebddde95f4
commit e415eb8230
1 changed files with 12 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

12
src/opnsense/mvc/app/controllers/OPNsense/Interfaces/Api/VipSettingsController.php
View File

@ -186,6 +186,18 @@ class VipSettingsController extends ApiMutableModelControllerBase
if (!empty($validations)) {
throw new UserException(implode('<br/>', array_slice($validations, 0, 5)), gettext("Item in use by"));
}
if ($node != null && (string)$node->mode == 'carp') {
foreach ($this->getModel()->vip->iterateItems() as $vip) {
if ((string)$vip->mode == 'ipalias' && (string)$vip->vhid == (string)$node->vhid) {
$vhid = (string)$node->vhid;
throw new UserException(sprintf(
gettext("Cannot delete CARP Virtual IP, IP Alias with VHID Group %s still exists."), $vhid),
gettext("Error"));
}
}
}
$response = $this->delBase("vip", $uuid);
if (($response['result'] ?? '') == 'deleted') {
$addr = (string)$node->subnet;