From 7beec43db9273308e70c4c272fdcbaca0efa41bf Mon Sep 17 00:00:00 2001 From: Ad Schellevis Date: Sun, 20 Apr 2025 10:54:22 +0200 Subject: [PATCH] Services: Dnsmasq DNS & DHCP - fix validation for static ipv4, closes https://github.com/opnsense/core/issues/8568 --- .../mvc/app/models/OPNsense/Dnsmasq/Dnsmasq.php | 11 ++++++++++- 1 file changed, 10 insertions(+), 1 deletion(-) diff --git a/src/opnsense/mvc/app/models/OPNsense/Dnsmasq/Dnsmasq.php b/src/opnsense/mvc/app/models/OPNsense/Dnsmasq/Dnsmasq.php index dfcf5c570..5c4061487 100644 --- a/src/opnsense/mvc/app/models/OPNsense/Dnsmasq/Dnsmasq.php +++ b/src/opnsense/mvc/app/models/OPNsense/Dnsmasq/Dnsmasq.php @@ -175,7 +175,16 @@ class Dnsmasq extends BaseModel ); } - if (in_array('static', explode(',', $range->mode)) && $start_inet == 'inet6') { + $is_static = in_array('static', explode(',', $range->mode)); + if (!$range->end_addr->isEmpty() && $is_static) { + $messages->appendMessage( + new Message( + gettext("Static only accepts a starting address."), + $key . ".end_addr" + ) + ); + } + if ($is_static && $start_inet == 'inet6') { $messages->appendMessage( new Message( gettext("Static is only available IPv4."),