From 596b4c8f3970fb4e500f38e66615a1a90b7684a3 Mon Sep 17 00:00:00 2001 From: ryanmerolle Date: Tue, 19 Jul 2022 14:05:34 +0000 Subject: [PATCH] seperate choices from models --- netbox_access_lists/choices.py | 29 +++++++++++++++++++++++++++++ netbox_access_lists/models.py | 32 +------------------------------- 2 files changed, 30 insertions(+), 31 deletions(-) create mode 100644 netbox_access_lists/choices.py diff --git a/netbox_access_lists/choices.py b/netbox_access_lists/choices.py new file mode 100644 index 0000000..0a5aaa6 --- /dev/null +++ b/netbox_access_lists/choices.py @@ -0,0 +1,29 @@ +from utilities.choices import ChoiceSet + +class ACLActionChoices(ChoiceSet): + ACTION_DENY = 'deny' + ACTION_PERMIT = 'permit' + ACTION_REJECT = 'reject' + + CHOICES = [ + (ACTION_DENY, 'Deny', 'red'), + (ACTION_PERMIT, 'Permit', 'green'), + (ACTION_REJECT, 'Reject (Reset)', 'orange'), + ] + + +class ACLTypeChoices(ChoiceSet): + + CHOICES = [ + ('extended', 'Extended', 'purple'), + ('standard', 'Standard', 'blue'), + ] + + +class ACLProtocolChoices(ChoiceSet): + + CHOICES = [ + ('icmp', 'ICMP', 'purple'), + ('tcp', 'TCP', 'blue'), + ('udp', 'UDP', 'orange'), + ] diff --git a/netbox_access_lists/models.py b/netbox_access_lists/models.py index 1870ba3..15b1462 100644 --- a/netbox_access_lists/models.py +++ b/netbox_access_lists/models.py @@ -3,37 +3,7 @@ from django.db import models from django.urls import reverse from netbox.models import NetBoxModel -from utilities.choices import ChoiceSet - - -class ACLActionChoices(ChoiceSet): - key = 'ACLExtendedRule.action' - ACTION_DENY = 'deny' - ACTION_PERMIT = 'permit' - ACTION_REJECT = 'reject' - - CHOICES = [ - (ACTION_DENY, 'Deny', 'red'), - (ACTION_PERMIT, 'Permit', 'green'), - (ACTION_REJECT, 'Reject (Reset)', 'orange'), - ] - - -class ACLTypeChoices(ChoiceSet): - - CHOICES = [ - ('extended', 'Extended', 'purple'), - ('standard', 'Standard', 'blue'), - ] - - -class ACLProtocolChoices(ChoiceSet): - - CHOICES = [ - ('icmp', 'ICMP', 'purple'), - ('tcp', 'TCP', 'blue'), - ('udp', 'UDP', 'orange'), - ] +from netbox_access_lists.choices import * class AccessList(NetBoxModel):