lucaspalomodevelop/netbox-acls
1
0
Fork 0
mirror of https://github.com/lucaspalomodevelop/netbox-acls.git synced 2026-03-12 23:27:23 +00:00
Code Issues Packages Projects Releases Wiki Activity

put in logic to prevent ACL type change if it has rules

Browse Source
This commit is contained in:
ryanmerolle 2022-07-18 20:05:54 +00:00
parent b877949d76
commit 163287da4f
1 changed files with 6 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
netbox_access_lists/forms.py
View File

@ -51,7 +51,7 @@ class AccessListForm(NetBoxModelForm):
help_texts = {
'default_action': 'The default behavior of the ACL.',
'name': 'The name uniqueness per device is case insensitive.',
'type': 'Sets the type of the ACL & its rules.',
'type': mark_safe('<b>*Note:</b> CANNOT be changed if ACL Rules are assoicated to this Access-List.'),
}
def clean(self):
@ -60,8 +60,13 @@ class AccessListForm(NetBoxModelForm):
return cleaned_data
name = cleaned_data.get('name')
device = cleaned_data.get('device')
type = cleaned_data.get('type')
if ('name' in self.changed_data or 'device' in self.changed_data) and AccessList.objects.filter(name__iexact=name, device=device).exists():
raise forms.ValidationError('An ACL with this name (case insensitive) is already associated to this device.')
if type == 'extended' and self.instance.aclstandardrules.exists():
raise forms.ValidationError('This ACL has Standard ACL rules already associated, CANNOT change ACL type!!')
elif type == 'standard' and self.instance.aclextendedrules.exists():
raise forms.ValidationError('This ACL has Extended ACL rules already associated, CANNOT change ACL type!!')
return cleaned_data
class AccessListFilterForm(NetBoxModelFilterSetForm):