From d143f2900921c8998e815d7dce195b24abc0a83f Mon Sep 17 00:00:00 2001 From: alemuntoni Date: Tue, 19 May 2020 17:38:30 +0200 Subject: [PATCH] fix wrong condition gl extensions init in filter ao --- src/common/GLExtensionsManager.cpp | 8 ++++++++ src/meshlabplugins/filter_ao/filter_ao.cpp | 2 +- 2 files changed, 9 insertions(+), 1 deletion(-) diff --git a/src/common/GLExtensionsManager.cpp b/src/common/GLExtensionsManager.cpp index d8db4efec..e9aa7134e 100644 --- a/src/common/GLExtensionsManager.cpp +++ b/src/common/GLExtensionsManager.cpp @@ -30,6 +30,10 @@ void GLExtensionsManager::init() glewInitialized = false; } +/** + * @brief initializes the GL extensions context, without thorwing any exception + * @return true if the context has been correctly initializes, false otherwise + */ bool GLExtensionsManager::initializeGLextensions_notThrowing() { GLenum err = GLEW_OK; @@ -48,6 +52,10 @@ bool GLExtensionsManager::initializeGLextensions_notThrowing() } +/** + * @brief initializes the GL extensions context, thorwing a MLException if something + * wrong happens during the initialization. + */ void GLExtensionsManager::initializeGLextensions() { if (!glewInitialized) { diff --git a/src/meshlabplugins/filter_ao/filter_ao.cpp b/src/meshlabplugins/filter_ao/filter_ao.cpp index 4ad2d1a29..344198d36 100644 --- a/src/meshlabplugins/filter_ao/filter_ao.cpp +++ b/src/meshlabplugins/filter_ao/filter_ao.cpp @@ -378,7 +378,7 @@ void AmbientOcclusionPlugin::initGL(vcg::CallBackPos *cb, unsigned int numVertic { //******* INIT GLEW ********/ cb(0, "Initializing: Glew and Hardware Capabilities"); - if (GLExtensionsManager::initializeGLextensions_notThrowing()) + if (!GLExtensionsManager::initializeGLextensions_notThrowing()) { Log(GLLogStream::SYSTEM, "Error initializing OpenGL extensions"); errInit = true;