From 4c9b7ff6ad9f83298573f57aa6af28e9e73eac9a Mon Sep 17 00:00:00 2001
From: jmespadero <josemiguel.espadero@urjc.es>
Date: Mon, 25 Nov 2019 17:26:08 +0100
Subject: [PATCH] Fix help messages in the Per_Face_Quality dialog

I fixed the messages in the "Per face quality depending on triangle shape" dialog according to current code.  Old messages were defined for old code in the 2016-12 version.

This is the new dialog after applying the changes:
![](https://i.stack.imgur.com/urHic.png)
---
 .../filter_colorproc/filter_colorproc.cpp     | 23 +++++++++++--------
 1 file changed, 14 insertions(+), 9 deletions(-)

diff --git a/src/meshlabplugins/filter_colorproc/filter_colorproc.cpp b/src/meshlabplugins/filter_colorproc/filter_colorproc.cpp
index 3219ece3e..49cd62ea1 100644
--- a/src/meshlabplugins/filter_colorproc/filter_colorproc.cpp
+++ b/src/meshlabplugins/filter_colorproc/filter_colorproc.cpp
@@ -142,10 +142,15 @@ FilterColorProc::~FilterColorProc()
 	case CP_DISCRETE_CURVATURE: return QString("Colorize according to various discrete curvature computed as described in:<br>"
 		"'<i>Discrete Differential-Geometry Operators for Triangulated 2-Manifolds</i>' <br>"
 		"M. Meyer, M. Desbrun, P. Schroder, A. H. Barr");
-	case CP_TRIANGLE_QUALITY: return QString("Compute a quality and colorize faces depending on triangle quality:<br>"
-		"1: minimum ratio height/edge among the edges<br>"
-		"2: ratio between radii of incenter and circumcenter<br>"
-		"3: 2*sqrt(a, b)/(a+b), a, b the eigenvalues of M^tM, M transform triangle into equilateral");
+	case CP_TRIANGLE_QUALITY: return QString("Compute a quality and colorize faces depending on triangle shape:<ol>"
+		"<li>area/max side of triangle"
+		"<li>ratio inradius/circumradius (radii of incircle and circumcircle)"
+		"<li>Mean ratio of triangle = area/(a*a + b*b + c*c)"
+		"<li>Area"
+		"<li>Texture Angle Distortion. Difference between angle in 3D space and texture space"
+		"<li>Texture Area Distortion. Difference between area in 3D space and texture space"
+		"<li>Polygonal Planarity (max distance to support plane)"
+		"<li>Polygonal Planarity (relative distance to support plane)");        
 	case CP_VERTEX_SMOOTH: return QString("Laplacian Smooth Vertex Color");
 	case CP_FACE_SMOOTH: return QString("Laplacian Smooth Face Color");
 	case CP_VERTEX_TO_FACE: return QString("Vertex to Face color transfer");
@@ -287,12 +292,12 @@ void FilterColorProc::initParameterSet(QAction *a, MeshDocument& md, RichParamet
 			QStringList metrics;
 			metrics.push_back("area/max side");
 			metrics.push_back("inradius/circumradius");
-			metrics.push_back("mean ratio");
+			metrics.push_back("Mean ratio");
 			metrics.push_back("Area");
 			metrics.push_back("Texture Angle Distortion");
 			metrics.push_back("Texture Area Distortion");
-			metrics.push_back("Planarity (abs plane dist)");
-			metrics.push_back("Planarity (relative)");
+			metrics.push_back("Polygonal planarity (max)");
+			metrics.push_back("Polygonal planarity (relative)");
 
 			par.addParam(new RichEnum("Metric", 0, metrics, tr("Metric:"), tr("Choose a metric to compute triangle quality.")));
 			break;
@@ -712,12 +717,12 @@ switch(ID(filter))
 						(*fi).Q() = vcg::QualityRadii((*fi).P(0), (*fi).P(1), (*fi).P(2));
 		} break;
 
-		case 2: { //mean ratio
+		case 2: { //Mean Ratio = area/(a*a + b*b + c*c). See vcg::QualityMeanRatio.
 					for (fi = m->cm.face.begin(); fi != m->cm.face.end(); ++fi) if (!(*fi).IsD())
 						(*fi).Q() = vcg::QualityMeanRatio((*fi).P(0), (*fi).P(1), (*fi).P(2));
 		} break;
 
-		case 3: { // AREA
+		case 3: { // Area of triangle
 					for (fi = m->cm.face.begin(); fi != m->cm.face.end(); ++fi) if (!(*fi).IsD())
 						(*fi).Q() = vcg::DoubleArea((*fi))*0.5f;
 					tri::Stat<CMeshO>::ComputePerFaceQualityMinMax(m->cm, minV, maxV);