lucaspalomodevelop/meshlab
1
0
Fork 0
mirror of https://github.com/lucaspalomodevelop/meshlab.git synced 2026-03-18 02:24:38 +00:00
Code Issues Packages Projects Releases Wiki Activity

filterparameter: Protect against self-copy/self-assign

Browse Source
This commit is contained in:
Ryan Pavlik 2019-12-03 16:45:41 -06:00
parent e7425b8163
commit bbb1d86d3d
1 changed files with 10 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

17
src/common/filterparameter.cpp
View File

@ -101,7 +101,8 @@ QList<float> RichParameterSet::getFloatList(QString name) const { return find
RichParameterSet& RichParameterSet::operator=( const RichParameterSet& rps )
{
return copy(rps);
copy(rps);
return *this;
}
bool RichParameterSet::operator==( const RichParameterSet& rps )
@ -132,13 +133,15 @@ RichParameterSet::~RichParameterSet()
RichParameterSet& RichParameterSet::copy( const RichParameterSet& rps )
{
clear();
if (this != &rps) {
clear();
RichParameterCopyConstructor copyvisitor;
for(int ii = 0;ii < rps.paramList.size();++ii)
{
rps.paramList.at(ii)->accept(copyvisitor);
paramList.push_back(copyvisitor.lastCreated);
RichParameterCopyConstructor copyvisitor;
for(int ii = 0;ii < rps.paramList.size();++ii)
{
rps.paramList.at(ii)->accept(copyvisitor);
paramList.push_back(copyvisitor.lastCreated);
}
}
return (*this);
}