renames and fixes

src/common/plugins/interfaces/edit_plugin.h

@@ -46,7 +46,7 @@ public:
 	virtual ~EditPlugin() {}
 
 	//should return a sentence describing what the editing tool does
-	static const QString Info();
+	static const QString info();
 
 	virtual void suggestedRenderingData(MeshModel &/*m*/, MLRenderingData& /*dt*/) {}
 

src/common/plugins/interfaces/filter_plugin.cpp

@@ -1,6 +1,8 @@
 #include "filter_plugin.h"
 #include "../../python/python_utils.h"
 
+#include <QtGlobal>
+
 QString FilterPlugin::pythonFilterName(MeshLabPlugin::ActionIDType f) const
 {
 	return pymeshlab::computePythonName(filterName(f));
@@ -48,10 +50,10 @@ bool FilterPlugin::isFilterApplicable(const QAction* act, const MeshModel& m, QS
 MeshLabPlugin::ActionIDType FilterPlugin::ID(const QAction* a) const
 {
 	QString aa=a->text();
-	for(ActionIDType tt : types())
+	for(ActionIDType tt : qAsConst(typeList))
 		if (a->text() == this->filterName(tt)) return tt;
 	aa.replace("&","");
-	for(ActionIDType tt : types())
+	for(ActionIDType tt : qAsConst(typeList))
 		if (aa == this->filterName(tt)) return tt;
 
 	qDebug("unable to find the id corresponding to action  '%s'", qUtf8Printable(a->text()));
@@ -68,10 +70,10 @@ QAction* FilterPlugin::getFilterAction(MeshLabPlugin::ActionIDType filterID)
 QAction* FilterPlugin::getFilterAction(const QString& idName)
 {
 	QString i=idName;
-	for(QAction *tt : actionList)
+	for(QAction *tt : qAsConst(actionList))
 		if (idName == tt->text()) return tt;
 	i.replace("&","");
-	for(QAction *tt : actionList)
+	for(QAction *tt : qAsConst(actionList))
 		if (i == tt->text()) return tt;
 
 	qDebug("unable to find the action corresponding to action  '%s'", qUtf8Printable(idName));

src/common/plugins/interfaces/meshlab_plugin.h

@@ -35,7 +35,7 @@
  * @brief The MeshLabPlugin class is the base of all the plugin classes.
  *
  * The main idea common to all the framework is that each plugin export a set 
- * of actions, internally each action is associated to a FilterIDType, and for 
+ * of actions, internally each action is associated to an ActionIDType, and for 
  * each action a name and a formatted INFO is defined.
  *
  * For coding easyness ID are more practical (you can use them in switches).
@@ -46,7 +46,8 @@
  * used only INTERNALLY
  *
  * Note: this class does NOT contain member functions that need to be 
- * implemented in base classes.
+ * implemented in base classes. It just provides some common functionalities
+ * like logs.
  */
 class MeshLabPlugin
 {

src/meshlabplugins/edit_align/edit_align.cpp

@@ -57,7 +57,7 @@ EditAlignPlugin::EditAlignPlugin()
     trackball.radius= 1;
 }
 
-const QString EditAlignPlugin::Info()
+const QString EditAlignPlugin::info()
 {
     return tr("Allows one to align different layers together.");
 }

src/meshlabplugins/edit_align/edit_align.h

@@ -51,7 +51,7 @@ public:
 	virtual ~EditAlignPlugin() {
 	}
 
-	static const QString Info();
+	static const QString info();
 
 	bool isSingleMeshEdit() const { return false; }
 	void suggestedRenderingData(MeshModel &m, MLRenderingData& dt);

src/meshlabplugins/edit_align/edit_align_factory.cpp

@@ -54,7 +54,7 @@ EditPlugin* EditAlignFactory::getMeshEditInterface(const QAction *action)
 
 QString EditAlignFactory::getEditToolDescription(const QAction *)
 {
-	return EditAlignPlugin::Info();
+	return EditAlignPlugin::info();
 }
 
 MESHLAB_PLUGIN_NAME_EXPORTER(EditAlignFactory)

src/meshlabplugins/edit_manipulators/edit_manipulators.cpp

@@ -46,7 +46,7 @@ EditManipulatorsPlugin::EditManipulatorsPlugin()
   delta_Transform = Matrix44m::Identity();
 }
 
-const QString EditManipulatorsPlugin::Info() 
+const QString EditManipulatorsPlugin::info() 
 {
     return tr("Provide tools for moving meshes around the space");
 }

src/meshlabplugins/edit_manipulators/edit_manipulators.h

@@ -42,7 +42,7 @@ public:
 
   EditManipulatorsPlugin();
   virtual ~EditManipulatorsPlugin() {}
-  static const QString Info();
+  static const QString info();
   virtual bool startEdit(MeshModel &/*m*/, GLArea * /*parent*/, MLSceneGLSharedDataContext* /*cont*/);
   virtual void endEdit(MeshModel &/*m*/, GLArea * /*parent*/, MLSceneGLSharedDataContext* /*cont*/);
   virtual void decorate(MeshModel &, GLArea *,QPainter*);

src/meshlabplugins/edit_manipulators/edit_manipulators_factory.cpp

@@ -57,7 +57,7 @@ EditPlugin* EditManipulatorsFactory::getMeshEditInterface(const QAction *action)
 
 QString EditManipulatorsFactory::getEditToolDescription(const QAction *)
 {
-	return EditManipulatorsPlugin::Info();
+	return EditManipulatorsPlugin::info();
 }
 
 MESHLAB_PLUGIN_NAME_EXPORTER(EditManipulatorsFactory)

src/meshlabplugins/edit_measure/edit_measure.cpp

@@ -40,7 +40,7 @@ EditMeasurePlugin::EditMeasurePlugin()
 	mName = 0;
 }
 
-const QString EditMeasurePlugin::Info()
+const QString EditMeasurePlugin::info()
 {
 	return tr("Allows one to measure distances between points of a model");
 }

src/meshlabplugins/edit_measure/edit_measure.h

@@ -56,7 +56,7 @@ class EditMeasurePlugin : public QObject, public EditPlugin
 public:
   EditMeasurePlugin();
   virtual ~EditMeasurePlugin() {}
-  static const QString Info();
+  static const QString info();
   virtual bool startEdit(MeshModel &/*m*/, GLArea * /*parent*/, MLSceneGLSharedDataContext* /*cont*/);
   virtual void endEdit(MeshModel &/*m*/, GLArea * /*parent*/, MLSceneGLSharedDataContext* /*cont*/);
   virtual void decorate(MeshModel &, GLArea *,QPainter*);

src/meshlabplugins/edit_measure/edit_measure_factory.cpp

@@ -57,7 +57,7 @@ EditPlugin* EditMeasureFactory::getMeshEditInterface(const QAction *action)
 
 QString EditMeasureFactory::getEditToolDescription(const QAction *)
 {
-	return EditMeasurePlugin::Info();
+	return EditMeasurePlugin::info();
 }
 
 MESHLAB_PLUGIN_NAME_EXPORTER(EditMeasureFactory)

src/meshlabplugins/edit_mutualcorrs/edit_mutualcorrs.cpp

@@ -58,7 +58,7 @@ EditMutualCorrsPlugin::EditMutualCorrsPlugin() {
 
     }
 
-const QString EditMutualCorrsPlugin::Info()
+const QString EditMutualCorrsPlugin::info()
 {
     return tr("Registration of images on 3D models using mutual correspondences");
 }

src/meshlabplugins/edit_mutualcorrs/edit_mutualcorrs.h

@@ -43,7 +43,7 @@ public:
     EditMutualCorrsPlugin();
     virtual ~EditMutualCorrsPlugin() {}
 
-    static const QString Info();
+    static const QString info();
 
     bool startEdit(MeshModel &/*m*/, GLArea * /*parent*/, MLSceneGLSharedDataContext* /*cont*/);
     void endEdit(MeshModel &/*m*/, GLArea * /*parent*/, MLSceneGLSharedDataContext* /*cont*/);

src/meshlabplugins/edit_mutualcorrs/edit_mutualcorrs_factory.cpp

@@ -57,7 +57,7 @@ EditPlugin* EditMutualCorrsFactory::getMeshEditInterface(const QAction *action)
 
 QString EditMutualCorrsFactory::getEditToolDescription(const QAction *)
 {
-    return EditMutualCorrsPlugin::Info();
+    return EditMutualCorrsPlugin::info();
 }
 
 MESHLAB_PLUGIN_NAME_EXPORTER(EditMutualCorrsFactory)

src/meshlabplugins/edit_paint/edit_paint.cpp

@@ -41,7 +41,7 @@ EditPaintPlugin::EditPaintPlugin()
 
 EditPaintPlugin::~EditPaintPlugin() {}
 
-const QString EditPaintPlugin::Info() {
+const QString EditPaintPlugin::info() {
 	return tr("Improved Painting");
 }
 

src/meshlabplugins/edit_paint/edit_paint.h

@@ -58,7 +58,7 @@ public:
 	EditPaintPlugin();
 	virtual ~EditPaintPlugin();
 
-	static const QString Info();
+	static const QString info();
 
 	void suggestedRenderingData(MeshModel &/*m*/, MLRenderingData& /*dt*/);
 	bool startEdit(MeshModel &/*m*/, GLArea * /*parent*/, MLSceneGLSharedDataContext* /*cont*/);

src/meshlabplugins/edit_paint/edit_paint_factory.cpp

@@ -57,7 +57,7 @@ EditPlugin* EditPaintFactory::getMeshEditInterface(const QAction *action)
 
 QString EditPaintFactory::getEditToolDescription(const QAction *)
 {
-	return EditPaintPlugin::Info();
+	return EditPaintPlugin::info();
 }
 
 MESHLAB_PLUGIN_NAME_EXPORTER(EditPaintFactory)

src/meshlabplugins/edit_pickpoints/edit_pickpoints_factory.cpp

@@ -58,7 +58,7 @@ EditPlugin* EditPickPointsFactory::getMeshEditInterface(const QAction *action)
 
 QString EditPickPointsFactory::getEditToolDescription(const QAction *)
 {
-	return EditPickPointsPlugin::Info();
+	return EditPickPointsPlugin::info();
 }
 
 MESHLAB_PLUGIN_NAME_EXPORTER(EditPickPointsFactory)

src/meshlabplugins/edit_pickpoints/editpickpoints.cpp

@@ -62,7 +62,7 @@ EditPickPointsPlugin::EditPickPointsPlugin()
 //Constants
 
 
-const QString EditPickPointsPlugin::Info()
+const QString EditPickPointsPlugin::info()
 {
 	return tr("Pick and save 3D points on the mesh");
 }

src/meshlabplugins/edit_pickpoints/editpickpoints.h

@@ -49,7 +49,7 @@ public:
 		delete pickPointsDialog;
 	}
 	
-	static const QString Info();
+	static const QString info();
 
 	virtual bool startEdit(MeshModel & mm, GLArea * gla, MLSceneGLSharedDataContext* /*cont*/);
 	virtual void endEdit(MeshModel & mm, GLArea * gla, MLSceneGLSharedDataContext* /*cont*/);

src/meshlabplugins/edit_point/edit_point.cpp

@@ -45,7 +45,7 @@ using namespace vcg;
 
 EditPointPlugin::EditPointPlugin(int _editType) : editType(_editType) {}
 
-const QString EditPointPlugin::Info() {
+const QString EditPointPlugin::info() {
     return tr("Select a region of the point cloud thought to be in the same connected component.");
 }
 

src/meshlabplugins/edit_point/edit_point.h

@@ -39,7 +39,7 @@ public:
     EditPointPlugin(int _editType);
     virtual ~EditPointPlugin() {}
 
-    static const QString Info();
+    static const QString info();
 
 	void suggestedRenderingData(MeshModel & m, MLRenderingData& dt);
     bool startEdit(MeshModel &/*m*/, GLArea * /*parent*/, MLSceneGLSharedDataContext* /*cont*/);

src/meshlabplugins/edit_point/edit_point_factory.cpp

@@ -61,7 +61,7 @@ EditPlugin* PointEditFactory::getMeshEditInterface(const QAction *action)
 
 QString PointEditFactory::getEditToolDescription(const QAction *)
 {
-        return EditPointPlugin::Info();
+        return EditPointPlugin::info();
 }
 
 MESHLAB_PLUGIN_NAME_EXPORTER(PointEditFactory)

src/meshlabplugins/edit_quality/edit_quality_factory.cpp

@@ -58,7 +58,7 @@ EditPlugin* QualityMapperFactory::getMeshEditInterface(const QAction *action)
 
 QString QualityMapperFactory::getEditToolDescription(const QAction *)
 {
-	return QualityMapperPlugin::Info();
+	return QualityMapperPlugin::info();
 }
 
 MESHLAB_PLUGIN_NAME_EXPORTER(QualityMapperFactory)

src/meshlabplugins/edit_quality/qualitymapper.cpp

@@ -42,7 +42,7 @@ QualityMapperPlugin::QualityMapperPlugin()
 	_qualityMapperDialog = 0;
 }
 
-const QString QualityMapperPlugin::Info() 
+const QString QualityMapperPlugin::info() 
 {
 	return tr("Colorize mesh vertices by Quality");
 }

src/meshlabplugins/edit_quality/qualitymapper.h

@@ -51,7 +51,7 @@ public:
 	QualityMapperPlugin(void);
 	~QualityMapperPlugin(void) {};
 
-	static const QString Info();
+	static const QString info();
 	bool startEdit(MeshModel&, GLArea*, MLSceneGLSharedDataContext* cont);
 	void endEdit(MeshModel&, GLArea*, MLSceneGLSharedDataContext* cont);
 	void suggestedRenderingData(MeshModel &/*m*/, MLRenderingData& /*dt*/);

src/meshlabplugins/edit_referencing/edit_referencing.cpp

@@ -73,7 +73,7 @@ EditReferencingPlugin::EditReferencingPlugin() {
     referencingResults.reserve(4096);
 }
 
-const QString EditReferencingPlugin::Info()
+const QString EditReferencingPlugin::info()
 {
     return tr("Reference layer(s) using fiducial points or scale layer(s) using reference distances.");
 }

src/meshlabplugins/edit_referencing/edit_referencing.h

@@ -45,7 +45,7 @@ public:
     EditReferencingPlugin();
     virtual ~EditReferencingPlugin() {}
 
-    static const QString Info();
+    static const QString info();
 
 	bool startEdit(MeshModel &/*m*/, GLArea * /*parent*/, MLSceneGLSharedDataContext* /*cont*/);
     void endEdit(MeshModel &/*m*/, GLArea * /*parent*/, MLSceneGLSharedDataContext* /*cont*/);

src/meshlabplugins/edit_referencing/edit_referencing_factory.cpp

@@ -57,7 +57,7 @@ EditPlugin* EditReferencingFactory::getMeshEditInterface(const QAction *action)
 
 QString EditReferencingFactory::getEditToolDescription(const QAction *)
 {
-    return EditReferencingPlugin::Info();
+    return EditReferencingPlugin::info();
 }
 
 MESHLAB_PLUGIN_NAME_EXPORTER(EditReferencingFactory)

src/meshlabplugins/edit_sample/edit_sample.cpp

@@ -48,7 +48,7 @@ SampleEditPlugin::SampleEditPlugin()
 	pIndex = 0;
 }
 
-const QString SampleEditPlugin::Info() 
+const QString SampleEditPlugin::info() 
 {
 	return tr("Return detailed info about a picked face or vertex of the model.");
 }

src/meshlabplugins/edit_sample/edit_sample.h

@@ -37,7 +37,7 @@ public:
     SampleEditPlugin();
     virtual ~SampleEditPlugin() {}
 
-    static const QString Info();
+    static const QString info();
 
     bool startEdit(MeshModel &/*m*/, GLArea * /*parent*/, MLSceneGLSharedDataContext* /*cont*/);
     void endEdit(MeshModel &/*m*/, GLArea * /*parent*/, MLSceneGLSharedDataContext* /*cont*/);

src/meshlabplugins/edit_sample/edit_sample_factory.cpp

@@ -57,7 +57,7 @@ EditPlugin* SampleEditFactory::getMeshEditInterface(const QAction *action)
 
 QString SampleEditFactory::getEditToolDescription(const QAction *)
 {
-	return SampleEditPlugin::Info();
+	return SampleEditPlugin::info();
 }
 
 MESHLAB_PLUGIN_NAME_EXPORTER(SampleEditFactory)

src/meshlabplugins/edit_select/edit_select.cpp

@@ -37,7 +37,7 @@ EditSelectPlugin::EditSelectPlugin(int ConnectedMode) :selectionMode(ConnectedMo
 	isDragging = false;
 }
 
-QString EditSelectPlugin::Info()
+QString EditSelectPlugin::info()
 {
 	return tr("Interactive selection inside a dragged rectangle in screen space");
 }

src/meshlabplugins/edit_select/edit_select.h

@@ -39,7 +39,7 @@ public:
 
 	virtual ~EditSelectPlugin() {}
 
-	static QString Info();
+	static QString info();
 	void suggestedRenderingData(MeshModel & m, MLRenderingData& dt);
 	bool startEdit(MeshModel &/*m*/, GLArea * /*parent*/, MLSceneGLSharedDataContext* /*cont*/);
 	void endEdit(MeshModel &/*m*/, GLArea * /*parent*/, MLSceneGLSharedDataContext* /*cont*/) {}

src/meshlabplugins/edit_select/edit_select_factory.cpp

@@ -69,7 +69,7 @@ EditPlugin* EditSelectFactory::getMeshEditInterface(const QAction *action)
 
 QString EditSelectFactory::getEditToolDescription(const QAction * /*a*/)
 {
-  return EditSelectPlugin::Info();
+  return EditSelectPlugin::info();
 }
 
 MESHLAB_PLUGIN_NAME_EXPORTER(EditSelectFactory)