lucaspalomodevelop/indico-plugins
1
0
Fork 0
mirror of https://github.com/lucaspalomodevelop/indico-plugins.git synced 2026-03-12 23:27:22 +00:00
Code Issues Packages Projects Releases Wiki Activity

Payment/Sixpay: Handle parallel confirmations nicely

Browse Source
This commit is contained in:
Adrian Moennich 2021-08-12 16:08:55 +02:00
parent d006b0ff6a
commit d583d5c6c8
1 changed files with 23 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

26
payment_sixpay/indico_payment_sixpay/controllers.py
View File

@ -5,6 +5,8 @@
# them and/or modify them under the terms of the MIT License;
# see the LICENSE file for more details.
import json
import time
from urllib.parse import urljoin
import requests
@ -161,15 +163,33 @@ class SixpayNotificationHandler(RHSixpayBase):
assert_response = self._assert_payment()
if self._is_duplicate_transaction(assert_response):
# we have already handled the transaction
return True
if self._is_authorized(assert_response) and not self._is_captured(assert_response):
return
elif self._is_captured(assert_response):
# We already captured the payment. This usually happens because sixpay
# calls a background notification endpoint but we also try to capture
# it after being redirected to the user-facing success endpoint
SixpayPaymentPlugin.logger.info('Not processing already-captured transaction')
time.sleep(1) # wait a bit to make sure the other request finished!
return
elif self._is_authorized(assert_response):
self._capture_transaction(assert_response)
self._verify_amount(assert_response)
self._register_payment(assert_response)
except TransactionFailure as exc:
if exc.step == 'capture':
try:
payload = json.loads(exc.details)
except (json.JSONDecodeError, TypeError):
payload = {}
if payload.get('ErrorName') == 'TRANSACTION_ALREADY_CAPTURED':
# Same as the self._is_captured(assert_response) case above, but a race
# between the two requests (user-facing and background) resulted in both
# asserts returning an 'authorized' state
SixpayPaymentPlugin.logger.info('Not processing already-captured transaction (parallel request)')
time.sleep(1) # wait a bit to make sure the other request finished
return
SixpayPaymentPlugin.logger.warning('SIXPay transaction failed during %s: %s', exc.step, exc.details)
raise
return True
def _perform_request(self, task, endpoint, data):
"""Perform a request against SIXPay.