From 88b8a188f67d6586ec8d0ac14235930178c6e6b4 Mon Sep 17 00:00:00 2001 From: Adrian Moennich Date: Thu, 7 Dec 2017 16:02:38 +0100 Subject: [PATCH] Piwik: Do not choke on malformed URLs --- piwik/indico_piwik/plugin.py | 4 +++- piwik/setup.py | 2 +- 2 files changed, 4 insertions(+), 2 deletions(-) diff --git a/piwik/indico_piwik/plugin.py b/piwik/indico_piwik/plugin.py index 485f2d4..223266d 100644 --- a/piwik/indico_piwik/plugin.py +++ b/piwik/indico_piwik/plugin.py @@ -111,9 +111,11 @@ class PiwikPlugin(IndicoPlugin): return {} params = {'site_id_events': site_id_events} if request.blueprint in ('event', 'events', 'contributions') and 'confId' in request.view_args: + if not unicode(request.view_args['confId']).isdigit(): + return {} params['event_id'] = request.view_args['confId'] contrib_id = request.view_args.get('contrib_id') - if contrib_id is not None: + if contrib_id is not None and unicode(contrib_id).isdigit(): contribution = Contribution.find_first(event_id=params['event_id'], id=contrib_id) if contribution: cid = (contribution.legacy_mapping.legacy_contribution_id if contribution.legacy_mapping diff --git a/piwik/setup.py b/piwik/setup.py index 7e88d02..ddb30c0 100644 --- a/piwik/setup.py +++ b/piwik/setup.py @@ -21,7 +21,7 @@ from setuptools import find_packages, setup setup( name='indico-plugin-piwik', - version='1.0rc1', + version='1.0rc2', description='Piwik integration for global and event-specific statistics in Indico', url='https://github.com/indico/indico-plugins', license='https://www.gnu.org/licenses/gpl-3.0.txt',