mirror of
https://github.com/lucaspalomodevelop/core.git
synced 2026-03-19 11:04:42 +00:00
e738e3ca05
It doesn't really seem to make sense to try to link groups on different places, if they're only usable for pf which is always reloaded when new interfaces are connected. The new ifgroup_setup() synchonizes attached interfaces for all configured groups, only rename and delete are still being served from the management pages (to avoid dropping static groups like openvpn).
222 lines
9.4 KiB
PHP
222 lines
9.4 KiB
PHP
<?php
|
|
|
|
/*
|
|
* Copyright (C) 2014-2015 Deciso B.V.
|
|
* Copyright (C) 2009 Ermal Luçi
|
|
* Copyright (C) 2004 Scott Ullrich <sullrich@gmail.com>
|
|
* All rights reserved.
|
|
*
|
|
* Redistribution and use in source and binary forms, with or without
|
|
* modification, are permitted provided that the following conditions are met:
|
|
*
|
|
* 1. Redistributions of source code must retain the above copyright notice,
|
|
* this list of conditions and the following disclaimer.
|
|
*
|
|
* 2. Redistributions in binary form must reproduce the above copyright
|
|
* notice, this list of conditions and the following disclaimer in the
|
|
* documentation and/or other materials provided with the distribution.
|
|
*
|
|
* THIS SOFTWARE IS PROVIDED ``AS IS'' AND ANY EXPRESS OR IMPLIED WARRANTIES,
|
|
* INCLUDING, BUT NOT LIMITED TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY
|
|
* AND FITNESS FOR A PARTICULAR PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL THE
|
|
* AUTHOR BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY,
|
|
* OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF
|
|
* SUBSTITUTE GOODS OR SERVICES; LOSS OF USE, DATA, OR PROFITS; OR BUSINESS
|
|
* INTERRUPTION) HOWEVER CAUSED AND ON ANY THEORY OF LIABILITY, WHETHER IN
|
|
* CONTRACT, STRICT LIABILITY, OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE)
|
|
* ARISING IN ANY WAY OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE
|
|
* POSSIBILITY OF SUCH DAMAGE.
|
|
*/
|
|
|
|
require_once("guiconfig.inc");
|
|
require_once("interfaces.inc");
|
|
require_once("filter.inc");
|
|
|
|
$a_ifgroups = &config_read_array('ifgroups', 'ifgroupentry');
|
|
|
|
if ($_SERVER['REQUEST_METHOD'] === 'GET') {
|
|
// read form data
|
|
if (!empty($a_ifgroups[$_GET['id']])) {
|
|
$id = $_GET['id'];
|
|
}
|
|
$pconfig = array();
|
|
$pconfig['ifname'] = isset($a_ifgroups[$id]['ifname']) ? $a_ifgroups[$id]['ifname'] : null;
|
|
$pconfig['descr'] = isset($a_ifgroups[$id]['descr']) ? $a_ifgroups[$id]['descr'] : null;
|
|
$pconfig['members'] = isset($a_ifgroups[$id]['members']) ? explode(' ', $a_ifgroups[$id]['members']) : array();
|
|
} elseif ($_SERVER['REQUEST_METHOD'] === 'POST') {
|
|
// validate and save form data
|
|
if (!empty($a_ifgroups[$_POST['id']])) {
|
|
$id = $_POST['id'];
|
|
}
|
|
$input_errors = array();
|
|
$pconfig = $_POST;
|
|
|
|
if (!isset($id)) {
|
|
foreach ($a_ifgroups as $groupentry) {
|
|
if ($groupentry['ifname'] == $pconfig['ifname']) {
|
|
$input_errors[] = gettext("Group name already exists!");
|
|
}
|
|
}
|
|
}
|
|
|
|
if (empty($pconfig['ifname']) || preg_match('/[^a-zA-Z0-9_]+/', $pconfig['ifname'], $match)) {
|
|
$input_errors[] = gettext('Only letters, digits and underscores are allowed as the group name.');
|
|
}
|
|
|
|
if (!empty($pconfig['ifname'])) {
|
|
if (strlen($pconfig['ifname']) > 15) {
|
|
$input_errors[] = gettext('The group name shall not be longer than 15 characters.');
|
|
}
|
|
|
|
if (preg_match('/[0-9]$/', $pconfig['ifname'], $match)) {
|
|
$input_errors[] = gettext('The group name shall not end in a digit.');
|
|
}
|
|
}
|
|
|
|
foreach (get_configured_interface_with_descr() as $gif => $gdescr) {
|
|
if ($gdescr == $pconfig['ifname'] || $gif == $pconfig['ifname']) {
|
|
$input_errors[] = gettext("The specified group name is already used by an interface. Please choose another name.");
|
|
}
|
|
}
|
|
|
|
if (empty($pconfig['members'])) {
|
|
$input_errors[] = gettext("At least one group member must be specified.");
|
|
$pconfig['members'] = array();
|
|
}
|
|
|
|
if (count($input_errors) == 0) {
|
|
$ifgroupentry = array();
|
|
$ifgroupentry['members'] = implode(' ', $pconfig['members']);
|
|
$ifgroupentry['descr'] = $pconfig['descr'];
|
|
$ifgroupentry['ifname'] = $pconfig['ifname'];
|
|
|
|
if (isset($id)) {
|
|
// rename interface group
|
|
if ($pconfig['ifname'] != $a_ifgroups[$id]['ifname']) {
|
|
if (!empty($config['filter']) && is_array($config['filter']['rule'])) {
|
|
foreach ($config['filter']['rule'] as &$rule) {
|
|
$rule_ifs = explode(",", $rule['interface']);
|
|
if (in_array($a_ifgroups[$id]['ifname'], $rule_ifs)) {
|
|
// replace interface
|
|
$rule_ifs[array_search($a_ifgroups[$id]['ifname'], $rule_ifs)] = $ifgroupentry['ifname'];
|
|
$rule['interface'] = implode(",", $rule_ifs);
|
|
}
|
|
}
|
|
}
|
|
if (!empty($config['nat']) && is_array($config['nat']['rule'])) {
|
|
foreach ($config['nat']['rule'] as &$rule) {
|
|
$rule_ifs = explode(",", $rule['interface']);
|
|
if (in_array($a_ifgroups[$id]['ifname'], $rule_ifs)) {
|
|
// replace interface
|
|
$rule_ifs[array_search($a_ifgroups[$id]['ifname'], $rule_ifs)] = $ifgroupentry['ifname'];
|
|
$rule['interface'] = implode(",", $rule_ifs);
|
|
}
|
|
}
|
|
}
|
|
}
|
|
// update item
|
|
$a_ifgroups[$id] = $ifgroupentry;
|
|
} else {
|
|
// add new item
|
|
$a_ifgroups[] = $ifgroupentry;
|
|
}
|
|
mark_subsystem_dirty('filter');
|
|
usort($a_ifgroups, function($a, $b) {
|
|
return strnatcmp($a['ifname'], $b['ifname']);
|
|
});
|
|
filter_rules_sort();
|
|
write_config();
|
|
header(url_safe('Location: /interfaces_groups.php'));
|
|
exit;
|
|
}
|
|
}
|
|
|
|
|
|
include("head.inc");
|
|
legacy_html_escape_form_data($pconfig);
|
|
?>
|
|
|
|
<body>
|
|
<?php include("fbegin.inc"); ?>
|
|
|
|
<section class="page-content-main">
|
|
<div class="container-fluid">
|
|
<div class="row">
|
|
<?php if (isset($input_errors) && count($input_errors) > 0) print_input_errors($input_errors); ?>
|
|
<section class="col-xs-12">
|
|
<div class="content-box">
|
|
<div class="table-responsive">
|
|
<form method="post" name="iform" id="iform">
|
|
<table class="table table-striped opnsense_standard_table_form">
|
|
<thead>
|
|
<tr>
|
|
<td style="width:22%"><strong><?=gettext("Interface Groups Edit");?></strong></td>
|
|
<td style="width:78%; text-align:right">
|
|
<small><?=gettext("full help"); ?> </small>
|
|
<i class="fa fa-toggle-off text-danger" style="cursor: pointer;" id="show_all_help_page"></i>
|
|
|
|
</td>
|
|
</tr>
|
|
</thead>
|
|
<tbody>
|
|
<tr>
|
|
<td><a id="help_for_ifname" href="#" class="showhelp"><i class="fa fa-info-circle"></i></a> <?= gettext('Name') ?></td>
|
|
<td>
|
|
<input type="text" name="ifname" value="<?=$pconfig['ifname'];?>" />
|
|
<div class="hidden" data-for="help_for_ifname">
|
|
<?=gettext("No numbers or spaces are allowed. Only characters in a-zA-Z");?>
|
|
</div>
|
|
</td>
|
|
</tr>
|
|
<tr>
|
|
<td><a id="help_for_descr" href="#" class="showhelp"><i class="fa fa-info-circle"></i></a> <?=gettext("Description"); ?></td>
|
|
<td>
|
|
<input name="descr" type="text" value="<?=$pconfig['descr'];?>" />
|
|
<div class="hidden" data-for="help_for_descr">
|
|
<?= gettext('You may enter a description here for your reference.') ?>
|
|
</div>
|
|
</td>
|
|
</tr>
|
|
<tr>
|
|
<td><a id="help_for_members" href="#" class="showhelp"><i class="fa fa-info-circle"></i></a> <?= gettext('Members') ?></td>
|
|
<td>
|
|
<select name="members[]" multiple="multiple" class="selectpicker" data-size="5" data-live-search="true">
|
|
<?php
|
|
foreach (legacy_config_get_interfaces() as $ifn => $ifdetail):
|
|
if (!empty($ifdetail['type']) && $ifdetail['type'] == 'group') {
|
|
continue;
|
|
}
|
|
?>
|
|
<option value="<?=$ifn;?>" <?=in_array($ifn, $pconfig['members']) ? "selected=\"selected\"" : "";?>>
|
|
<?= htmlspecialchars($ifdetail['descr']) ?>
|
|
</option>
|
|
<?php
|
|
endforeach;?>
|
|
</select>
|
|
<div class="hidden" data-for="help_for_members">
|
|
<?= gettext('Rules for WAN type interfaces in groups do not contain the reply-to mechanism upon which Multi-WAN typically relies.') ?>
|
|
</div>
|
|
</td>
|
|
</tr>
|
|
<tr>
|
|
<td> </td>
|
|
<td>
|
|
<input name="submit" type="submit" class="btn btn-primary" value="<?=html_safe(gettext('Save'));?>" />
|
|
<input type="button" class="btn btn-default" value="<?=html_safe(gettext('Cancel'));?>" onclick="window.location.href='/interfaces_groups.php'" />
|
|
<?php if (isset($id)): ?>
|
|
<input name="id" type="hidden" value="<?=$id;?>" />
|
|
<?php endif; ?>
|
|
</td>
|
|
</tr>
|
|
</tbody>
|
|
</table>
|
|
</form>
|
|
</div>
|
|
</div>
|
|
</section>
|
|
</div>
|
|
</div>
|
|
</section>
|
|
<?php
|
|
include("foot.inc");
|