233 Commits

Author SHA1 Message Date
Robin Schneider
fcb6eaa9de Use HTTPS everywhere (mechanical edit using util from https-everywhere) (#4534) 2021-03-14 12:44:43 +01:00
Franco Fichtner
7fda1670ce interfaces: l2tp/pptp cleanup; closes #2707
The interfaces are created by mpd5 daemon during configuration.
We do not seem to have more than one issue here: IPv6 disable
is too soon but that is easily fixed.  Device creation moves
on ok and there is no apparent error in functionality with or
without it.

While here fix the link when a $pppid is set and properly protect
the redirect url.  Previously empty() was too strict and it ignored
$pppid of zero.

Also remove spurious "IP Address" help text from PPP device
configuration.
2021-01-03 20:45:58 +01:00
Ad Schellevis
d70a1aae03 interfaces: when interface mss is set, split mss calculation into a variant for IPv4 and one for IPV6. fixes incorrect header size for IPv6 (60 instead of 40 bytes). closes https://github.com/opnsense/core/issues/4484 2020-11-27 18:46:44 +01:00
Ad Schellevis
5f108f698e interfaces: change max mtu value to 65535 in accordance with rfc791 (https://tools.ietf.org/html/rfc791). closes https://github.com/opnsense/core/issues/4359 2020-09-29 09:33:22 +02:00
Franco Fichtner
58e3c45655 interfaces: drop unfinished RFC 3118 support 2020-07-21 13:52:49 +02:00
Franco Fichtner
e1365b50ea interfaces: fix a typo 2020-05-24 10:48:09 +02:00
Franco Fichtner
fbe5a1909e interfaces: small changes, remove soon to be reinvented flags from GUI 2020-05-06 10:17:52 +02:00
Ad Schellevis
8bfd62c876 interfaces: typo in validation, failed to communicate unassignable targets. closes https://github.com/opnsense/core/issues/4050 2020-04-21 11:09:19 +02:00
Franco Fichtner
e9eb81a87f menu: change as discussed in 7749c098381
PR: https://github.com/opnsense/core/issues/4016
2020-04-20 08:57:43 +02:00
Ad Schellevis
7749c09838 Interfaces: obey group after POST, the menu can't find the item if the group isn't supplied when using groups. 2020-04-18 14:57:36 +02:00
Ad Schellevis
dba70c0ead Gateways: support interface targets (without addresses), but don't pinpoint it on specific drivers. for https://github.com/opnsense/core/pull/3983
Some tunnel interface types, such as Wireguard and Tinc do support sending traffic to the interface without an intermediate host. Since we don't want to add different static checks (and would like to get rid of the ones there for legacy reasons), it's probably better to add an option here.
2020-03-18 11:16:41 +01:00
Ad Schellevis
2a80d1a8a2 interfaces: make sure descriptions are properly cleansed, save description when disabled too (missed in https://github.com/opnsense/core/pull/3808) closes https://github.com/opnsense/core/issues/3942 2020-02-17 20:33:19 +01:00
Ad Schellevis
65b80e6a55 interfaces., missing break. closes https://github.com/opnsense/core/issues/3922 2020-02-11 17:20:15 +01:00
Franco Fichtner
29b6820117 interfaces: missed review opportunities 2020-02-05 09:07:12 +01:00
Len White
13f8ba2347 - Update maximum MTU for 10Gb NICs 2020-02-04 12:52:51 +01:00
Ad Schellevis
ee542d2822
add support for additional loopbacks (https://github.com/opnsense/core/issues/3832) (#3840)
Add *Interfaces: Other Types: Loopback*.

-  while here, also add the device name in interfaces.php and support setting an initial description on new interfaces (copy device description if available)

- check usages of lo0 and change to lo if not specific for our default loopback
2019-12-05 13:19:43 +01:00
Ad Schellevis
36372b939b interfaces: move description into top block and rename titles like suggested by @fichtner closes https://github.com/opnsense/core/pull/3808 2019-11-21 13:43:40 +01:00
Franco Fichtner
b97789b2d9 plugins: extend reach to "configurable" reject spots 2019-11-01 15:31:49 +01:00
Franco Fichtner
48e0c47a96 interfaces: remove the "Directly send SOLICIT" option
We already do a more-or-less hybrid approach by starting rtsold
even if it isn't used at all.  Now we also have ISPs which do
not seem to send router advertisements after successful connect
so that the reconnect misses the HUP for dhcp6c to fix the
connectivity again.

To change that remove the option and its only conditional to
behave unconditionally which has few reasons to cause regressions.
2019-10-31 09:14:35 +01:00
Ad Schellevis
2982424232 interfaces, only trigger newwanip event for affected interfaces 2019-08-30 15:09:06 +02:00
Franco Fichtner
e40b8f51ac interfaces: lock IP configuration type for tunnels
@Adschellvis and me wondered about this so I did a bit of
reseach and multiple workaround oddities exist to fix parts
of the issue.  To be frank, fix the issue at the source and
do not let users otherwise configure these settings in tunnel
interfaces.

See:      https://redmine.pfsense.org/issues/3280
Also see: https://redmine.pfsense.org/issues/8687
2019-04-26 07:42:54 +02:00
Franco Fichtner
3498416734 interfaces: in a perfect world these do not need services.inc
Let's make it so.  :)
2019-04-25 09:37:34 +02:00
Franco Fichtner
715ad3f253 interfaces: check prefix ID for duplicates #3406 2019-04-22 12:57:45 +02:00
Franco Fichtner
8bb992cfe7 interfaces: this is really hard ;) 2019-04-22 08:18:59 +02:00
Franco Fichtner
6fb54a1c11 interfaces: different approach 2019-04-22 08:12:44 +02:00
Franco Fichtner
d19d37e1bd interfaces: not my day 2019-04-21 20:30:24 +02:00
Franco Fichtner
82ab898a5a interfaces: changes to previous 2019-04-21 20:04:32 +02:00
Franco Fichtner
542368628b interfaces: make hexadecimal notation obvious; closes #3405 2019-04-21 19:59:17 +02:00
Franco Fichtner
f3b5c0e8f7 system: hide dpinger configuration inside new plugins_configure() call
Some back and forth between explicit and implicit requires while here.
The code is helplessly glued together and no plugin facility to get
data from a function call currently exists.
2019-04-21 19:04:15 +02:00
Ad Schellevis
96eb3f6f03 filter, move code to highlight (point) selected option from system_advanced_firewall.php to generic javascript legacy function and enable support on interfaces.php page as well, including a fix to firewall_rule_lookup.php for supporting ?if=<interface> lookups
for https://github.com/opnsense/core/issues/3312
2019-03-15 14:38:43 +01:00
Franco Fichtner
ae7af5314b interfaces: change apply flow a bit, comment was misleading 2019-02-06 15:59:42 +01:00
Ad Schellevis
4a8e737ced fix some gettext() + html_safe, discussed c4c7f8d732 2019-02-03 20:04:08 +01:00
Martin Wasley
28796e83a6 interfaces: DHCP Override MTU Option
It seems DHCP in 11.2 is honouring the ISPs MTU if it is sent. It
also seems there are some ISPs who send a stupid value. This fix
allows the user to ignore the ISP-supplied MTU (or not) with the
default set to ignore for compatibility with the previous behaviour.

PR: https://github.com/opnsense/core/issues/3173
2019-02-03 15:49:28 +01:00
Johannes Kastl
9f290d11f6 fix typo 'muti-WAN interface' (#3127) 2019-01-13 12:54:33 +00:00
Michael Steenbeek
97645093c3 Fix missing semicolons 2019-01-11 16:44:23 +01:00
Michael Steenbeek
69cc3895e6 Fix some JS errors 2019-01-04 08:39:22 +01:00
Michael Steenbeek
d27cc83642 Change foreach loops that don't use values to use array_keys() 2018-12-18 14:37:11 +01:00
Michael Steenbeek
28aa54f03f Fix br tags 2018-12-05 08:15:14 +01:00
Michael Steenbeek
6db6598c00 Fix more incorrect HTML tags (#3007) 2018-12-04 10:13:22 +01:00
Michael Steenbeek
88c28e3258 Fix typos and mismatched HTML tags (#2998) 2018-12-03 13:19:11 +01:00
Michael Steenbeek
71774ab376 Fix implicit Javascript global variable assignments (#2945) 2018-12-03 13:17:02 +01:00
Michael Steenbeek
afcae6226a Clean up incorrect/unused variable assignments 2018-11-29 17:29:58 +01:00
Franco Fichtner
c28fb86f37 interfaces: add note about CGN addresses included in private range; closes #2880 2018-11-24 14:15:41 +01:00
Michael Steenbeek
552fed10d7 Fix HTML errors (#2943) 2018-11-23 10:38:39 +01:00
Michael Steenbeek
5d49c6afcd PHP: Fix lots of refs to undefined vars (#2952) 2018-11-22 09:22:57 +01:00
Michael Steenbeek
77d628fc4e Clean up array usage in interfaces.php 2018-11-12 13:30:51 +01:00
Franco Fichtner
9d9251fd20 interfaces: stop modifying tracking ifs as fe80::1:1
This is an experiement.
2018-10-31 12:33:43 +01:00
Franco Fichtner
eada2bf5a1 interfaces: override link-local tracking router address if needed
PR: https://forum.opnsense.org/index.php?topic=10034.0
2018-10-24 09:23:13 +00:00
marjohn56
cceb1bcd8c Add FTI/ to password - tidy end of useridhex 2018-10-05 09:49:31 +02:00
marjohn56
bb5144ed88 Correct missing '"'' at the end of the userclass field 2018-10-04 09:44:17 +02:00