9777 Commits

Author SHA1 Message Date
Franco Fichtner
ee98c7b13a firewall: uppercase translation 2019-03-18 08:24:07 +01:00
Franco Fichtner
bc29f3709a firewall: reformat header 2019-03-18 08:20:43 +01:00
Franco Fichtner
29a2ca8f44 mvc: style updates in mutable model controller 2019-03-18 08:10:18 +01:00
Franco Fichtner
f2816f35ae interfaces: we dedup later on... 2019-03-18 07:47:10 +01:00
Franco Fichtner
807ff055cb firewall: tweak inspect button behaviour and table layout a bit 2019-03-18 07:46:05 +01:00
Franco Fichtner
e1ec8980e4 importer: allow builtin password reset for new installer 2019-03-17 19:23:09 +01:00
Ad Schellevis
ee30b0771c Bootgrid plugin, before adding new code, do some drastic cleanups to simplify logic.
Funcitonally this is backwards compatible with the previous version, but has a beter seperation between actions/events.
2019-03-17 18:40:54 +01:00
Ad Schellevis
cb8b83f56b Firewall, alias. proper locking before config action on delete 2019-03-17 18:35:00 +01:00
Franco Fichtner
7b937e878d firmware: we use grep, catch both versions of the error 2019-03-17 10:25:09 +01:00
Ad Schellevis
32c305c4ba Cron, people seem to forget that changes need to be applied before being active. closes https://github.com/opnsense/core/issues/2101 2019-03-16 19:47:09 +01:00
Franco Fichtner
4a46f7a09f src: style sweep 2019-03-16 15:15:24 +01:00
Franco Fichtner
429efafd8c interfaces: dedup interfaces while here 2019-03-16 14:44:56 +01:00
Franco Fichtner
a74ae3ab4f interfaces: take all unknown arguments as real interfaces; closes #3342 2019-03-16 14:30:53 +01:00
Franco Fichtner
d017fe2d4b system: properly initialise $filter array 2019-03-16 14:02:12 +01:00
Indrajit Raychaudhuri
f9d5f415e4 certmanager: Avoid double encoding cert name (#3340) 2019-03-16 09:37:24 +01:00
Ad Schellevis
a0f55d4529 filter: rule statistics using labels, missing aggregation in live view, for https://github.com/opnsense/core/issues/3312 2019-03-15 19:02:21 +01:00
Indrajit Raychaudhuri
6f76b5f4df Auth/LDAP: More reliable load and syncup for LDAP attributes (#3333) 2019-03-15 16:00:38 +01:00
Ad Schellevis
63141c019b filter, describe and reference "all the things" for https://github.com/opnsense/core/issues/3312 2019-03-15 15:46:49 +01:00
Ad Schellevis
6225cdfac4 filter, "highlight option" support on dhcp, ipsec for https://github.com/opnsense/core/issues/3312 2019-03-15 15:44:48 +01:00
Ad Schellevis
96eb3f6f03 filter, move code to highlight (point) selected option from system_advanced_firewall.php to generic javascript legacy function and enable support on interfaces.php page as well, including a fix to firewall_rule_lookup.php for supporting ?if=<interface> lookups
for https://github.com/opnsense/core/issues/3312
2019-03-15 14:38:43 +01:00
Frank Brendel
9746ebf8f1 Monit, remove __items and fix migration issue (#3336) 2019-03-15 11:42:43 +01:00
Ad Schellevis
33d687ae0b filter, wrong ref in auto lockout, for https://github.com/opnsense/core/issues/3312 2019-03-15 09:43:34 +01:00
Ad Schellevis
883063c49c get_std_save_message() with hasync enabled mangles some redirected save messages, although we do want to ditch the function at some point, we probably better fix the issue introduced with https://github.com/opnsense/core/issues/3165 first. 2019-03-14 20:13:15 +01:00
Ad Schellevis
6452a8b321 filter: link rule hash to origin, related to https://github.com/opnsense/core/issues/3312
Now we know where rules come from, we could use our live log to link to the place of origin.

This commit adds a couple of things:

- Extend plug to generate a rule hash for automatically generated (plugin) rules
- Support rule iteration in the rule framework, for easy access of registered rules
- Support #ref tag to point to place of origin (endpoint + field where option is set)
- Adds some examples in existing filter plugin code (more to add later)
- Adds a link to rid fields in livelog, which opens a new window with the original rule or setting.
2019-03-14 18:41:51 +01:00
Ad Schellevis
cfa308aad0 minor scroll fix for https://github.com/opnsense/core/issues/3312 2019-03-14 17:35:18 +01:00
Ad Schellevis
92b8b346f9 Filter, advanced settings, point user to an option on the page. for https://github.com/opnsense/core/issues/3312 2019-03-14 16:07:13 +01:00
Ad Schellevis
4eab7e10ac Routes, minor controller cleanups 2019-03-14 14:05:36 +01:00
Ad Schellevis
e4e3f98c20 Captive Portal administration, cleanup settings controller and use ApiMutableModelControllerBase 2019-03-14 13:55:11 +01:00
Ad Schellevis
482ff919ce Cron, minor controller cleanups 2019-03-14 13:44:15 +01:00
Ad Schellevis
1c2f7e1374 IDS, cleanups, align config save operations 2019-03-14 13:18:20 +01:00
Ad Schellevis
253d50f74b Traffic shaper, ditch unused, forgot in previous commit 2019-03-14 13:01:04 +01:00
Ad Schellevis
93f58604a6 Trafficshaper, align ApiMutableModelControllerBase usage 2019-03-14 12:58:12 +01:00
Ad Schellevis
28c69fd7cd MVC, controller, support overlays to set/addBase 2019-03-14 12:01:42 +01:00
Franco Fichtner
2b75bbac60 firewall: translate "if" as conditional
PR: https://forum.opnsense.org/index.php?topic=12029.0
2019-03-14 11:35:41 +01:00
Ad Schellevis
8a16b40db8 warn user about future deprication of "user-config-readonly" 2019-03-14 11:31:12 +01:00
Ad Schellevis
ff62a80bcd Proxy, cleanup, use base methods for remote blacklists. 2019-03-14 11:22:16 +01:00
Ad Schellevis
ff4de67bb2 Firewall, source nat, destination network presentation, closes https://github.com/opnsense/core/issues/3321 2019-03-14 10:16:12 +01:00
Ad Schellevis
3af02197b8 MVC, obey 'user-config-readonly' for subclasses of ApiMutableModelControllerBase.
Eventually (19.7?), user-config-readonly should go to the features of past times, it has has quite some downsides and will keep haunting everybody as long as it's there.

This patch makes sure ApiMutableModelControllerBase->save() adds an additional ACL check before doing the actual save, raising a user exception when not allowed.
Not all our classes use this, but can probably do so, same counts for plugins. We are not, under any circumstances, are going to move an acl check to the Config or model classes, since these have no relationship with the user.
2019-03-14 10:02:49 +01:00
Ad Schellevis
64c4d89b9d firewall, source nat, typo in destination address, closes https://github.com/opnsense/core/issues/3321 2019-03-14 09:30:19 +01:00
Franco Fichtner
5fe65f26ca src: whitespace sweep 2019-03-14 09:09:45 +01:00
Franco Fichtner
cf721cf4b1 ipsec: only apply mobile PFS to mobile phase 2; closes #3323 2019-03-14 08:11:01 +01:00
Ad Schellevis
5f79544e59 IPsec Mobile Client: Split DNS, INTERNAL_DNS_DOMAIN, closes https://github.com/opnsense/core/issues/3325 2019-03-13 21:35:15 +01:00
Franco Fichtner
33496e9fe3 firmware: fix parsing of packages in multi-repo env
PR: https://forum.opnsense.org/index.php?topic=12016.0
2019-03-13 21:04:45 +01:00
Ad Schellevis
2f6c3b79dd firewall, per rule statistics. add inspect button, for https://github.com/opnsense/core/issues/3312 2019-03-13 18:59:14 +01:00
Ad Schellevis
531c905572 filter, minor regression in eeae084150 , for https://github.com/opnsense/core/issues/3312 2019-03-13 17:24:28 +01:00
Ad Schellevis
24c5c6778c OpenVPN client export, "Custom config" not being loaded properly. 2019-03-13 15:52:19 +01:00
Ad Schellevis
314a7e2dfc fix previous (python3) https://github.com/opnsense/core/issues/3312 2019-03-13 15:31:48 +01:00
Ad Schellevis
0aef984586 filter: rule statistics, add "configctl filter rule stats" for https://github.com/opnsense/core/issues/3312 2019-03-13 15:28:36 +01:00
Ad Schellevis
c6f8c46709 interfaces, raw config access, leading to PHP Warning: Illegal string offset 'if', see https://github.com/opnsense/core/issues/3231 2019-03-13 10:11:21 +01:00
Ad Schellevis
9d3002cabb Auth/LDAP: Fallback to 'commonName' if 'name' isn't available for full name , closes https://github.com/opnsense/core/pull/3322 2019-03-13 09:05:52 +01:00