23 Commits

Author SHA1 Message Date
Ad Schellevis
3d07a9eb77 minor cleanups, closes https://github.com/opnsense/core/pull/3112 2019-03-01 14:55:36 +01:00
Franco Fichtner
0b879022ae www: d+f for #3218 2019-02-14 12:31:48 +01:00
Ad Schellevis
4a8e737ced fix some gettext() + html_safe, discussed c4c7f8d732 2019-02-03 20:04:08 +01:00
Michael Steenbeek
98247373d0 Remove nonexistant CSS properties
The table attributes 'cellspacing' and 'cellpadding' were moved inside the style attribute via a script. However, they are not valid CSS properties, so browsers should (and do) ignore them.
This commit removes them. The 'table' class, set on most tables, should take care of proper formatting anyway.
2018-12-03 12:01:41 +01:00
Franco Fichtner
a095c72857 firewall: avoid translating "by", remove excessive markup 2018-11-22 09:04:15 +01:00
Franco Fichtner
e5cb29c344 firewall: previous broke page actually 2018-11-21 11:45:34 +01:00
Michael Steenbeek
7f09e04d81 Fix some HTML errors 2018-11-21 11:42:01 +01:00
Franco Fichtner
e9c3be35d6 www: visual cleanups, unused class/style zapping #2290 2018-03-25 13:10:27 +00:00
NOYB
9d96bdcbc7 Help For - Data For Attribute
Use original element (<div>/<small>) with "data-for" attribute.

The old jquery "for" attribute selectors can be removed once conversion to "data-for" attribute is complete (including plugins).

The old jquery selectors to remove once conversion is complete.
  opnsense_ui.js & head.inc
  $("*[for='" + $(this).attr('id') + "']")....
  $('[for*="help_for"]')....
2018-03-17 16:12:55 +01:00
NOYB
6ef9a127ff HTML Compliance - Attribute "type" on Element <script>
Warning: The type attribute is unnecessary for JavaScript resources.

HTML5: Edition for Web Authors
http://www.w3.org/TR/2014/REC-html5-20141028/scripting-1.html
The default, which is used if the attribute is absent, is "text/javascript".

The Script element
https://developer.mozilla.org/en-US/docs/Web/HTML/Element/script
HTML5 specification urges authors to omit the attribute rather than provide a redundant MIME type.
2018-01-22 19:13:34 +01:00
NOYB
4a7bcae7af HTML Compliance - Attribute "for" on Element <div>
Error: Attribute "for" not allowed on element "div" at this point.
Attributes for element "div": http://www.w3.org/html/wg/drafts/html/master/single-page.html#the-div-element

HTML attribute reference: https://developer.mozilla.org/en-US/docs/Web/HTML/Attributes
The "Output" element: https://developer.mozilla.org/en-US/docs/Web/HTML/Element/output

Attributes for element "output": http://www.w3.org/html/wg/drafts/html/master/single-page.html#the-output-element
2018-01-06 10:52:17 +01:00
NOYB
b2f4cfa7c1 HTML Compliance - Attribute "type" on Element <i>
Error: Attribute "type" not allowed on element <i> at this point.
2018-01-05 08:36:26 +01:00
NOYB
76aab5cb52 HTML Compliance - Obsolete table attributes
width, align, valign, cellpadding, cellspacing, border, summary

Error: The width attribute on the table element is obsolete. Use CSS instead.
Error: The align attribute on the table element is obsolete. Use CSS instead.
Error: The valign attribute on the table element is obsolete. Use CSS instead.
Error: The cellpadding attribute on the table element is obsolete. Use CSS instead.
Error: The cellspacing attribute on the table element is obsolete. Use CSS instead.
Error: The border attribute on the table element is obsolete. Use CSS instead.
Error: The summary attribute on the table element is obsolete. Consider describing the structure of the table in a caption element or in a figure element containing the table; or, simplify the structure of the table so that no description is needed.
2018-01-04 18:26:02 +01:00
Franco Fichtner
5ce9933f2b firewall: fix scrub edit cancel link 2017-11-21 05:24:55 +00:00
Ad Schellevis
69510a5fad legacy ui pages cleanup for https://github.com/opnsense/core/issues/1733 2017-07-22 15:01:26 +02:00
Franco Fichtner
9d239330db firewall: tweak previous, manual wasn't clear #1623 2017-05-07 19:26:17 +02:00
Franco Fichtner
f082310e39 firewall: add tos/dscp values; closes #1623 2017-05-07 12:32:25 +02:00
Franco Fichtner
4344115cf3 Revert "firewall scrupt, 0x0 is not a valid value, https://github.com/opnsense/core/issues/1623"
This reverts commit 2fa53c9e8541326bba8cb2f9b452d0ed210706ef.

This needs fixing in the kernel instead :)
2017-05-06 20:19:08 +02:00
Ad Schellevis
2fa53c9e85 firewall scrupt, 0x0 is not a valid value, https://github.com/opnsense/core/issues/1623 2017-05-06 10:02:34 +02:00
Ad Schellevis
52b95b80c0 (legacy) cancel button behaviour, closes https://github.com/opnsense/core/issues/1099 2016-12-12 21:34:03 +01:00
Franco Fichtner
029393adf2 firewall: url_safe() conversion, closes #1168
While there, kill "if (write_config())" constructs as this
really isn't a thing.
2016-10-12 08:36:16 +02:00
Ad Schellevis
fdf05de617 (firewall, scrub) add direction and source port. closes https://github.com/opnsense/core/issues/1087 2016-08-07 18:51:17 +02:00
Ad Schellevis
82c9881627 (legacy style code) work on https://github.com/opnsense/core/issues/405 packet normalisation, needed for further restructure and cleanup of filter code. 2016-05-29 19:16:30 +02:00