53 Commits

Author SHA1 Message Date
Ad Schellevis
efa7d6d3fe system_groupmanager.php fix Warning: count(): Parameter must be an array, closes https://github.com/opnsense/core/issues/3391 2019-04-06 17:20:51 +02:00
Ad Schellevis
4a8e737ced fix some gettext() + html_safe, discussed c4c7f8d732 2019-02-03 20:04:08 +01:00
Michael Steenbeek
98247373d0 Remove nonexistant CSS properties
The table attributes 'cellspacing' and 'cellpadding' were moved inside the style attribute via a script. However, they are not valid CSS properties, so browsers should (and do) ignore them.
This commit removes them. The 'table' class, set on most tables, should take care of proper formatting anyway.
2018-12-03 12:01:41 +01:00
Franco Fichtner
09f3f3c933 system: prevent several creative ways to strip read-only privileges 2018-11-07 09:41:20 +01:00
Franco Fichtner
266ff43db5 system: retain index for link #2870
Spotted by: @adschellevis
2018-11-05 21:31:26 +01:00
Franco Fichtner
436b0a7f02 system: sort user/group list, small tweaks; closes #2870 2018-11-03 14:59:37 +01:00
Franco Fichtner
574bd308be src: remove trailing dot workaround by removing trailing dots 2018-09-16 11:44:13 +02:00
Ad Schellevis
901d63cee6 groups, validation issue, spaces are not allowed here 2018-06-06 09:33:48 +02:00
Franco Fichtner
fef90667ca system: authentication page consolidation for #2440 2018-06-03 19:04:36 +00:00
Franco Fichtner
cd7ebecdd3 system: restyle users and groups 2018-06-03 16:43:06 +00:00
Franco Fichtner
333b505094 system: admin priv colouring adjustments
Use "page-all" for showing admin capabilities as user / group
icon in red.  This allows to spot non-root users with full admin
capabilities and also which groups yield this power.  The scope
should only be used for read-only access / deletetion prevention.
2018-06-03 16:14:09 +00:00
NOYB
9d96bdcbc7 Help For - Data For Attribute
Use original element (<div>/<small>) with "data-for" attribute.

The old jquery "for" attribute selectors can be removed once conversion to "data-for" attribute is complete (including plugins).

The old jquery selectors to remove once conversion is complete.
  opnsense_ui.js & head.inc
  $("*[for='" + $(this).attr('id') + "']")....
  $('[for*="help_for"]')....
2018-03-17 16:12:55 +01:00
NOYB
6ef9a127ff HTML Compliance - Attribute "type" on Element <script>
Warning: The type attribute is unnecessary for JavaScript resources.

HTML5: Edition for Web Authors
http://www.w3.org/TR/2014/REC-html5-20141028/scripting-1.html
The default, which is used if the attribute is absent, is "text/javascript".

The Script element
https://developer.mozilla.org/en-US/docs/Web/HTML/Element/script
HTML5 specification urges authors to omit the attribute rather than provide a redundant MIME type.
2018-01-22 19:13:34 +01:00
NOYB
4a7bcae7af HTML Compliance - Attribute "for" on Element <div>
Error: Attribute "for" not allowed on element "div" at this point.
Attributes for element "div": http://www.w3.org/html/wg/drafts/html/master/single-page.html#the-div-element

HTML attribute reference: https://developer.mozilla.org/en-US/docs/Web/HTML/Attributes
The "Output" element: https://developer.mozilla.org/en-US/docs/Web/HTML/Element/output

Attributes for element "output": http://www.w3.org/html/wg/drafts/html/master/single-page.html#the-output-element
2018-01-06 10:52:17 +01:00
NOYB
76aab5cb52 HTML Compliance - Obsolete table attributes
width, align, valign, cellpadding, cellspacing, border, summary

Error: The width attribute on the table element is obsolete. Use CSS instead.
Error: The align attribute on the table element is obsolete. Use CSS instead.
Error: The valign attribute on the table element is obsolete. Use CSS instead.
Error: The cellpadding attribute on the table element is obsolete. Use CSS instead.
Error: The cellspacing attribute on the table element is obsolete. Use CSS instead.
Error: The border attribute on the table element is obsolete. Use CSS instead.
Error: The summary attribute on the table element is obsolete. Consider describing the structure of the table in a caption element or in a figure element containing the table; or, simplify the structure of the table so that no description is needed.
2018-01-04 18:26:02 +01:00
Franco Fichtner
d87c6ff556 Scripts: add a license generator for GitHub 2017-08-05 20:21:35 +02:00
Ad Schellevis
69510a5fad legacy ui pages cleanup for https://github.com/opnsense/core/issues/1733 2017-07-22 15:01:26 +02:00
Ad Schellevis
137dda204d (groups) align groupname length, like 0829a34cef 2017-03-13 09:27:02 +01:00
Franco Fichtner
d3376f7f10 src: webConfigurator -> web GUI 2016-12-19 07:16:08 +01:00
Ad Schellevis
2155d52f38 (theme/style) remove table-sort style, cleanup. 2016-10-17 18:53:55 +02:00
Franco Fichtner
c5ab052b67 system: url_safe() for #1168 2016-10-11 08:11:12 +02:00
Ad Schellevis
14465f999a user/group text mixup in system_groupmanager.php 2016-06-27 13:57:33 +02:00
Ad Schellevis
9a1a4930e0 missing ; 2016-06-27 13:52:45 +02:00
Ad Schellevis
1c6096c160 cleanup js code in system_groupmanager.php for https://github.com/opnsense/core/issues/1005 2016-06-27 13:29:15 +02:00
Ad Schellevis
845cb7aff1 add opnsense_standard_table_form class to forms (2) 2016-05-20 18:13:49 +02:00
Ad Schellevis
e74f0c2a42 (auth) refactor user/group privilege management 2016-05-19 18:41:22 +02:00
Ad Schellevis
7ab0b3463f (legacy) www: strip action attribute from forms where not needed, closes https://github.com/opnsense/core/issues/929 2016-05-12 19:45:28 +02:00
Franco Fichtner
9989097dd8 src: second part of restyle done 2016-04-01 16:05:35 +02:00
Franco Fichtner
c82fdd08f9 system: fix tooltip for add button 2016-03-21 09:51:41 +01:00
Fabian Franz
e9703eb242 translation fix 2016-01-21 11:02:43 +01:00
Manuel Faux
cea23f8cae UX: moved tooltip position to top for most tooltips 2016-01-10 12:06:48 +01:00
Manuel Faux
87014246c0 UX: changed delete icon from "X" to "trash" 2016-01-10 12:06:48 +01:00
Fabian Franz
1d0f083d96 change dialog style 2015-12-31 18:00:31 +01:00
Franco Fichtner
86d50f8793 www: remove the need for manual $pgtitle #461 2015-12-08 19:45:59 +01:00
Ad Schellevis
c975897d6e (legacy) remove redirectHeader, closes https://github.com/opnsense/core/issues/470 2015-12-01 19:34:55 +00:00
Ad Schellevis
10df2a3d0e (legacy) refactor system_groupmanager.php 2015-11-27 15:30:11 +00:00
Franco Fichtner
86cdd1fbfe users: convert tabs to submenu for #402 2015-09-26 08:30:03 +02:00
Franco Fichtner
a66c7889c7 users: the infamous all group kicks the proverbial bucket
The all group was previously removed from the root account due
to the fact that it won't be applied to new user accounts anymore.
This isn't bad as far as we've seen so we went a bit further,
removing the group altogether.  Nice side effect is that a lot of
conditional code just disappears, so I doubt anyone will have any
hard feelings later.
2015-09-14 18:22:45 +02:00
Ad Schellevis
7418af459b (legacy) add additional check on $input_errors as part of cleanup notices 2015-07-06 16:58:36 +00:00
Ad Schellevis
ba800ae6c8 (legacy) fix check on $savemsg and $input_errors 2015-07-06 14:43:02 +00:00
Ad Schellevis
c0449191f4 (legacy) $jsevents["body"]["onload"] is never set 2015-07-06 13:28:46 +00:00
Franco Fichtner
1db49d7c47 system: apply PSR2 style 2015-06-04 20:41:15 +02:00
Franco Fichtner
1e4f4d37aa src: whitespace sweep 2015-05-20 07:10:49 +02:00
Ad Schellevis
69fe3b2931 (group admin) check for internal groupname, fix for https://github.com/opnsense/core/issues/183 2015-05-19 14:54:08 +00:00
Franco Fichtner
03885497b9 system: more style sweeping 2015-05-15 09:59:36 +02:00
Franco Fichtner
4d336198be src: s/pfSenseHeader/redirectHeader/g plus cleanups 2015-04-02 20:23:08 +02:00
Ad Schellevis
fe5ae1b7b2 cleanup requires + small typo's 2015-03-23 20:47:12 +00:00
Ad Schellevis
0a44698f23 remove usage of conf_mount_ro and conf_mount_rw 2015-03-12 12:05:30 +00:00
Jos Schellevis
4f8cea3719 Firmware update enhancements and System GUI pages cleanup 2015-01-23 14:49:49 +00:00
Jos Schellevis
be92da6c35 Fixed some issue with user manager and enhanced gui parts 2015-01-21 15:58:15 +00:00