15858 Commits

Author SHA1 Message Date
Franco Fichtner
db58e04ac3 system: adjust wording on log history search
Discussed with: @adschellevis
2024-08-26 10:11:20 +02:00
Ad Schellevis
268ec80690 System/Logging - cleanup parameter handling in LogController.
Since we already escape arguments when passing them to configd (0adece8d3e/src/opnsense/mvc/app/library/OPNsense/Core/Backend.php (L131)),
we can safely skip sanitation here.

Fix minor issue in last commit (misplacement of $validFrom)
2024-08-25 11:28:06 +02:00
Ad Schellevis
0adece8d3e System/Logging - add log search time constraint (valid_from) to limit searches when only a few lines match.
When searching large log files for messages that do not frequently occur, there is a large risk of reading all collected lines before returning the first results.
In most cases recent items are required, in which case going back for days of logs might not make sense.

This commit adds a simple "history" selection which translates into a "valid_from" filter on the log data. When timestamps are not parseable for whatever reason, the filter is ignored.

Only small downside is that we do need to translate timestamp again, when needed we could improve performance a bit by storing the original datetime value in NewBaseLogFormat so we don't have to parse it twice.
2024-08-24 20:55:12 +02:00
Ad Schellevis
798170b612 System/Logging - unify how search clauses work, when multiple clauses are specified, we should perform a lowercase compare on each clause (AND).
With this change in place, search behavior should be equal to model searches and searchRecordsetBase() consumers.
2024-08-24 18:12:25 +02:00
Franco Fichtner
0c9d8c9404 system: recover stuck monitors only #7027 2024-08-23 22:01:50 +02:00
Franco Fichtner
f9b83a9585 dnsmasq|unbund: unify this code
It only matters for lighttpd preventing a bug but since this could
be copied and some service being added has the same issue make sure
the code is always the one that's least problematic which means
putting "lo0" as the first explicit (and automatic) interface.
2024-08-23 22:01:50 +02:00
Franco Fichtner
c6a5678382 interfaces: convert to newwanip_map
One of the nice things is that we don't have to do the global
loop but get all of the information across at once even if
individual listeners will still loop over it if necessary.
2024-08-23 21:46:07 +02:00
Franco Fichtner
84540d0102 unbound: port to newwanip_map 2024-08-23 21:43:30 +02:00
Ad Schellevis
f2603ca710 System: Settings: Administration - fix broken link to Trust section, closes https://github.com/opnsense/core/issues/7811 2024-08-23 20:50:46 +02:00
Franco Fichtner
ed25dfe85c system: remove obsolete dashboard sync
Dashboard is now stored for each user so to synchronise the user
sync needs to be used.

While here remove the old structure from the default config.xml.

PR: https://forum.opnsense.org/index.php?topic=42392.0
2024-08-23 09:50:28 +02:00
Franco Fichtner
6472278074 openssh: convert to newwanip_map and modernise
* Replace subsystem "locking" with broader config file lock
* change syslog() to log_msg()
* change array() to []
2024-08-23 09:44:55 +02:00
Franco Fichtner
27ef4bfbb7 wireguard: convert to newwanip_map and cleanup 2024-08-23 09:05:51 +02:00
Franco Fichtner
505268a1a3 interfaces: move compatible listeners to newwanip_map
Since the default argument count is ":1" these listeners never
see interfaces so they can be called over the new event and the
old one can be deprecated.
2024-08-23 08:38:46 +02:00
Franco Fichtner
6f0277528a dhcrelay: move to newwanip_map event #7805 2024-08-22 17:17:26 +02:00
Franco Fichtner
bbab80a8b8 interfaces: fix previous
Should not code cross-device.
2024-08-22 17:02:55 +02:00
Franco Fichtner
364f938c02 interfaces: add a mapped newwanip event to avoid multiple reloads
Some services are global so calling them to reconfigure for each interface
is suboptimal.  We can move these to a mapped event with all the interfaces
to reload at once which avoids useless cycles and race conditions.
2024-08-22 16:44:13 +02:00
Franco Fichtner
87147a6e05 dhcrelay: "ensure_running" was a discarded working title
Tried to check PID and avoid start without family association
but extending to pass the address family made more sense so we
can always restart to ensure addresses and routes are matching.
2024-08-22 16:23:36 +02:00
Franco Fichtner
fda0c429ef dhcrelay: start on newwanip as well #7805
Requires new plumbing but since all other event listeners are not
seeing the new inet/inet6 argument by default this should be fine.
2024-08-22 16:18:51 +02:00
Franco Fichtner
7ce814346b interfaces: add logging to PPP link scripts to check for overlap
Currently we neither see when we spawn a new mpd5 daemon nor when
the PPPoE starts or stops working or if there is any overlap.
2024-08-22 14:36:09 +02:00
Franco Fichtner
65a8435df8 system: migrate system booting banner to notifications
Refactor leftovers while here.
2024-08-22 12:07:24 +02:00
Franco Fichtner
b847a368b5 system: annotate this weird spot in the system controller 2024-08-22 11:13:33 +02:00
Franco Fichtner
3067d4e975 system: migrate live mode banner to notification
More work needed but as discussed with @swhite2 we want this here
before we work on the UX part.  These types of notifications need
more screen presence and are non-dismissable.

While here kill an oddity assignment with constant() use.

And adjust comments still refering to "LiveCD" since we have a DVD
image nowadays and the live mode works on all install media.
2024-08-22 11:11:54 +02:00
Franco Fichtner
f5ed3cf3d6
system: replace confirm() use for consistency (#7801) 2024-08-22 09:46:18 +02:00
Franco Fichtner
cb09c6671b interfaces: forcefully disable ipcp bundle
ipv6cp offers no configuration based on the mpd5 source code so
that we should hide the remaining ipcp settings under IPv4 mode too.

PR: https://forum.opnsense.org/index.php?topic=41521.0
2024-08-22 09:34:23 +02:00
Franco Fichtner
49aa78594f rc: fix banner HTTPS fingerprint 2024-08-21 21:22:03 +02:00
sfrings
9b8b096e45
Update MenuSystem.php (#7802) 2024-08-21 20:13:08 +02:00
Stephan de Wit
6e149d37bb dashboard: grid header button consistency and behavior (https://github.com/opnsense/core/issues/7737) 2024-08-21 15:47:35 +02:00
Jaka Prašnikar
48746909a2
dashboard: Change widgets menu buttons to a bootstrap group. (#7799) 2024-08-21 15:22:17 +02:00
Stephan de Wit
0908acf7b2 dashboard: convert lock mode to edit mode (fixes https://github.com/opnsense/core/issues/7737) 2024-08-21 14:54:29 +02:00
Ad Schellevis
f6e9ab00d5 Firewall: NAT: Port Forward - regression in 85bc68df66, wrong description. 2024-08-21 13:17:14 +02:00
Stephan de Wit
48e1933b71 dashboard: compact Services widget (https://github.com/opnsense/core/issues/7766) 2024-08-21 11:39:32 +02:00
Franco Fichtner
58e0c54128 firmware: fix PHP warning 2024-08-21 08:07:00 +02:00
Franco Fichtner
7837c74920 firmware: fix behaviour of register/resync a bit more 2024-08-21 08:04:23 +02:00
Ad Schellevis
59b4defd5b System: Trust: Revocation - add missing delAction()
ref https://forum.opnsense.org/index.php?topic=42340.msg209048#msg209048
2024-08-20 18:22:21 +02:00
Franco Fichtner
7fe558c6b1 interfaces: use new '-i' option to send solicit immediately 2024-08-20 12:09:11 +02:00
Franco Fichtner
689cf50cdf firmware: move cleanups to opnsense-update "-F"
This probably needs more engineering later on which makes
it a little harder to ship but in reality we want people
to run the portable command easily in order to unbreak their
environments as pkg-upgrade tripping over its own temporary
files and directories keeps happening in user reports.

While here use "-s" while at it to speed up the script call.
This also pertains to "-e" which is its sibling.
2024-08-20 11:28:13 +02:00
Franco Fichtner
d8b58d6417 mvc: FileObject write() should sync by default 2024-08-20 11:08:38 +02:00
Franco Fichtner
44a38462fb webgui: since we do not release the log flush for safety
Also remove a stray unlink().
2024-08-20 10:16:30 +02:00
Franco Fichtner
90a37b536f src: when locks are involved better use "e" flag 2024-08-20 10:06:02 +02:00
Franco Fichtner
8206140a4d firewall: simplify previous 2024-08-20 09:39:29 +02:00
Franco Fichtner
92bc25d8f5 filter: remove filter_(un)lock() cruft 2024-08-20 09:03:55 +02:00
Franco Fichtner
61cea387c0 firmware: fix logic in previous 2024-08-20 08:14:32 +02:00
Franco Fichtner
6e135903d3 interfaces: this probably still works 2024-08-20 08:08:03 +02:00
Franco Fichtner
a5a109f9bf ui: shorten previous 2024-08-19 16:20:31 +02:00
René
1493ae8e2f
Sidebar - submenu expand problem (#7785)
Fixes the problem that the submenu does not remain expanded if the focus remains on the menu item.
2024-08-19 13:28:52 +02:00
Stephan de Wit
bdff6631ac dashboard: interface statistics: table view on expansion (https://github.com/opnsense/core/issues/7766) 2024-08-19 12:00:22 +02:00
Stephan de Wit
b8c2fc0b43 dashboard: widget error recovery
If widgets fail to load for any reason, the tick routine simply continues
without interruption. This commit makes sure that the visual error
state isn't stuck and switches back to widget output when possible.
The easiest way to reproduce this is to simply disconnect from
the network while having the dashboard open.
2024-08-19 10:39:45 +02:00
Stephan de Wit
70f1270123 dashboard: traffic graph: reformat to bps (fixes https://github.com/opnsense/core/issues/7789) 2024-08-19 09:21:17 +02:00
doktornotor
df0dcd7522
Fix Data Length help text to reflect the current default value (#7788)
Changed in  044b0d9ad9
2024-08-19 08:37:17 +02:00
Ad Schellevis
7a6f65a293 Reporting / rrd - start using cron for rrd collection. [2]
Minor temporary fix in case /var/db/rrd/updaterrd.sh doesn't exist. All of this will vanish soon, so it isn't worth the effort of chaging the file mode and retesting.

ref https://github.com/opnsense/core/issues/7753
2024-08-18 10:25:40 +02:00