Franco Fichtner
da94d72fda
ui: remove $main_button use #4216
2021-06-14 16:03:26 +02:00
Robin Schneider
f2769fe099
Sort interface groups in GUI to match firewall rule order ( #3537 )
...
This now makes it easy and predictable to add interfaces to multiple
groups.
Before this change, the interfaces_groups GUI was sorted by the
order that interface groups were added. However, this was not the order
that the actual pf rules would then be generated making it unpredictable
when adding interfaces to multiple groups.
The filter_rules_sort function already took care of the actual pf rule
order.
I also took care of only marking the filter subsystem dirty when needed.
I tested this patch quite a bit on 19.1.8. When updating, users only
need to make one change to the interface groups to have them sorted in
the GUI.
I hope I did not miss anything because this patch is against master. In
it’s current state, the patch can be directly applied to 19.1.x or
master.
2019-06-18 16:46:04 +01:00
Franco Fichtner
8b8f02be16
interfaces: group add/delete mwexecf() conversion
...
Since get_real_interface() can be empty it should always be escaped.
2019-04-28 18:56:32 +02:00
Franco Fichtner
14b9f355f2
interfaces: adapt to the new reality of get_real_interface()
2019-04-28 18:32:24 +02:00
Franco Fichtner
3498416734
interfaces: in a perfect world these do not need services.inc
...
Let's make it so. :)
2019-04-25 09:37:34 +02:00
Franco Fichtner
8f80d7620f
interfaces: groups can be virtual
...
PR: https://github.com/opnsense/core/issues/3082
2019-01-02 11:54:32 +01:00
Franco Fichtner
baa43590d7
src: remove get_configured_interface_with_descr()'s $withdisabled
2018-09-11 22:16:31 +02:00
Franco Fichtner
a35b40a4a7
src: remove unused $only_opt
2018-09-11 21:52:34 +02:00
Franco Fichtner
c5ed71ad26
interfaces: style for #2440
2018-06-04 12:18:04 +00:00
NOYB
6ef9a127ff
HTML Compliance - Attribute "type" on Element <script>
...
Warning: The type attribute is unnecessary for JavaScript resources.
HTML5: Edition for Web Authors
http://www.w3.org/TR/2014/REC-html5-20141028/scripting-1.html
The default, which is used if the attribute is absent, is "text/javascript".
The Script element
https://developer.mozilla.org/en-US/docs/Web/HTML/Element/script
HTML5 specification urges authors to omit the attribute rather than provide a redundant MIME type.
2018-01-22 19:13:34 +01:00
Franco Fichtner
c5d4002541
src: add Scott's e-mail everywhere
2017-08-05 20:57:29 +02:00
Ad Schellevis
69510a5fad
legacy ui pages cleanup for https://github.com/opnsense/core/issues/1733
2017-07-22 15:01:26 +02:00
Franco Fichtner
152141866b
interfaces: url_safe() redirects for #1168
2016-10-09 18:26:39 +02:00
Franco Fichtner
0e03967cf5
www: strip plugins.inc from frontend
2016-10-01 10:50:03 +02:00
Franco Fichtner
1d73b3b59d
plugins: follow the footsteps of plugins_syslog() and plugins_services()
...
This looks simple enough now. Discussed with @adschellevis.
2016-08-29 07:10:29 +02:00
Franco Fichtner
7f9fcfb2db
src: translation corrections
...
Suggested by: @Antonio-Prado
2016-08-23 09:41:39 +02:00
Franco Fichtner
ecdcc4b736
plugins: tweak interface plugging
...
PPPoE wasn't removed, which led to some refactoring to find
out why. The outcome is the same, but works a little bit
different now. While there, make it possible to omit the
config write in case we are going to call write_config()
shortly after anyway.
This will also be necessary for the legacy VPN plugins.
2016-08-08 09:07:35 +02:00
Ad Schellevis
dfaf232171
rework last
2016-07-22 12:00:54 +02:00
Ad Schellevis
446da190f0
(interface groups) trigger missing to notify changed interface administration, closes https://github.com/opnsense/core/issues/1064
2016-07-22 11:31:20 +02:00
Franco Fichtner
abcb4cce31
src: start removal of visual clutter in the form of markup "hints" et al
...
This makes pages much easer on the eye, the messages are clear still.
2016-04-01 12:56:15 +02:00
Manuel Faux
cea23f8cae
UX: moved tooltip position to top for most tooltips
2016-01-10 12:06:48 +01:00
Manuel Faux
87014246c0
UX: changed delete icon from "X" to "trash"
2016-01-10 12:06:48 +01:00
Franco Fichtner
015345c805
src: indent copyright header to 4 spaces
2016-01-03 11:52:30 +01:00
Fabian Franz
e30caa1bc3
style fix
2016-01-01 13:28:46 +01:00
Ad Schellevis
2a5ed7b08b
(legacy) refactor interfaces_groups.php
2015-12-31 16:42:00 +01:00
Franco Fichtner
9462194409
interfaces: unify "add" button label
2015-12-13 20:34:20 +01:00
Franco Fichtner
86d50f8793
www: remove the need for manual $pgtitle #461
2015-12-08 19:45:59 +01:00
Franco Fichtner
0d2272ff37
www: interface and dns tools tabs gone for #461
...
Starting to get a life of its own...
2015-12-05 08:59:08 +01:00
Franco Fichtner
98a0662d07
interfaces: zap legacy shortcuts
2015-10-15 00:04:12 +02:00
Franco Fichtner
6b0ebcae69
src: fix recent crash reports
2015-07-31 09:26:39 +02:00
Ad Schellevis
465e699e71
(legacy) dependency cleanups related to functions.inc / interfaces.inc
2015-07-22 16:56:38 +00:00
Ad Schellevis
fe5ae1b7b2
cleanup requires + small typo's
2015-03-23 20:47:12 +00:00
Jos Schellevis
60a5170dc8
Several GUI fixes, including mobile presentation
2015-01-27 14:20:30 +00:00
Jos Schellevis
fb340fcd94
More cleanups, copyrights and links
2015-01-01 13:47:20 +00:00
Franco Fichtner
d389da3582
interfaces: apply whitespace cleanups
2014-12-28 09:36:37 +01:00
Franco Fichtner
727453c076
src: move all files (again)
...
Make "src" the implicit "/usr/local" so that nobody can
sneak in weird files in the base file system or potentially
overwrite them.
This is the last time, I swear... :)
2014-12-10 16:42:39 +01:00
