7458 Commits

Author SHA1 Message Date
NOYB
d944d0d2ff HTML Compliance - Lobby: Dashboard Widgets (#2082)
Error: Attribute alt not allowed on element span at this point.

Error: Table columns in range 2…4 established by element td have no cells beginning in them.

Error: Self-closing syntax (/>) used on a non-void HTML element. Ignoring the slash and treating as a start tag.
Error: Row 1 of a row group established by a tbody element has no cells beginning on it.
Warning: A table row was 0 columns wide, which is less than the column count established by the first row (5).

Error: Duplicate ID submita.
Error: Bad value 100% for attribute width on element img: Expected a digit but saw % instead.
Error: Bad value 100% for attribute height on element img: Expected a digit but saw % instead.
Warning: The border attribute is obsolete. Consider specifying img { border: 0; } in CSS instead.

Avoid potential future Error: Duplicate ID submit.
Error: Attribute autocomplete is only allowed when the input type is color, date, datetime-local, email, hidden, month, number, password, range, search, tel, text, time, url, or week.
2018-01-12 13:07:46 +01:00
Ad Schellevis
c49d9ddc25 Firewall, add md5 hash to generated rules for easier tracking, to easier solve issues with broken configs like https://github.com/opnsense/core/issues/2075
*	optionally show md5 hash in rules page
*	generate md5 hash when flushing rules
*	make sure rules without interface are rendered in the floating section, so they don't get lost.

Eventually the md5 hashes should be replaced with uuid's, like the other mvc code blocks use.
2018-01-12 09:41:58 +01:00
Franco Fichtner
90d8ef6cf2 rc: add workaround for rspamd clashing with 32 bit mmap disallow
PR: https://github.com/opnsense/plugins/issues/466
2018-01-12 08:11:11 +00:00
Franco Fichtner
eadebf784f rc: only zap files in /var/run 2018-01-12 06:53:30 +00:00
Ad Schellevis
ec17d4cadb MVC, add hostname field type. for https://github.com/opnsense/core/issues/2081 2018-01-11 22:10:26 +01:00
Ad Schellevis
ef4bffbf36 Menu, some missing php doc 2018-01-11 20:50:37 +01:00
NOYB
e66eb970b9 HTML Compliance - Lobby: License
Error: Stray end tag span.

Error: No p element in scope but a p end tag seen.
The ordered list makes paragraph tag unnecessary.
2018-01-11 11:15:39 +01:00
Franco Fichtner
ceedb10bbf dhcp: priv-sep for prefix update closes #2079 2018-01-11 08:23:23 +01:00
Franco Fichtner
5e560ac622 system: mail remote logging
PR: https://github.com/opnsense/plugins/issues/366
2018-01-11 00:09:42 +01:00
Franco Fichtner
639bc741c7 dhcp: prefix delete is either a prerequisite, or...
an opportunistic delete so mute the failure in the log.
2018-01-10 19:00:40 +01:00
Franco Fichtner
018bea397a dhcp: second half of @marjohn56's changes; closes #2077 2018-01-10 18:48:57 +01:00
Franco Fichtner
d03799b312 interfaces: fix "route change", obsoleted a long time ago 2018-01-10 18:28:02 +01:00
Franco Fichtner
c62f01f993 dhcp: address issue found by @marjohn56
PR: https://github.com/opnsense/core/pull/2077
2018-01-10 18:22:36 +01:00
Franco Fichtner
c0f45feb0a firmware: security audit says "upgrade done" 2018-01-10 09:54:57 +01:00
Franco Fichtner
5ac7f2b105 wizard: fix a typo 2018-01-10 08:56:32 +01:00
Ad Schellevis
8ea59ed7ec firewall/nat, support ipv+ipv6 for port-forwards, closes https://github.com/opnsense/core/issues/1589 2018-01-09 21:09:54 +01:00
Franco Fichtner
e211d1ab27 interfaces: wait for process to exit like previous 2018-01-09 14:23:35 +01:00
Franco Fichtner
e6dc3265fe interfaces: wait for completion of dhcp6c termination 2018-01-09 11:14:22 +00:00
Franco Fichtner
f98e08d16a services: fix indent, also for #1993 2018-01-09 07:22:42 +00:00
Franco Fichtner
c2162b046e interfaces: align interface write loosely related to #1993 2018-01-09 07:10:39 +00:00
Franco Fichtner
930fb801f1 openssh: make not permitting root login explicit; closes #2069 2018-01-08 23:08:03 +01:00
Franco Fichtner
52b32de0ef rc: add argument to avoid spurious syslog reloads
PR: https://github.com/opnsense/plugins/issues/475
2018-01-08 21:20:06 +00:00
Franco Fichtner
8d441773a9 openssh: tweak GUI display of greeting message
It doesn't necessarily mean disabled, but the root and installer
logins may not apply as previously configured...
2018-01-08 08:44:31 +01:00
Franco Fichtner
d7fb4d13fb src: restore DUID if found 2018-01-08 08:39:40 +01:00
Franco Fichtner
09fabf7867 firmware: worst case this is empty #2066 2018-01-08 07:46:36 +01:00
Franco Fichtner
d0cb477281 rc: mount /boot in live mode to make opnsense package update possible 2018-01-08 07:38:53 +01:00
Franco Fichtner
552b873a87 firewall: rename NPT to NPTv6 for clarity #667 2018-01-08 06:55:35 +01:00
David Harrigan
ce2b6111c1 Add in net.link.bridge.pfil_local_phys.
closes #1894

-=david=-
2018-01-07 11:44:54 +01:00
Franco Fichtner
378aa627d0 ui: allow text to wrap in table-responsive
This seems very odd to be placed in the xs section specifically,
and this fix is wrong, but it's also a bit pointless to override
it with more glue.
2018-01-06 16:19:51 +00:00
NOYB
4a7bcae7af HTML Compliance - Attribute "for" on Element <div>
Error: Attribute "for" not allowed on element "div" at this point.
Attributes for element "div": http://www.w3.org/html/wg/drafts/html/master/single-page.html#the-div-element

HTML attribute reference: https://developer.mozilla.org/en-US/docs/Web/HTML/Attributes
The "Output" element: https://developer.mozilla.org/en-US/docs/Web/HTML/Element/output

Attributes for element "output": http://www.w3.org/html/wg/drafts/html/master/single-page.html#the-output-element
2018-01-06 10:52:17 +01:00
Ad Schellevis
736cf38924 Firewall/VIP, add gateway option for pppoe interfaces, for https://github.com/opnsense/core/issues/2060 2018-01-05 17:25:57 +01:00
Franco Fichtner
945b866df8 system: play whac-a-mole with the serial number #1581 2018-01-05 08:57:54 +01:00
NOYB
b2f4cfa7c1 HTML Compliance - Attribute "type" on Element <i>
Error: Attribute "type" not allowed on element <i> at this point.
2018-01-05 08:36:26 +01:00
NOYB
06f6c5dbf4 HTML Compliance - Obsolete table attributes - II (few stragglers)
width, align, valign, cellpadding, cellspacing, border, summary

Error: The width attribute on the table element is obsolete. Use CSS instead.
Error: The align attribute on the table element is obsolete. Use CSS instead.
Error: The valign attribute on the table element is obsolete. Use CSS instead.
Error: The cellpadding attribute on the table element is obsolete. Use CSS instead.
Error: The cellspacing attribute on the table element is obsolete. Use CSS instead.
Error: The border attribute on the table element is obsolete. Use CSS instead.
Error: The summary attribute on the table element is obsolete. Consider describing the structure of the table in a caption element or in a figure element containing the table; or, simplify the structure of the table so that no description is needed.
2018-01-05 07:43:34 +01:00
NOYB
fad631bb04 Eliminate 300 ms Tap Delay
Implement touch-action: manipulation CSS property to eliminate 300 ms tap delay.

Does not prevent zoom.  Zoom still available by pinch.  Only prevents double tap zoom in order to eliminate the 300 ms tap delay.

What Exactly Is..... The 300ms Click Delay
https://www.telerik.com/blogs/what-exactly-is.....-the-300ms-click-delay

Mozilla developers page.  Updated Oct 25, 2017.
https://developer.mozilla.org/en-US/docs/Web/CSS/touch-action

W3C Recommendation - The touch-action CSS property
http://www.w3.org/TR/pointerevents/#the-touch-action-css-property
2018-01-04 22:06:43 +01:00
Ad Schellevis
579d5f2510 firewall/alias, proper cleanup after kill, https://github.com/opnsense/core/issues/2051 2018-01-04 18:57:29 +01:00
NOYB
76aab5cb52 HTML Compliance - Obsolete table attributes
width, align, valign, cellpadding, cellspacing, border, summary

Error: The width attribute on the table element is obsolete. Use CSS instead.
Error: The align attribute on the table element is obsolete. Use CSS instead.
Error: The valign attribute on the table element is obsolete. Use CSS instead.
Error: The cellpadding attribute on the table element is obsolete. Use CSS instead.
Error: The cellspacing attribute on the table element is obsolete. Use CSS instead.
Error: The border attribute on the table element is obsolete. Use CSS instead.
Error: The summary attribute on the table element is obsolete. Consider describing the structure of the table in a caption element or in a figure element containing the table; or, simplify the structure of the table so that no description is needed.
2018-01-04 18:26:02 +01:00
Franco Fichtner
54410fe38f interfaces: auto-lock problematic interfaces; closes #2002 2018-01-04 14:06:45 +00:00
Franco Fichtner
6ccadfb55e mvc: make enabled checks consistent
Spotted by: @dharrigan
2018-01-04 13:36:19 +01:00
Franco Fichtner
48b164a1a6 system: fix previous, also #1930 2018-01-03 21:21:59 +00:00
Franco Fichtner
6382cbe319 firmware: reload syslog, closes #1930
The syslog reload is kind of graceful so let's try the
cleanest approach before reengineering the world.
2018-01-03 22:11:15 +01:00
Ad Schellevis
a3b48d2ee1 Firewall/Alias, change caption, see https://github.com/opnsense/core/issues/2042#issuecomment-354916478 2018-01-02 22:10:18 +01:00
Franco Fichtner
38609386fb menu: fix DHCPv4 menu context in pools and static mappings 2018-01-03 07:08:12 +00:00
NOYB
1680e68f15 HTML Compliance - Element <button> Descendant of <a> Element
Error: The element button must not appear as a descendant of the a element.

Specification:
http://w3c.github.io/html/textlevel-semantics.html#the-a-element
"Allowed ARIA role attribute values: link (default - do not set), button, checkbox, radio, switch, tab or treeitem"
"The <a> element may be wrapped around entire paragraphs, lists, tables, and so forth, even entire sections, so long as there is no interactive content within (e.g., buttons or other links)."
2018-01-03 07:29:47 +01:00
David Harrigan
7f7941c6e3 Allow input fields to render as readonly.
-=david=-
2018-01-02 15:06:52 +01:00
Franco Fichtner
3ae9866ea7 src: consistent use of readonly as xhtml 2018-01-02 14:47:46 +01:00
Franco Fichtner
fd7d59c856 firewall: natural language translation for previous
It's ok to use breaking spaces, comma-separated values read ok.
2018-01-02 10:51:17 +01:00
Franco Fichtner
3109b519e5 src: regenerate dhparam files 2018-01-02 10:51:17 +01:00
Ad Schellevis
4ac6fae7da Firewall/Nat outbound, change caption 2018-01-02 08:46:44 +01:00
Franco Fichtner
81a6424f72 firewall: natural CSV for previous 2018-01-02 07:28:26 +01:00