63 Commits

Author SHA1 Message Date
Ad Schellevis
c660d3ec8c firewall, formNetworks() is the same as get_specialnets() now 2016-06-01 13:40:25 +02:00
Ad Schellevis
c7d03899f5 firewall pages, normalize interface selection, using the new interface plugins 2016-06-01 13:21:01 +02:00
Ad Schellevis
a19f10fbb2 (firewall) zapp "match" 2016-05-30 15:11:08 +02:00
Ad Schellevis
4a0b1b8292 cleanup, remove unused in firewall_rules_edit.php 2016-05-27 16:01:02 +02:00
Ad Schellevis
58001db0cc (firewall) parse /etc/protocols for valid options, sort most used on top. 2016-05-25 16:12:34 +02:00
Ad Schellevis
16348d265e (firewall, ui) remove IPV6 as valid protocol selection 2016-05-24 13:17:09 +02:00
Ad Schellevis
0b31dc522f add opnsense_standard_table_form class to forms 2016-05-20 17:09:58 +02:00
Franco Fichtner
cc9cede6d8 firewall: move any to front of the list 2016-05-18 19:45:38 +02:00
Ad Schellevis
7ab0b3463f (legacy) www: strip action attribute from forms where not needed, closes https://github.com/opnsense/core/issues/929 2016-05-12 19:45:28 +02:00
Franco Fichtner
726e4c05bc firewall: fix previous 2016-05-07 18:23:36 +02:00
Franco Fichtner
fffcede4e1 cron: migrate the time-based rules cron job to autocron
o Gets rid of cron save/flush in the filter reload path.
o Gets rid of cron job injection into config.
o Move configure_cron() to the rules edit where it can be
  flipped in case of schedule changes.

To be totally frank, a 15 minute hook to deploy a time
based system is hardly accurate.  But what worries me more
is that we still have this patch in the kernel, totally
unsure of what it actually does when we have a schedule-based
reload on top anyway:

0a19f81317
2016-05-07 18:13:26 +02:00
Franco Fichtner
aa21adfe18 firewall: mark deprecated ICMP types; closes #912
Taken from: http://www.iana.org/assignments/icmp-parameters/icmp-parameters.xhtml
2016-04-28 08:40:26 +02:00
Franco Fichtner
50e4df6cb7 src: three crash reports 2016-04-27 13:52:41 +02:00
Fabian Franz
5f62f9a165 translation 2016-03-31 09:34:15 +02:00
Fabian Franz
9dbbceb4d5 translation 2016-03-31 09:21:17 +02:00
Ad Schellevis
67b827a84f html correction 2016-03-04 12:07:12 +01:00
Ad Schellevis
48c5641f67 (legacy) missing change() event on proto select 2016-02-04 15:06:06 +01:00
Franco Fichtner
2db592b1fb firewall: always display all known gateways on edit
There are a few cases where the gateway code is eligible
to drop a gateway on grounds of being disabled, inactive,
unconfigured or where the actual interface assigned is
disabled.  This is undesire because users that configure
a gateway won't be able to use it.

There are no bad side effects from the former by selecting
a whatsoever dysfunctional gateway, because the problem still
has to be fixed by the user in the gateway setup itself.

Worst of all, removing a disabled but used gateway makes
it not show up on edit, effectively wiping its setting on
save.  This breaks POLA.

While there, also enable the null routes for IPv4 and IPv6.

PR: https://forum.opnsense.org/index.php?topic=2100
2016-02-04 07:59:08 +01:00
Ad Schellevis
74d923fd1f (legacy) fix interface selection on post issues in floating rules, firewall_rules_edit.php 2016-02-02 09:33:21 +01:00
Ad Schellevis
35a11180fc (legacy) firewall, add optional rule category 2016-01-29 23:31:04 +01:00
Ad Schellevis
a7e4762b9c (legacy) fix html errors, remove $closehead 2016-01-27 18:18:05 +01:00
Franco Fichtner
68bb3fa5c3 firewall: remove non-standard dscp feature
FreeBSD never implemented this.  OpenBSD did it differently and
more consequently: the `tos' tag of pf.conf(4) was properly extended
and their pf(4) can only be used to set the DSCP bit for symmetry
and general usefulness.  Until this comes back around to FreeBSD,
we'll leave it out.
2016-01-24 19:20:42 +01:00
Franco Fichtner
bd652e9058 src: make quick the default for floating rules for #504 2016-01-07 16:15:23 +01:00
Ad Schellevis
791ccd116a (legacy) add interface groups to firewall rules and portforwards, add missing curly braces 2016-01-04 10:52:34 +01:00
Frank Wall
26184e18ce fix label for option Source/Invert 2015-12-28 13:44:23 +01:00
Ad Schellevis
1400ea7632 (legacy) lock portnumbers on protocols other then tcp/udp, closes https://github.com/opnsense/core/issues/542 2015-12-18 15:09:17 +01:00
Franco Fichtner
86d50f8793 www: remove the need for manual $pgtitle #461 2015-12-08 19:45:59 +01:00
Ad Schellevis
84ba6a498c (legacy) crashreport strpos() expects parameter 1 to be string, array given in /usr/local/www/firewall_rules_edit.php on line 747 2015-12-01 09:31:47 +00:00
Fabian Franz
94e161436d fixes for #427 in firewall_rules_edit.php 2015-11-07 15:55:44 +01:00
Franco Fichtner
6652e2390a src: multiple crash reports and whitespace sweep 2015-10-20 17:52:31 +02:00
Franco Fichtner
10a9a5e213 firewall: fix spelling for `Aliases'
Spotted by: @fabianfrz
2015-10-04 17:12:13 +02:00
Ad Schellevis
5df05e9e97 (legacy) fix missing log option in save form 2015-09-24 14:10:28 +00:00
Ad Schellevis
5366b2b898 (configd/legacy) align result of "filter list osfp" 2015-08-27 18:09:32 +00:00
Ad Schellevis
1b899db59f whitespace firewall_rules_edit.php 2015-08-27 15:36:13 +02:00
Ad Schellevis
0f4e0377d5 (legacy) firewall_rules_edit.php add full help button 2015-08-25 14:26:40 +00:00
Ad Schellevis
7e638a7cdc (legacy) style fix in firewall_rules_edit.php 2015-08-25 14:20:34 +00:00
Ad Schellevis
d9eb6c6b60 whitespace firewall_rules_edit.php 2015-08-25 13:47:23 +00:00
Ad Schellevis
9e61814456 (legacy) refactor firewall_rules_edit.php 2015-08-25 13:45:12 +00:00
Ad Schellevis
a7bee644f1 (legacy) fix crashreport " PHP Warning: Illegal string offset 'ifgroupentry' in /usr/local/www/firewall_rules_edit.php on line 869" 2015-08-10 09:56:42 +00:00
Franco Fichtner
6b0ebcae69 src: fix recent crash reports 2015-07-31 09:26:39 +02:00
Ad Schellevis
ade367057a (legacy) fix another php warning 2015-07-24 16:23:52 +00:00
Ad Schellevis
564703643c (legacy) fix some warnings in firewall pages 2015-07-24 10:00:09 +00:00
Ad Schellevis
ea5dd43a31 (legacy) move pfsense-utils.inc dependency 2015-07-22 15:09:18 +00:00
Ad Schellevis
ccdaf72bb0 (legacy) cleanup filter.inc requires 2015-07-21 13:03:58 +00:00
Ad Schellevis
3fd636be11 (legacy) cleanup globals.inc 2015-07-10 14:17:50 +00:00
Ad Schellevis
c0cc76263c (legacy) cleanups related to pfsense-utils.inc (remove unused, move single usage, isset issues) 2015-07-08 15:48:16 +00:00
Ad Schellevis
2480cd3920 (legacy) remove unused, move single used functions out of shared files 2015-07-07 13:43:13 +00:00
Ad Schellevis
7418af459b (legacy) add additional check on $input_errors as part of cleanup notices 2015-07-06 16:58:36 +00:00
Ad Schellevis
ba800ae6c8 (legacy) fix check on $savemsg and $input_errors 2015-07-06 14:43:02 +00:00
Franco Fichtner
0e3ea0485e www: strip unused javascript; related to #208 2015-06-22 10:10:02 +02:00