10872 Commits

Author SHA1 Message Date
Franco Fichtner
e965edba59 mvc: style sweep 2020-04-13 11:50:20 +02:00
Ad Schellevis
0dd01c2807 MVC: catch ArgumentCountError as these derive from Error and not the general Exception type. Maybe we might need to add "Error" as well, but the argument count is pretty generic and is easy to trigger.
Inspired by https://github.com/opnsense/core/issues/4031
2020-04-08 06:12:27 +02:00
Ad Schellevis
5dda9e5452 whitespace 2020-04-08 06:10:03 +02:00
Franco Fichtner
9904a1da4c interfaces: make rc.newwanipv6 more clever...
... since b8a3c3dd3f6c can mimic the behaviour of get_interface_ipv6()
we can now call interfaces_primary_address6() instead of the less
educated find_interface_ipv6*() equivalents.

Probably quite some people with WAN aliases run into this issue where
renewal doesn't work because rc.newwanipv6 latches on to the VIP instead
of the primary address.
2020-04-11 11:25:03 +02:00
Ad Schellevis
d24a546a78 Firewall source nat (outbound), support ranges in plugins. for https://github.com/opnsense/plugins/issues/1749 2020-04-07 22:08:24 +02:00
Ad Schellevis
b5e507f7c7 IPv6 essential icmpv6, fix previous for https://github.com/opnsense/core/issues/4028 mixed up addresses as noted by @fichtner 2020-04-07 20:08:06 +02:00
Ad Schellevis
25630084d0 IPv6 essential icmpv6 allow :: for https://github.com/opnsense/core/issues/4028
RFC 4861 Neighbor Discovery in IPv6 has cases where the source address is unspecified ("::")
i.e. Par 4.1 Router Solicitation Message Format
2020-04-07 16:04:55 +02:00
Ad Schellevis
285f7c65ed Firewall -> Rules, checkbox input ignores visibility setting. for https://github.com/opnsense/core/issues/4020 2020-04-06 07:09:20 +02:00
Franco Fichtner
e5eb7affb3 system: refactor beep.sh a little 2020-04-06 18:29:19 +02:00
Franco Fichtner
f57bc3d93b mvc: small style update 2020-04-06 13:39:10 +02:00
Franco Fichtner
df73492c72 interfaces: typo 2020-04-06 13:34:39 +02:00
Ad Schellevis
fe335024fb MVC: PortField keep options in static set. for https://github.com/opnsense/core/pull/4019 2020-04-06 13:27:19 +02:00
Ad Schellevis
29b1489fda MVC: while looking at https://github.com/opnsense/core/pull/4019 noticed a wrong security model for the multiselect toggle, which could lead to unaccesible data in portfield and modelfields.
(some php versions seem to ignore this)
2020-04-06 13:04:58 +02:00
Franco Fichtner
87d4bd4084 shell: remove irrelevant historic mention 2020-04-06 09:16:57 +02:00
Ad Schellevis
7d335be5d2 Firewall: Diagnostics: Sockets, remove legacy page, the new interfaces->Diagnostics->Netstat contains the same info. for https://github.com/opnsense/core/issues/4013
To be released in 20.7
2020-04-05 14:39:04 +02:00
Ad Schellevis
2cd73a5a2d Interfaces / Diagnostics: add bpf,memory and netisr stats, cleanup template while here as well. for https://github.com/opnsense/core/issues/4013 2020-04-05 14:29:00 +02:00
Franco Fichtner
c4bc519e9a mvc: style sweep 2020-04-05 09:47:08 +02:00
Franco Fichtner
ca5ab79c8d ui: move tree.query.js to "min." annotation
Helps with whitespace sweep not wanting to change the EOL
character on minified js.  Fix plist while here.  ;)
2020-04-05 09:09:08 +02:00
Ad Schellevis
656543c572 Interfaces / Diagnostics: add netstat treeview for https://github.com/opnsense/core/issues/4013
We migh consider ditching diag_sockets.php in 20.7 as well, since the socket output combines sockstat(1) and netstat(1).
2020-04-03 18:09:57 +02:00
Franco Fichtner
d045d7ddd2 openvpn: one translation to rule them all... 2020-04-03 11:01:11 +02:00
Franco Fichtner
e35692fe66 system: Dutch out, Norwegian in 2020-04-03 10:53:23 +02:00
Ad Schellevis
7cb4773285 MVC: add jqtree (http://mbraak.github.io/jqTree) 2020-04-02 17:16:43 +02:00
Franco Fichtner
2ed21f1b2a interfaces: menu fix for multiple interface use in groups 2020-04-02 13:55:04 +02:00
Franco Fichtner
8d3977cd1e interfaces: POC for #4016
One issue is multiple links for the same interface are all highlighted,
but that would be fixable... :)
2020-04-02 13:46:31 +02:00
Ad Schellevis
56a75b538d Interfaces -> Diagnostics -> ARP table: use libxo to extract data, eases parsing a bit 2020-04-02 12:01:07 +02:00
Franco Fichtner
a0960edcf9 firewall: automatic order for menu items, virtual IPs to interfaces
Discussed with: @adschellevis
2020-04-02 09:44:13 +02:00
Ad Schellevis
b12cac5b2d Shaper: as discussed with @fichtner collapse shaper options into menu for clarity 2020-04-01 19:21:45 +02:00
Franco Fichtner
3ebe6f5d26 menu: experiment with firewall menu a bit more 2020-04-01 20:59:55 +02:00
Franco Fichtner
37de586ba1 menu: groups seem lost below, treat it a bit more alphabetically 2020-04-01 20:53:33 +02:00
Ad Schellevis
ae38199d1c Shaper: increment sequence on new records 2020-04-01 11:26:50 +02:00
Ad Schellevis
26d3127ddf MVC: bootgrid. pass fetchmode=copy when requesting a record to copy it later. The controller could use this to set defaults when copying.
e.g.

$fetchmode = $this->request->has("fetchmode") ? $this->request->get("fetchmode") : null;
2020-04-01 11:24:50 +02:00
Franco Fichtner
b8a3c3dd3f interfaces: adapt logic employed by get_interface_ipv6()
If we do not specifically list a prefix ignore global
addresses even if we get one for free.  The GUI has been
indicating the same thing for quite some time now.
2020-04-01 09:20:29 +02:00
Franco Fichtner
6323cb793f shell: use interfaces_primary_address6() for correct IPv6 display 2020-04-01 09:10:32 +02:00
Franco Fichtner
afec5341ec mvc: style update 2020-03-31 10:36:01 +02:00
Franco Fichtner
7d118218c6 mvc: whitespace style 2020-03-30 16:18:16 +02:00
Ad Schellevis
7ee060456b Firewall/Aliases: add network group type to combine aliases (and offer the user a fixed selector).
While here, also add a type filter to ease searching through larger lists.

for https://github.com/opnsense/core/issues/4006
2020-03-30 14:50:01 +02:00
Franco Fichtner
a4c6003bc2 Revert "use freebsd built in growfs script (#3810)"
Breaks our default Nano image growfs, the only use case we have.

This reverts commit 7fe5fe52dcc948d8988f995905efeab8d96af144.
This reverts commit 16efb9aa348124b1d5d9755f40c67df8124698ba.
2020-03-30 12:17:22 +02:00
Ad Schellevis
5274bc634c fix previous 2020-03-27 15:57:54 +01:00
Ad Schellevis
8b5a54e030 OpenVPN server: multihome when selecting any interface + udp. closes https://github.com/opnsense/core/issues/4004 2020-03-27 15:49:01 +01:00
Ad Schellevis
c81b5b8dc4 MVC: add "migration_prefix" attribute to model, so plugins can choose different prefixes than "M" when sharing the same namespace. While here, also perform a style sweep.
Needed for https://github.com/opnsense/plugins/issues/1749 (using the same namespace as the aliases in core)
2020-03-25 13:03:36 +01:00
Ad Schellevis
db24905974 Auth:LDAP. missing strtolower() in ldap response, closes https://github.com/opnsense/core/issues/3999 2020-03-24 17:42:35 +01:00
Ad Schellevis
7704dc2519 Shaper: replace legacy page diag_limiter_info.php with an api enabled traffic breakdown overview. closes https://github.com/opnsense/core/issues/3994 2020-03-24 16:33:36 +01:00
Franco Fichtner
2bcfd124b8 interfaces: stop radvd from crashing 2020-03-24 08:59:11 +01:00
Franco Fichtner
ae4a84ff5d plugins: for console use append a newline 2020-03-23 12:10:04 +01:00
Ad Schellevis
593e3a7abf Mirrors: opnsense.ieji.de --> opn.sense.nz 2020-03-22 20:59:46 +01:00
Ad Schellevis
c8e607a8a9 Shaper: add statiscs endpoint /api/trafficshaper/service/statistics for https://github.com/opnsense/core/issues/3994 2020-03-21 12:19:16 +01:00
Ad Schellevis
b109234dfa Unbound: minor cleanup in /api/unbound/diagnostics/stats endpoint 2020-03-20 22:50:44 +01:00
Franco Fichtner
fe3a49c2d2 src: fix lint pass 2020-03-21 08:28:21 +01:00
Ad Schellevis
fff394c44b Shaper: add wrapper to collect different ipfw stats to be combined in the api controller to build later.
new call `configctl ipfw stats`

There are some assumptions in parsing these stats, ipfw/dummynet man page doesn't seem to provide mich insights on the details delivered by the various "show" commands.

for https://github.com/opnsense/core/issues/3994
2020-03-20 19:57:19 +01:00
Ad Schellevis
f8392c1d47 Shaper: add uuid to shaper rules, for https://github.com/opnsense/core/issues/3994 2020-03-20 19:39:39 +01:00