Franco Fichtner
c30477bef7
openvpn: remove hardcoded service include
...
Add two temporary spots that need to be reworked later when
this is verified working. Other plugins also register their
interfaces so it would be nice to pin them all down in a shared
hook.
2019-04-23 15:48:47 +02:00
Franco Fichtner
1a507990b1
interfaces: get_real_interface() $wanif is really $realif (d'oh)
2019-04-23 15:45:01 +02:00
Franco Fichtner
64e1a893b6
interfaces: fix passing VLAN name
2019-04-23 14:26:36 +02:00
Franco Fichtner
b788ea24bd
services: cleanups, preparations
2019-04-23 14:04:15 +02:00
Franco Fichtner
6449801ade
ipsec: ok to drop ipsec include from services
...
Add a little plugin glue to two tainted spots.
2019-04-23 12:49:04 +02:00
Franco Fichtner
44a95cea38
dnsmasq: also looks safe to drop hardcoded services include
...
The code has come a long way...
2019-04-23 12:27:29 +02:00
Franco Fichtner
d592f494b6
unbound: looks safe to drop hardcoded service include
2019-04-23 12:27:28 +02:00
Franco Fichtner
b31445fd2f
system: SSH include is no longer needed
2019-04-23 10:51:11 +02:00
Franco Fichtner
6d8fb87d91
interfaces: fix comment #3406
2019-04-23 08:16:18 +02:00
Franco Fichtner
7ff838caca
interfaces: deleting interfaces already disables them #3406
...
Which in the case of track6 disables the new deconfiguration process.
2019-04-23 08:04:31 +02:00
Franco Fichtner
05622d5a93
plugins: plugins_run() has no workers concept
...
"Workers" are chains of commands, but with run we want defined
output from the plugin itself so only one function/endpoint
returning the data.
2019-04-22 20:18:50 +02:00
Franco Fichtner
2fbccb05fa
interfaces: last refactor #3406
2019-04-22 12:50:23 +02:00
Franco Fichtner
23a0d85311
interfaces: obvs #3406
2019-04-22 08:55:36 +02:00
Franco Fichtner
990541a2b3
interfaces: second try for track6 deconfigure #3406
2019-04-22 08:54:35 +02:00
Franco Fichtner
3620fe47da
interfaces: try to pin down deconfigure as well #3406
2019-04-22 08:40:15 +02:00
Franco Fichtner
88c5ffae9a
interfaces: refresh config too, not only reload #3406
2019-04-22 08:32:38 +02:00
Franco Fichtner
8963c86dd7
plugins: use plugin name as intended
2019-04-21 19:33:05 +02:00
Franco Fichtner
780da44988
dpinger: removed pass-down at the last minute
2019-04-21 19:31:10 +02:00
Franco Fichtner
168be32071
system: provided by legacy bindings are facilities...
...
... which are bound to MVC code. Move remaining "pure" gateway
functions to the legacy_bindings and use plugins_run() stub to
get to the dpinger data... The data could later be coalesced
or split up, but for now that seems reasonable enough (provided
it works ok and @adschellevis more or less likes this direction).
2019-04-21 19:27:45 +02:00
Franco Fichtner
0e8943c94a
plugins: to get data from (multiple) plugins introduce plugins_run()
2019-04-21 19:11:45 +02:00
Franco Fichtner
f3b5c0e8f7
system: hide dpinger configuration inside new plugins_configure() call
...
Some back and forth between explicit and implicit requires while here.
The code is helplessly glued together and no plugin facility to get
data from a function call currently exists.
2019-04-21 19:04:15 +02:00
Ad Schellevis
2e896d47b3
backup, disable cron when not enabled. closes https://github.com/opnsense/core/issues/3430
2019-04-19 11:06:50 +02:00
Franco Fichtner
81b43740f2
system: remove unused option
2019-04-17 10:47:26 +00:00
Franco Fichtner
9f54891523
dpinger: reshuffle some related code
2019-04-17 07:06:26 +02:00
Franco Fichtner
494ba0b7b5
system: move gwlb.inc to dpinger.inc
2019-04-16 19:55:17 +02:00
Ad Schellevis
b5adb0c312
Routing, gateways. move get_gateway_error() from gwlb.inc to gateway_alert script, since only used there now. for https://github.com/opnsense/core/issues/2279
2019-04-16 14:19:42 +02:00
Ad Schellevis
5d37a23f2c
Routing, gateways. replace contents of return_gateway_groups_array() for https://github.com/opnsense/core/issues/2279 complete removacl should be part of https://github.com/opnsense/core/issues/3423
2019-04-16 14:15:34 +02:00
Ad Schellevis
0ea621cab3
Routing, gateway groups, use new class methods in filter and filter edit page, for https://github.com/opnsense/core/issues/2279
2019-04-16 13:57:29 +02:00
Ad Schellevis
118acc33e5
routing, gateways. In gateway groups you could originally select a vip, which isn't used in our system. orgininally this came from ab1112da4c
...
Let's remove it while working on https://github.com/opnsense/core/issues/2279
2019-04-15 18:59:13 +02:00
Ad Schellevis
1feaa21fe4
Routing, gateways - groups. regression in https://github.com/opnsense/core/issues/2279 , since "interface" contains the configured value now, we should use "if".
2019-04-15 18:39:02 +02:00
Ad Schellevis
497f523f6e
Routing, gateways. When gathering gateway status from dpinger, don't consider dpinger endpoints down if not yet available. This could lead to some unexpected gateway switches. for https://github.com/opnsense/core/issues/2279
...
We might consider another status for "startup", although since we report loss and delay as "~" it should already be obvious that we don't know the status yet.
2019-04-15 16:48:49 +02:00
Ad Schellevis
b4d8a49678
Routing, gateways. log gateways that are not being considered, https://github.com/opnsense/core/issues/2279
2019-04-15 12:51:23 +02:00
Ad Schellevis
6101ba8940
sysct, remove duplicates. closes https://github.com/opnsense/core/issues/3410
2019-04-15 09:32:33 +02:00
Franco Fichtner
c20a25b21b
system: gwlb.inc will be dpinger.inc some day
...
Start using correct prefixes in obvious functions.
2019-04-13 19:38:22 +02:00
Ad Schellevis
c4d42929fb
Routing, gateways. missed two statements where friendlyiface was used, since we keep the configured "interface", these need to be renamed. for https://github.com/opnsense/core/issues/2279
2019-04-13 17:35:34 +02:00
Ad Schellevis
4cc7157d78
Routing, gateways. now that get_interface_gateway_v6() and get_interface_gateway() are unused, ditch duplicate these duplicates. for https://github.com/opnsense/core/issues/2279
2019-04-13 17:28:29 +02:00
Ad Schellevis
c69e1f0b6b
Routing, gateways. there's no need to try to retrieve the gateway address twice in return_gateway_groups_array(), our gateway class already resolved the address. for https://github.com/opnsense/core/issues/2279
2019-04-13 17:26:25 +02:00
Ad Schellevis
ac239827d4
Routing, gateways. replace get_interface_gateway() in get_interfaces_info() for https://github.com/opnsense/core/issues/2279
2019-04-13 17:20:45 +02:00
Ad Schellevis
18cd8b8e58
Routing, gateways. replace get_interface_gateway() in interface_6to4_configure() for https://github.com/opnsense/core/issues/2279
2019-04-13 17:17:33 +02:00
Ad Schellevis
2011da3800
Routing, gateways. replace get_interface_gateway() in interface_6rd_configure() for https://github.com/opnsense/core/issues/2279
2019-04-13 17:16:22 +02:00
Ad Schellevis
be85768f6b
Routing, gateways. interface_gif_configure() replace get_interface_gateway() with new class implementation, reverted previous patch (misread the target interface). for https://github.com/opnsense/core/issues/2279
2019-04-13 17:12:18 +02:00
Ad Schellevis
5c4da8687d
Revert "Route, gateways. prevent possible race in interface_gif_configure(), (host route not created on first execution) and remove get_interface_gatewayXXX usage. for https://github.com/opnsense/core/issues/2279 "
...
This reverts commit 0c1f95b9b3f24625a29b788b5d74c9ce858c609b.
2019-04-13 17:03:24 +02:00
Ad Schellevis
0c1f95b9b3
Route, gateways. prevent possible race in interface_gif_configure(), (host route not created on first execution) and remove get_interface_gatewayXXX usage. for https://github.com/opnsense/core/issues/2279
2019-04-13 16:20:15 +02:00
Ad Schellevis
aacd319511
Route, gateways. in filter.lib.in:filter_core_get_initialized_plugin_system() replace get_interface_gatewayXXX with new object call, for https://github.com/opnsense/core/issues/2279
2019-04-12 20:56:26 +02:00
Ad Schellevis
9be62b07f9
Routing, gateways. system_routing_configure() should use the exact same method to determine "default" as evrything else, removes quite some obscure hooks and duplicated logic. definitely needs additional testing, for https://github.com/opnsense/core/issues/2279
2019-04-12 18:47:21 +02:00
Ad Schellevis
10a858855b
Route, gateways. remove return_gateways_array(), replaced with new gateways class. for https://github.com/opnsense/core/issues/2279
2019-04-12 18:13:29 +02:00
Ad Schellevis
446ba20cce
Routing, gateways. ditch refactor return_gateway_groups_array() to use the new gateways class, for https://github.com/opnsense/core/issues/2279
2019-04-12 18:03:57 +02:00
Ad Schellevis
c67b276bf9
gateway monitoring, don't report perfect when unknown, closes https://github.com/opnsense/core/issues/3408
...
and ditch return_gateways_array() usage for https://github.com/opnsense/core/issues/2279
2019-04-12 17:26:41 +02:00
Ad Schellevis
58a2efd4f9
Routing, gateways. use new gateways class in setup_gateways_monitor() and do some minor cleanups.
...
* monitor field is the responsibility of the class, so there's no need to check it again (duplicate)
* interface was previously overwritten with technical name, which is now in "if" field, replace occurrences
* simplify reasons to ignore gateways a bit (if, elseif block on top of loop)
for https://github.com/opnsense/core/issues/2279
2019-04-12 16:13:02 +02:00
Ad Schellevis
ace8f9af7f
Routing, gateways. without consumers, its safe to kill lookup_gateway_interface_by_name, for https://github.com/opnsense/core/issues/2279
2019-04-12 15:54:52 +02:00