63 Commits

Author SHA1 Message Date
Michael Steenbeek
3f673e3ce6 Fix it's, repeated words and a/an (#3332) 2019-03-19 17:08:47 +01:00
Ad Schellevis
4a8e737ced fix some gettext() + html_safe, discussed c4c7f8d732 2019-02-03 20:04:08 +01:00
Michael Steenbeek
f127c7d9a9 Clarify incorrect gateway IP error (#3093) 2019-01-03 14:12:50 +01:00
Franco Fichtner
8ca8def5ac firewall: localhost is actually loopback, loosely refs #3041 2018-12-13 09:08:53 +01:00
Ad Schellevis
754d483b86 Firewall/VirtualIP, when checking for usage, limit to type (ipalias may bee using the same vhid). 2018-12-03 14:39:10 +01:00
Michael Steenbeek
98247373d0 Remove nonexistant CSS properties
The table attributes 'cellspacing' and 'cellpadding' were moved inside the style attribute via a script. However, they are not valid CSS properties, so browsers should (and do) ignore them.
This commit removes them. The 'table' class, set on most tables, should take care of proper formatting anyway.
2018-12-03 12:01:41 +01:00
Michael Steenbeek
19ce1c57a4 Replace uncommon <> notation with != 2018-11-23 14:36:44 +01:00
Michael Steenbeek
7f09e04d81 Fix some HTML errors 2018-11-21 11:42:01 +01:00
Franco Fichtner
574bd308be src: remove trailing dot workaround by removing trailing dots 2018-09-16 11:44:13 +02:00
Franco Fichtner
baa43590d7 src: remove get_configured_interface_with_descr()'s $withdisabled 2018-09-11 22:16:31 +02:00
Franco Fichtner
a35b40a4a7 src: remove unused $only_opt 2018-09-11 21:52:34 +02:00
Franco Fichtner
063a425f27 firewall: IPv6 does not have network address restrictions; closes #2543 2018-07-14 10:49:19 +00:00
Ad Schellevis
075a0b7a4a CARP/VIP, remove address requirement for virtual ip's, closes https://github.com/opnsense/core/issues/2358 2018-04-15 15:37:09 +02:00
NOYB
9d96bdcbc7 Help For - Data For Attribute
Use original element (<div>/<small>) with "data-for" attribute.

The old jquery "for" attribute selectors can be removed once conversion to "data-for" attribute is complete (including plugins).

The old jquery selectors to remove once conversion is complete.
  opnsense_ui.js & head.inc
  $("*[for='" + $(this).attr('id') + "']")....
  $('[for*="help_for"]')....
2018-03-17 16:12:55 +01:00
Franco Fichtner
dd71f72b45 src: style fix 2018-03-11 00:13:02 +01:00
NOYB
6ef9a127ff HTML Compliance - Attribute "type" on Element <script>
Warning: The type attribute is unnecessary for JavaScript resources.

HTML5: Edition for Web Authors
http://www.w3.org/TR/2014/REC-html5-20141028/scripting-1.html
The default, which is used if the attribute is absent, is "text/javascript".

The Script element
https://developer.mozilla.org/en-US/docs/Web/HTML/Element/script
HTML5 specification urges authors to omit the attribute rather than provide a redundant MIME type.
2018-01-22 19:13:34 +01:00
NOYB
4a7bcae7af HTML Compliance - Attribute "for" on Element <div>
Error: Attribute "for" not allowed on element "div" at this point.
Attributes for element "div": http://www.w3.org/html/wg/drafts/html/master/single-page.html#the-div-element

HTML attribute reference: https://developer.mozilla.org/en-US/docs/Web/HTML/Attributes
The "Output" element: https://developer.mozilla.org/en-US/docs/Web/HTML/Element/output

Attributes for element "output": http://www.w3.org/html/wg/drafts/html/master/single-page.html#the-output-element
2018-01-06 10:52:17 +01:00
Ad Schellevis
736cf38924 Firewall/VIP, add gateway option for pppoe interfaces, for https://github.com/opnsense/core/issues/2060 2018-01-05 17:25:57 +01:00
NOYB
b2f4cfa7c1 HTML Compliance - Attribute "type" on Element <i>
Error: Attribute "type" not allowed on element <i> at this point.
2018-01-05 08:36:26 +01:00
NOYB
76aab5cb52 HTML Compliance - Obsolete table attributes
width, align, valign, cellpadding, cellspacing, border, summary

Error: The width attribute on the table element is obsolete. Use CSS instead.
Error: The align attribute on the table element is obsolete. Use CSS instead.
Error: The valign attribute on the table element is obsolete. Use CSS instead.
Error: The cellpadding attribute on the table element is obsolete. Use CSS instead.
Error: The cellspacing attribute on the table element is obsolete. Use CSS instead.
Error: The border attribute on the table element is obsolete. Use CSS instead.
Error: The summary attribute on the table element is obsolete. Consider describing the structure of the table in a caption element or in a figure element containing the table; or, simplify the structure of the table so that no description is needed.
2018-01-04 18:26:02 +01:00
Franco Fichtner
498247b4df firewall: another 2017-09-28 09:54:16 +02:00
Franco Fichtner
bb5e7d434f firewall: another cleanup 2017-09-28 09:52:52 +02:00
Franco Fichtner
d33f91ddf9 firewall: prevent VHID from changing at all
Editing the page and forcing a form error changes the VHID which
is still suboptimal.  Now never touch the setting, but leave
the button to be used and add a verification for CARP to enforce
a selected VHID.

PR: https://github.com/opnsense/core/issues/1849
2017-09-28 07:40:51 +00:00
Franco Fichtner
58c9c32810 firewall: add label for "none" VHID for #1849 2017-09-28 09:10:15 +02:00
Franco Fichtner
ab12bf0233 firewall: fixup button submit behaviour and UX in VIP edit; closes #1849 2017-09-27 04:18:50 +00:00
Ad Schellevis
bcba583191 disable tabstop in firewall_virtual_ip_edit.php / unused, for https://github.com/opnsense/core/issues/1849 2017-09-26 20:28:50 +02:00
Ad Schellevis
8ae34afbba virtual_ip, add optional vhid to support alias ip's on carp. for https://github.com/opnsense/core/issues/1779 2017-08-24 22:49:04 +02:00
Franco Fichtner
d87c6ff556 Scripts: add a license generator for GitHub 2017-08-05 20:21:35 +02:00
Ad Schellevis
69510a5fad legacy ui pages cleanup for https://github.com/opnsense/core/issues/1733 2017-07-22 15:01:26 +02:00
Ad Schellevis
9bba2092ee Replace get_configured_ip_addresses() and get_configured_ipv6_addresses() with a more pragmatic approach, both are used to detect if an address is already configured, which gets quite sloppy when having a large number of interface
s configured.

This change probes all configured interfaces at once, and returns the full list, stripping quite some magic in the process.

Because the indexing is changed, we need to change the consumers as well here.
2017-05-26 19:49:05 +02:00
Ad Schellevis
52b95b80c0 (legacy) cancel button behaviour, closes https://github.com/opnsense/core/issues/1099 2016-12-12 21:34:03 +01:00
Franco Fichtner
029393adf2 firewall: url_safe() conversion, closes #1168
While there, kill "if (write_config())" constructs as this
really isn't a thing.
2016-10-12 08:36:16 +02:00
Fabian Franz
6411baeaa1 translation; closes #1069
Omit the console changes, we are not prepared for improving
the translation there.
2016-08-10 08:34:05 +02:00
Ad Schellevis
dfd5332213 (carp) remove restriction for matching interface subnet. closes https://github.com/opnsense/core/issues/795 2016-07-15 18:04:38 +02:00
Ad Schellevis
4e3b66c257 zapp pfsense-utils.inc 2016-06-20 16:59:19 +02:00
Ad Schellevis
0b31dc522f add opnsense_standard_table_form class to forms 2016-05-20 17:09:58 +02:00
Franco Fichtner
1650342466 firewall: can't change mode, cluster menu features; closes #921
Not really satisfied with the HA split but let's just say it's a
work in progress...
2016-05-19 20:19:42 +02:00
Ad Schellevis
7ab0b3463f (legacy) www: strip action attribute from forms where not needed, closes https://github.com/opnsense/core/issues/929 2016-05-12 19:45:28 +02:00
Franco Fichtner
4bcdc72b3f firewall: prune virtual ip section 2016-04-01 12:56:15 +02:00
Fabian Franz
18cd3edd3c translation 2016-03-26 11:26:16 +01:00
Ad Schellevis
857a1b2e71 gettext() 2016-03-26 09:09:50 +01:00
azdps
63e7e17617 (legacy) description and consistency cleanup in firewall_virtual_ip_edit.php 2016-03-25 21:22:03 -07:00
Ad Schellevis
67b827a84f html correction 2016-03-04 12:07:12 +01:00
Franco Fichtner
60963fe9c2 firewall: fix spurious error when moving alias interface, closes #531 2016-01-08 23:25:23 +01:00
Ad Schellevis
499b58eeb3 (legacy) remove jquery.ipv4v6ify.js from firewall_virtual_ip_edit.php 2015-12-29 21:27:31 +01:00
Ad Schellevis
10a42da46a (legacy) save 0 values in firewall_virtual_ip_edit.php (https://github.com/opnsense/core/pull/570) 2015-12-27 15:46:02 +01:00
Franco Fichtner
86d50f8793 www: remove the need for manual $pgtitle #461 2015-12-08 19:45:59 +01:00
Ad Schellevis
c8437ad698 (legacy) make subnet selectable on ipalias, closes https://github.com/opnsense/core/issues/445 2015-10-28 21:50:05 +00:00
Ad Schellevis
8d28488f22 (legacy, firewall_virtual_ip_edit.php) apply issue on new vip 2015-10-11 16:13:34 +00:00
Ad Schellevis
453ee9c198 whitespace 2015-08-27 13:09:46 +00:00