Seems to work fine, but the new and old code has some oddities like
obsessing over the "up" flag, but we set all interfaces up before
we start the process. Some style updates and separation of use
while here.
Splitting on /\d/ seems overly toxic when the device is called
e.g. em10_vlan12 so address that in the utility code where it is
carried out. get_interface_list() is probably a function that
should be removed in the mid-term.
o Batch the backend call calling from GUI once and
only if needed from configuration.
o Turn the configuration into a generic loop.
o Move advanced options to the back of the configuration.
o Warning level for both log messages.
As OpenSSH 8.8 disables RSA signatures using the SHA-1 hash algorithm
by default some older SSH clients might not be able to connect to
OPNsense anymore. Therefore, it might be needed to manually modify the
PubkeyAcceptedAlgorithms sshd config option.
Prevent generating of invalid configuration values for dynamic
crypto parameters (KexAlgorithms, Ciphers, MACs, HostKeyAlgorithms and
PubkeyAcceptedAlgorithms).
* mv: Add BlankDesc to ModelRelationField
* Add BlankDesc option for ModelRelationField types.
* Copied from BaseListField type.
* mvc: refactor ModelRelationField and add unit test
This follows the refactor effort in #3252 where
ModelRelationField was excluded.
* ModelRelationField.php
* Extend from BaseListField type
* Remove vars which are inherited from BaseListField
* Remove functions which are inherited from BaseListField
* Add $internalCacheOption for internal manipulation
* Comments throughout
* ModelRelationFieldTest.php
* Add comments for all test to described in plain language
* Add a few tests focused on BlankDesc
* Add some more sort related tests
* Add some other possible scenarios
* Move storing jQuery Bootgrid settings in browser from core to bootgrid
- Update of jquery.bootgrid.js from 1.3.5 to 1.4.0 (opnsense/jquery-bootgrid#5)
- Removing of equivalent functionality from opnsense_bootgrid_plugin.js
* Bugfix when restoring row count to pre-select entry in dropdown
While technically not correct to make flags "AdvDeprecatePrefix"
and "AdvRemoveRoute" we simply use it to overwrite the existing
defaults which depend on CARP-or-not situation in the address
being used.
There was an extensive discussion about what it should and should
not do but the only way to keep the current defaults AND provide
requested overrides is this one.
The valid values are either "off" or "on", but no validation
takes place as customary to this page's advanced options. Use
with care.
It changes with each build since it has a rebuild date but most
of the time it is not being reinstalled. Besides this helps testing
and is relatively portable since we don't rely on the actual content.
It applies all sysctls on interfaces settings save but there
isn't much of a point splitting the functionality or hardcoding
yet another spot with the required sysctls.
In a future version we might want to be able to ship metadata per log view, in which case the service binding and defaults should be provided from there.
/etc/ttys has two more entries one of which we add conditionally
and the other one we don't need so for now don't add these two.
When we rework the code in system.inc we can include them later
in the new way.
Suspicion confirmed that e.g. 6RD misses the wrong interface.
Just run the code when necessary instead of caching it for
a situation that isn't matching.
