37 Commits

Author SHA1 Message Date
Franco Fichtner
2396e4b3ff interfaces: adjust wireless handling slightly for new return code 2023-09-20 09:29:49 +02:00
Franco Fichtner
6f91dc4683 interfaces: finish wireless/wlan rework #5987
* Devices are now configured inline or directly via pluginctl
* Try to use "wlan" underneath as shorter and upstream term
2022-08-29 07:46:31 +02:00
Franco Fichtner
2b9f029819 interfaces: stop calling match_wireless_interface() everywhere #5987
Restructure return value of legacy_interface_listget() to return
WLAN-only devices present in the system and avoid returning null
value to simplify the couple of callers (some already assumed as
much).

Assume that <wireless/> node is properly set since console.inc
always did store this.  Not sure about wireless clones yet, but
will check and fix in the scope of this ticket anyway.

get_interface_list() moves to interfaces.lib.inc since it uses
most functions from there and util.inc should not want to know
about interface details in the first place.  We need this later
when we work through interfaces_assign.php for device iteration
reasons.
2022-08-24 12:19:04 +02:00
Ad Schellevis
c11df998cb Interfaces / Wireless - fix regression in 3ef64ab8ea
closes https://github.com/opnsense/core/issues/5955
2022-08-14 13:40:12 +02:00
Franco Fichtner
dfdb51cafb interfaces: hide missing mac info
Ever since wlan devices moved to sysctl net.wlan.devices
there is no way to grab a MAC address for any of those
listed there.
2022-07-27 13:24:12 +02:00
Franco Fichtner
74958f2032 interfaces: get_interface_list() is a strange one for sure
It's supposed to be handing out physical interfaces only but
callers decided to exclude stuff they didn't want because it
is not physical instead of fixing the function.
2022-01-19 12:40:19 +01:00
Ad Schellevis
4a8e737ced fix some gettext() + html_safe, discussed c4c7f8d732 2019-02-03 20:04:08 +01:00
Franco Fichtner
68e2f850a5 interfaces: header indent and small consolidation in iterator 2018-12-29 10:57:56 +01:00
Michael Steenbeek
d27cc83642 Change foreach loops that don't use values to use array_keys() 2018-12-18 14:37:11 +01:00
Michael Steenbeek
88c28e3258 Fix typos and mismatched HTML tags (#2998) 2018-12-03 13:19:11 +01:00
Franco Fichtner
7c853d62a9 src: get rid of get_configured_interface_list() 1/2 2018-09-11 21:14:53 +02:00
NOYB
9d96bdcbc7 Help For - Data For Attribute
Use original element (<div>/<small>) with "data-for" attribute.

The old jquery "for" attribute selectors can be removed once conversion to "data-for" attribute is complete (including plugins).

The old jquery selectors to remove once conversion is complete.
  opnsense_ui.js & head.inc
  $("*[for='" + $(this).attr('id') + "']")....
  $('[for*="help_for"]')....
2018-03-17 16:12:55 +01:00
NOYB
4a7bcae7af HTML Compliance - Attribute "for" on Element <div>
Error: Attribute "for" not allowed on element "div" at this point.
Attributes for element "div": http://www.w3.org/html/wg/drafts/html/master/single-page.html#the-div-element

HTML attribute reference: https://developer.mozilla.org/en-US/docs/Web/HTML/Attributes
The "Output" element: https://developer.mozilla.org/en-US/docs/Web/HTML/Element/output

Attributes for element "output": http://www.w3.org/html/wg/drafts/html/master/single-page.html#the-output-element
2018-01-06 10:52:17 +01:00
NOYB
b2f4cfa7c1 HTML Compliance - Attribute "type" on Element <i>
Error: Attribute "type" not allowed on element <i> at this point.
2018-01-05 08:36:26 +01:00
NOYB
76aab5cb52 HTML Compliance - Obsolete table attributes
width, align, valign, cellpadding, cellspacing, border, summary

Error: The width attribute on the table element is obsolete. Use CSS instead.
Error: The align attribute on the table element is obsolete. Use CSS instead.
Error: The valign attribute on the table element is obsolete. Use CSS instead.
Error: The cellpadding attribute on the table element is obsolete. Use CSS instead.
Error: The cellspacing attribute on the table element is obsolete. Use CSS instead.
Error: The border attribute on the table element is obsolete. Use CSS instead.
Error: The summary attribute on the table element is obsolete. Consider describing the structure of the table in a caption element or in a figure element containing the table; or, simplify the structure of the table so that no description is needed.
2018-01-04 18:26:02 +01:00
Ad Schellevis
69510a5fad legacy ui pages cleanup for https://github.com/opnsense/core/issues/1733 2017-07-22 15:01:26 +02:00
Ad Schellevis
52b95b80c0 (legacy) cancel button behaviour, closes https://github.com/opnsense/core/issues/1099 2016-12-12 21:34:03 +01:00
Franco Fichtner
152141866b interfaces: url_safe() redirects for #1168 2016-10-09 18:26:39 +02:00
Ad Schellevis
0b31dc522f add opnsense_standard_table_form class to forms 2016-05-20 17:09:58 +02:00
Franco Fichtner
1ed6b9986f interfaces: assorted UI tweaks and corrections 2016-04-07 08:41:09 +02:00
Ad Schellevis
67b827a84f html correction 2016-03-04 12:07:12 +01:00
Franco Fichtner
d41b5a7456 src: reindent copyright block to four spaces 2015-12-29 20:22:41 +01:00
Ad Schellevis
f8e5a3750d (legacy) refactor interfaces_wireless_edit.php 2015-12-28 16:56:44 +01:00
Franco Fichtner
86d50f8793 www: remove the need for manual $pgtitle #461 2015-12-08 19:45:59 +01:00
Franco Fichtner
50d01becf9 src: do not reorder sprintf arguments by default
(Already had issues in the code that were obvious, some may still
linger in there.  Also uselessly confuses our dedicated translators.)
2015-11-10 13:22:52 +01:00
Franco Fichtner
c9504d9748 wireless: actually, keep the one that is there (if any) 2015-09-18 16:15:58 +02:00
Franco Fichtner
cf343609d0 wireless: hide more config options from this page 2015-09-18 16:10:01 +02:00
Franco Fichtner
cd4b8267aa wireless: only advertise supported modes; closes #377 2015-09-18 14:08:38 +02:00
Ad Schellevis
465e699e71 (legacy) dependency cleanups related to functions.inc / interfaces.inc 2015-07-22 16:56:38 +00:00
Ad Schellevis
7418af459b (legacy) add additional check on $input_errors as part of cleanup notices 2015-07-06 16:58:36 +00:00
Ad Schellevis
ba800ae6c8 (legacy) fix check on $savemsg and $input_errors 2015-07-06 14:43:02 +00:00
Franco Fichtner
f9cf7910a2 src: try to unwind the wireless_regex global foo 2015-04-24 11:28:14 +02:00
Ad Schellevis
fe5ae1b7b2 cleanup requires + small typo's 2015-03-23 20:47:12 +00:00
Jos Schellevis
60a5170dc8 Several GUI fixes, including mobile presentation 2015-01-27 14:20:30 +00:00
Jos Schellevis
fb340fcd94 More cleanups, copyrights and links 2015-01-01 13:47:20 +00:00
Franco Fichtner
d389da3582 interfaces: apply whitespace cleanups 2014-12-28 09:36:37 +01:00
Franco Fichtner
727453c076 src: move all files (again)
Make "src" the implicit "/usr/local" so that nobody can
sneak in weird files in the base file system or potentially
overwrite them.

This is the last time, I swear...  :)
2014-12-10 16:42:39 +01:00