If the user's existing subnet isn't 192.168.1.1/xx, then telling the user to use this IP will fail. So tell the user how to set a different IP after reboot, rather than just telling them to use an IP that won't work for them.
Kept short this time - 1 line only :)
Also edited wording re certificate, to be clearer about this as well, by starting with what they will actually see (*"Your browser may..."* rather than *"You might need to..."*). Added just 1 line there as well.
Sorry for these - hopefully not overdoing it. (I'm a fan of making life fun for newcomers, and install is where newcomers first see if a thing works for them!) Perhaps they can be squashed down to save text space. If so please do.
Switch the static implementation to act like the MVC one. The BEGIN
and END tag removal is opportunistic because we don't need to shuffle
several configs into one and it still fails if the tags are not correct.
It looks like parseRdrRules() yields too many rdr rules, since it adds all reflection interfaces including the ones which don't serve the protocol of the interface.
Logically we should check if the selected interface has an address configured for the protocol at hand, like we seemed to have done for the nat rule following when nat reflection is enabled.
There might be some edge cases where we don't automatically render rules now, in cases where the interface doesn't have an address configured, but there's always an option to add forward rules manually.
The general idea here is to make it explicit that _stf generated another interface for IPv6 traffic, so we can use this knowledge when parsing rules easily.
We call the file ".min." so that our whitespace sweep does not
clean up whitespaces to retain the original checksum so that
the file can always be verified.
and breaks when using OpenSSL 1.1.
Also start the header block for new crypt settings. It's a bit
unfortunate that the MVC backup factory doesn't handle the
headers... now we have to add them in any case to make all
interoperable.
PR: https://github.com/opnsense/core/issues/2535
