Franco Fichtner
9ea3a61e38
system: allow to edit entries with non-conforming names; closes #4643
...
These have been created by other parts of the system and end
up being too long. It does not matter much as we cannot change
a name after it exists, but so now make sure we only check the
confirmity when the gateway / group did not exist previously.
2021-06-17 11:50:55 +02:00
Ad Schellevis
a57abe792f
legacy: ditch is_validaliasname() for good. closes https://github.com/opnsense/core/issues/4470
2021-01-08 17:33:00 +01:00
Franco Fichtner
cf609e2e6a
src: small style update
2021-01-05 09:12:02 +01:00
Franco Fichtner
b2560c6eb4
services: split code to get rid of shallow services.inc #3736
2019-10-01 08:33:15 +02:00
Franco Fichtner
b14f10b698
system: gwgroups not staticroutes
...
Discussed with: @adschellevis
2019-04-23 16:09:18 +02:00
Ad Schellevis
b50fdd790c
Routing, gateways. missed a spot in https://github.com/opnsense/core/issues/2279 , remove column header for VIP
2019-04-16 15:32:05 +02:00
Ad Schellevis
118acc33e5
routing, gateways. In gateway groups you could originally select a vip, which isn't used in our system. orgininally this came from ab1112da4c
...
Let's remove it while working on https://github.com/opnsense/core/issues/2279
2019-04-15 18:59:13 +02:00
Ad Schellevis
a2aba45eb7
Routing, gateway_groups, don't hide gateways on edit, which keeps presentation on new/edit equal. Previously you could have a group, containing an item that didn't exist anymore (interface removed), in which case you needed to remove the group to be able to edit it. related to https://github.com/opnsense/core/issues/2279
2019-04-15 18:27:25 +02:00
Ad Schellevis
c4d42929fb
Routing, gateways. missed two statements where friendlyiface was used, since we keep the configured "interface", these need to be renamed. for https://github.com/opnsense/core/issues/2279
2019-04-13 17:35:34 +02:00
Ad Schellevis
a7ddcb6e3c
Routing, gateways. ditch return_gateways_array() usage in system_gateway_groups.php, system_gateway_groups_edit.php for https://github.com/opnsense/core/issues/2279
2019-04-11 13:21:15 +02:00
Ad Schellevis
4a8e737ced
fix some gettext() + html_safe, discussed c4c7f8d732
2019-02-03 20:04:08 +01:00
Franco Fichtner
895605846a
system: remove service control from gateway edit pages for clarity
...
We can only start / stop all, not selective gateways during edit
or even gateway groups.
2018-11-16 07:47:53 +01:00
Franco Fichtner
cae5ec3f69
system: remove apinger, dpinger takes over
2018-11-10 23:42:17 +01:00
NOYB
9d96bdcbc7
Help For - Data For Attribute
...
Use original element (<div>/<small>) with "data-for" attribute.
The old jquery "for" attribute selectors can be removed once conversion to "data-for" attribute is complete (including plugins).
The old jquery selectors to remove once conversion is complete.
opnsense_ui.js & head.inc
$("*[for='" + $(this).attr('id') + "']")....
$('[for*="help_for"]')....
2018-03-17 16:12:55 +01:00
NOYB
6ef9a127ff
HTML Compliance - Attribute "type" on Element <script>
...
Warning: The type attribute is unnecessary for JavaScript resources.
HTML5: Edition for Web Authors
http://www.w3.org/TR/2014/REC-html5-20141028/scripting-1.html
The default, which is used if the attribute is absent, is "text/javascript".
The Script element
https://developer.mozilla.org/en-US/docs/Web/HTML/Element/script
HTML5 specification urges authors to omit the attribute rather than provide a redundant MIME type.
2018-01-22 19:13:34 +01:00
NOYB
4a7bcae7af
HTML Compliance - Attribute "for" on Element <div>
...
Error: Attribute "for" not allowed on element "div" at this point.
Attributes for element "div": http://www.w3.org/html/wg/drafts/html/master/single-page.html#the-div-element
HTML attribute reference: https://developer.mozilla.org/en-US/docs/Web/HTML/Attributes
The "Output" element: https://developer.mozilla.org/en-US/docs/Web/HTML/Element/output
Attributes for element "output": http://www.w3.org/html/wg/drafts/html/master/single-page.html#the-output-element
2018-01-06 10:52:17 +01:00
NOYB
b2f4cfa7c1
HTML Compliance - Attribute "type" on Element <i>
...
Error: Attribute "type" not allowed on element <i> at this point.
2018-01-05 08:36:26 +01:00
NOYB
76aab5cb52
HTML Compliance - Obsolete table attributes
...
width, align, valign, cellpadding, cellspacing, border, summary
Error: The width attribute on the table element is obsolete. Use CSS instead.
Error: The align attribute on the table element is obsolete. Use CSS instead.
Error: The valign attribute on the table element is obsolete. Use CSS instead.
Error: The cellpadding attribute on the table element is obsolete. Use CSS instead.
Error: The cellspacing attribute on the table element is obsolete. Use CSS instead.
Error: The border attribute on the table element is obsolete. Use CSS instead.
Error: The summary attribute on the table element is obsolete. Consider describing the structure of the table in a caption element or in a figure element containing the table; or, simplify the structure of the table so that no description is needed.
2018-01-04 18:26:02 +01:00
Ad Schellevis
9005f82230
gateway groups, tier selection triggers on wrong object.
2017-12-12 11:57:21 +01:00
Ad Schellevis
69510a5fad
legacy ui pages cleanup for https://github.com/opnsense/core/issues/1733
2017-07-22 15:01:26 +02:00
Franco Fichtner
68faafd185
aliases: improve validation messages; closes #1443
2017-04-12 07:36:56 +02:00
Franco Fichtner
9b694b705d
start to hide IPsec and OpenVPN for pluginification
2017-03-11 17:51:54 +01:00
Ad Schellevis
52b95b80c0
(legacy) cancel button behaviour, closes https://github.com/opnsense/core/issues/1099
2016-12-12 21:34:03 +01:00
Franco Fichtner
c5ab052b67
system: url_safe() for #1168
2016-10-11 08:11:12 +02:00
Ad Schellevis
0b31dc522f
add opnsense_standard_table_form class to forms
2016-05-20 17:09:58 +02:00
Ad Schellevis
7ab0b3463f
(legacy) www: strip action attribute from forms where not needed, closes https://github.com/opnsense/core/issues/929
2016-05-12 19:45:28 +02:00
Ad Schellevis
67b827a84f
html correction
2016-03-04 12:07:12 +01:00
Franco Fichtner
c9b7076609
plugins: don't need so many includes
2016-02-21 20:09:07 +01:00
Franco Fichtner
d7df9ecf10
src: move ipsec.inc require to top pages
...
For now plugins.inc and ipsec.inc will coexist on pages that
may need only one or none to avoid unefined function errors.
This will be pruned after investigating the contents of both
files...
2016-02-21 20:09:07 +01:00
Franco Fichtner
f79fac8f25
src: first shuffling for splitting off plugins from core
2016-02-21 20:09:07 +01:00
Franco Fichtner
6e3e407d85
services: rename shorcut_section to better reflect its purpose; closes #674
2016-01-18 09:30:34 +01:00
Franco Fichtner
3d93e25ba0
services: remove indirect mapping and fix remaining services
2016-01-18 09:29:38 +01:00
Franco Fichtner
d41b5a7456
src: reindent copyright block to four spaces
2015-12-29 20:22:41 +01:00
Franco Fichtner
86d50f8793
www: remove the need for manual $pgtitle #461
2015-12-08 19:45:59 +01:00
Franco Fichtner
166c571b5e
www: another batch for #461
2015-12-05 08:24:21 +01:00
Ad Schellevis
163268f433
(legacy) add protocol selector handling in system_gateway_groups_edit.php
2015-11-30 11:32:32 +00:00
Ad Schellevis
3301e1a2c9
(legacy) refactor system_gateway_groups_edit.php
2015-11-30 10:23:27 +00:00
Fabian Franz
6612086c21
fixes for #427
2015-11-10 18:38:42 +01:00
Franco Fichtner
d11e97562b
system/routes: convert to submenu
...
Thin out "Status" and "Diagnostics" white at it, although the
overall static page conception isn't consistent at all. Not
liking this, but something has got to be done. Won't be the
last commit I think. :)
2015-09-21 15:12:57 +02:00
Ad Schellevis
020ce673cd
(legacy) more dependency cleanups
2015-07-23 09:45:57 +00:00
Ad Schellevis
465e699e71
(legacy) dependency cleanups related to functions.inc / interfaces.inc
2015-07-22 16:56:38 +00:00
Ad Schellevis
7418af459b
(legacy) add additional check on $input_errors as part of cleanup notices
2015-07-06 16:58:36 +00:00
Ad Schellevis
ba800ae6c8
(legacy) fix check on $savemsg and $input_errors
2015-07-06 14:43:02 +00:00
Franco Fichtner
27a063052e
system/gateway: style sweep
2015-05-15 09:53:47 +02:00
Franco Fichtner
3505b0423f
src: whitespace sweep + style fixes
2015-04-10 09:19:35 +02:00
Ad Schellevis
ae0b9af71a
cleanup fend.inc
2015-04-08 19:50:45 +00:00
Franco Fichtner
15eb3c5652
gateways: more potential fails of legacy code vs. new config system
2015-04-03 12:12:43 +02:00
Ad Schellevis
fe5ae1b7b2
cleanup requires + small typo's
2015-03-23 20:47:12 +00:00
Jos Schellevis
4f8cea3719
Firmware update enhancements and System GUI pages cleanup
2015-01-23 14:49:49 +00:00
Franco Fichtner
5e9ab6d856
src: apply whitespace cleanups
2015-01-11 10:07:23 +01:00
