It's supposed to be handing out physical interfaces only but
callers decided to exclude stuff they didn't want because it
is not physical instead of fixing the function.
* Remove the unset-after-write-before-redirect logic of dhcpd on
WAN that practically does nothing.
* At least since b6b3a5ad1d6c41 interface_bring_down() does not
tamper with down flag of the interface avoiding the need to
set the up flag to fix "VLAN" (multiple times).
* Remove debug output that I have never seen before. The function
call below will throw an error too if that is even possible.
Add *Interfaces: Other Types: Loopback*.
- while here, also add the device name in interfaces.php and support setting an initial description on new interfaces (copy device description if available)
- check usages of lo0 and change to lo if not specific for our default loopback
@Adschellvis and me wondered about this so I did a bit of
reseach and multiple workaround oddities exist to fix parts
of the issue. To be frank, fix the issue at the source and
do not let users otherwise configure these settings in tunnel
interfaces.
See: https://redmine.pfsense.org/issues/3280
Also see: https://redmine.pfsense.org/issues/8687
When no LAN is present OPT1 can now be configured. To make sure that
anti-lockout doesn't shift never again assume that "LAN" can be assigned.
The same is already true for "WAN".
Some style while here...
Regression introduced in 566fe52 a while back. Checked the commits
and code again so a bit of assorted cleanup attached. Other spots
in the commits look good.
* interfaces_assign.php: creation year addition for Jim McBeath
* filter_log.inc: spurious attribution via 96899e89f0c
* diag_traceroute.php: typo in split via d87c6ff556
* Manuel Kasper e-mail missing in a few pages
We should trust the "other type" create/drop to handle the interface itself and interface_bring_down() should only unconfigure it, so possible parent/child interfaces won't break for no reason.
Fixes part of https://github.com/opnsense/core/issues/1709
We have a function pair rrd_import() / rrd_export() now, which do
wildly different things even though they've been used for a single
purpose:
(1) rrd_export() writes a string, appends it to the config.xml
(2) rrd_import() takes a parsed config portion, but not as an
argument, rather as a global config element
(3) There was also an older backup clue which exported files, but
simply packed them up for restore after boot
If we can get the system to unify the usage we'll end up with a
neat way of backing, restoring and migrating RRD data, although
I'm not sure if this can be fully compatible with the old files.
o consolidate "unbound_" prefix for unbound.inc for pluginification
o services.inc includes unbound.inc rightfully, a bit like a
plugin would do in the future, but this also means we can
zap all requires from top pages, which are entirely spurious.
o get_dns_servers() moves to system.inc because it is used by
status_interfaces.php
o RIP read_hosts()
