10849 Commits

Author SHA1 Message Date
Franco Fichtner
8d3977cd1e interfaces: POC for #4016
One issue is multiple links for the same interface are all highlighted,
but that would be fixable... :)
2020-04-02 13:46:31 +02:00
Ad Schellevis
56a75b538d Interfaces -> Diagnostics -> ARP table: use libxo to extract data, eases parsing a bit 2020-04-02 12:01:07 +02:00
Franco Fichtner
a0960edcf9 firewall: automatic order for menu items, virtual IPs to interfaces
Discussed with: @adschellevis
2020-04-02 09:44:13 +02:00
Ad Schellevis
b12cac5b2d Shaper: as discussed with @fichtner collapse shaper options into menu for clarity 2020-04-01 19:21:45 +02:00
Franco Fichtner
3ebe6f5d26 menu: experiment with firewall menu a bit more 2020-04-01 20:59:55 +02:00
Franco Fichtner
37de586ba1 menu: groups seem lost below, treat it a bit more alphabetically 2020-04-01 20:53:33 +02:00
Ad Schellevis
ae38199d1c Shaper: increment sequence on new records 2020-04-01 11:26:50 +02:00
Ad Schellevis
26d3127ddf MVC: bootgrid. pass fetchmode=copy when requesting a record to copy it later. The controller could use this to set defaults when copying.
e.g.

$fetchmode = $this->request->has("fetchmode") ? $this->request->get("fetchmode") : null;
2020-04-01 11:24:50 +02:00
Franco Fichtner
b8a3c3dd3f interfaces: adapt logic employed by get_interface_ipv6()
If we do not specifically list a prefix ignore global
addresses even if we get one for free.  The GUI has been
indicating the same thing for quite some time now.
2020-04-01 09:20:29 +02:00
Franco Fichtner
6323cb793f shell: use interfaces_primary_address6() for correct IPv6 display 2020-04-01 09:10:32 +02:00
Franco Fichtner
afec5341ec mvc: style update 2020-03-31 10:36:01 +02:00
Franco Fichtner
7d118218c6 mvc: whitespace style 2020-03-30 16:18:16 +02:00
Ad Schellevis
7ee060456b Firewall/Aliases: add network group type to combine aliases (and offer the user a fixed selector).
While here, also add a type filter to ease searching through larger lists.

for https://github.com/opnsense/core/issues/4006
2020-03-30 14:50:01 +02:00
Franco Fichtner
a4c6003bc2 Revert "use freebsd built in growfs script (#3810)"
Breaks our default Nano image growfs, the only use case we have.

This reverts commit 7fe5fe52dcc948d8988f995905efeab8d96af144.
This reverts commit 16efb9aa348124b1d5d9755f40c67df8124698ba.
2020-03-30 12:17:22 +02:00
Ad Schellevis
5274bc634c fix previous 2020-03-27 15:57:54 +01:00
Ad Schellevis
8b5a54e030 OpenVPN server: multihome when selecting any interface + udp. closes https://github.com/opnsense/core/issues/4004 2020-03-27 15:49:01 +01:00
Ad Schellevis
c81b5b8dc4 MVC: add "migration_prefix" attribute to model, so plugins can choose different prefixes than "M" when sharing the same namespace. While here, also perform a style sweep.
Needed for https://github.com/opnsense/plugins/issues/1749 (using the same namespace as the aliases in core)
2020-03-25 13:03:36 +01:00
Ad Schellevis
db24905974 Auth:LDAP. missing strtolower() in ldap response, closes https://github.com/opnsense/core/issues/3999 2020-03-24 17:42:35 +01:00
Ad Schellevis
7704dc2519 Shaper: replace legacy page diag_limiter_info.php with an api enabled traffic breakdown overview. closes https://github.com/opnsense/core/issues/3994 2020-03-24 16:33:36 +01:00
Franco Fichtner
2bcfd124b8 interfaces: stop radvd from crashing 2020-03-24 08:59:11 +01:00
Franco Fichtner
ae4a84ff5d plugins: for console use append a newline 2020-03-23 12:10:04 +01:00
Ad Schellevis
593e3a7abf Mirrors: opnsense.ieji.de --> opn.sense.nz 2020-03-22 20:59:46 +01:00
Ad Schellevis
c8e607a8a9 Shaper: add statiscs endpoint /api/trafficshaper/service/statistics for https://github.com/opnsense/core/issues/3994 2020-03-21 12:19:16 +01:00
Ad Schellevis
b109234dfa Unbound: minor cleanup in /api/unbound/diagnostics/stats endpoint 2020-03-20 22:50:44 +01:00
Franco Fichtner
fe3a49c2d2 src: fix lint pass 2020-03-21 08:28:21 +01:00
Ad Schellevis
fff394c44b Shaper: add wrapper to collect different ipfw stats to be combined in the api controller to build later.
new call `configctl ipfw stats`

There are some assumptions in parsing these stats, ipfw/dummynet man page doesn't seem to provide mich insights on the details delivered by the various "show" commands.

for https://github.com/opnsense/core/issues/3994
2020-03-20 19:57:19 +01:00
Ad Schellevis
f8392c1d47 Shaper: add uuid to shaper rules, for https://github.com/opnsense/core/issues/3994 2020-03-20 19:39:39 +01:00
Ad Schellevis
fc5b8b9173 MVC: init errorMessage to prevent "Error at /usr/local/opnsense/mvc/app/library/OPNsense/Core/Backend.php:91 - Undefined variable: errorMessage (errno=8)" 2020-03-19 12:46:12 +01:00
Franco Fichtner
a73b211d0a mvc: header style in field types 2020-03-19 08:26:09 +01:00
Ad Schellevis
dba70c0ead Gateways: support interface targets (without addresses), but don't pinpoint it on specific drivers. for https://github.com/opnsense/core/pull/3983
Some tunnel interface types, such as Wireguard and Tinc do support sending traffic to the interface without an intermediate host. Since we don't want to add different static checks (and would like to get rid of the ones there for legacy reasons), it's probably better to add an option here.
2020-03-18 11:16:41 +01:00
Ad Schellevis
38c1b66cca Gateways: skip empty gateway_item tags, since &config_read_array('gateways', 'gateway_item') will always create one if gateways is empty (leading to an empty defunct entry in the gateway overview) 2020-03-18 10:20:01 +01:00
Ad Schellevis
67c0d0dcfd filter: diag_logs_filter_summary.php optionally support pid in log line filterlog: vs filterlog[XXX]: 2020-03-17 21:05:08 +01:00
Ad Schellevis
0ec7e1f804 dpinger: system_gateways_edit.php simplify validations, dpinger defaults and choosen settings are being overcomplicated here. should fix https://github.com/opnsense/core/pull/3989 2020-03-17 20:44:53 +01:00
Franco Fichtner
6b9865876a src: PSR12 style sweep 2020-03-18 07:43:01 +01:00
Franco Fichtner
dd4646e596 unbound: spacing 2020-03-18 07:34:08 +01:00
Ad Schellevis
599e17af76 filter/log: new filterlog seems to add pid as well.
old content:
Mar 17 18:19:01 OPNsense filterlog: ,,,,,
new content:
Mar 17 17:11:36 OPNsense filterlog[40511]: ,,,,

Use a regexp to match both in the log parser.
2020-03-17 18:20:18 +01:00
Franco Fichtner
e06e7aecea openvpn: make at least one string sane by moving "." into the string #3987
Scrape markup, it is generally bad style.
2020-03-17 17:42:29 +01:00
Ad Schellevis
1752d96a1f openvpn client: help texts swapped, closes https://github.com/opnsense/core/issues/3987 2020-03-17 17:34:16 +01:00
Ad Schellevis
4ec8d612f4 unbound: add lock to previous 2020-03-17 16:35:27 +01:00
Ad Schellevis
e559644fb7 unbound: wrap unbound startup + preparation into unbound_start.sh and move startup to background configd task 2020-03-17 16:16:49 +01:00
Ad Schellevis
1219969e83 fix previous 2020-03-17 14:03:25 +01:00
Ad Schellevis
0ea36d1a21 syslog: fix cda4e3561f
- sleep() expects an int, use usleep instead to wait 0.1 seconds
- bail if waiting longer than 5 seconds
2020-03-17 13:04:42 +01:00
Ad Schellevis
5dd129c967 OpenVPN: openvpn_port_used() using different logica than it would when doing the actual configuration (local setting). Align logic, closes https://github.com/opnsense/core/issues/3984 2020-03-17 09:58:52 +01:00
Ad Schellevis
41a5f37b4e IDPS: synchronize suricata.yaml with default template https://github.com/OISF/suricata/blob/suricata-5.0.2/suricata.yaml.in
Probably to be included in 20.7. This includes enabling more logging and parsers, our template has been unmodified for quite some time, while the upstream version was improved and better structured.
2020-03-16 18:42:23 +01:00
Franco Fichtner
b5493874b3 firmware: revoke 19.7 fingerprint and fix boot logo 2020-03-16 15:05:29 +01:00
Ad Schellevis
6276812309 MVC: logging, fixed with for timestamp column 2020-03-16 13:49:34 +01:00
Ad Schellevis
6b62ed4fe2 IDS: fix obsolete warning in suricata : [ERRCODE: SC_WARN_OPTION_OBSOLETE(233)] - netmap interface em1+ uses obsolete '+' notation. Using '^' instead. 2020-03-16 13:36:22 +01:00
Franco Fichtner
665c90fd66 config: install fingerprint for 20.7 2020-03-16 07:13:47 +01:00
Ad Schellevis
02e6e00c12 MVC: limit dropdown size to 10 is none specified, larger lists seem to overlap sometimes (data-size attribute in selectpicker) 2020-03-14 05:15:24 +01:00
Ad Schellevis
893f2a4af9 Firewall: prevent gateway protocol mismatch from breaking the ruleset. 2020-03-13 17:55:13 +01:00