We do this for different reasons, but mainly for code maintenance
and simplicity. It also fixes a few aquire/display bugs with
overlapping linl-local VIPs across interfaces, but not all.
* dnsmasq: Implement a light validation for option6 values as they require to be wrapped inside square brackets if they contain an IPv6 address
* dnsmasq: Improve the IPv6 bracket check, also handle multiple ipv6 addresses that are comma separated, use isIpv6Address()
* dnsmasq: Put IPv6 value check inline since dhcp-match and dhcp-option have been unified in master.
* Update src/opnsense/mvc/app/models/OPNsense/Dnsmasq/Dnsmasq.php
Co-authored-by: Ad Schellevis <AdSchellevis@users.noreply.github.com>
* Update src/opnsense/mvc/app/models/OPNsense/Dnsmasq/Dnsmasq.php
Co-authored-by: Ad Schellevis <AdSchellevis@users.noreply.github.com>
* dnsmasq: trim value directly
---------
Co-authored-by: Ad Schellevis <AdSchellevis@users.noreply.github.com>
The length and input isn't bound but when writing resolv.conf
we will adhere to the requirement mentioned in the man page:
The search list is currently limited to six domains
with a total of 256 characters.
We simply don't always know how many the system was being provided
with from the ISP so it is what it is.
This reverts commit de5dd5f5278edbae14bfa1bc76751ae360b834e0.
table-layout: auto; seems to do more harm than good, while originally
intended to improve out-of-bounds table row situations, it proves
to cause the same issue for long cell content as it now
ignores overflow:ellipsis.
* dnsmasq: Unify dhcp-option and dhcp-match in the same grid
Both dhcp-option and dhcp-match use almost the same fields in the form and concern the same options.
Unifying them could make sense to remove some duplicate code and potentially improving the UX.
* make plist and remove console log debug statement
In order to support both formats, we should break with the first succesful compile().
A workaround in the current version is to omit the {.} in the path expression.
This commit adds a toggle which skips config file generation for kea-dhcp4.conf and lets the user handle it manuallt, service startup and control stays in place while manually configured.
When manual mode is selected, all other options will be hidden in the form, which should help people understand (and read) what the purpose of this toggle is (advanced mode).
Unfortunately we can't prevent all overlaps, but at least we cab make it consistent with the rules being generated. loadAliasMap() overlays aliases on top of networks (and interface groups), swapping the order makes sure we thread them equally.
We could move the check to backend() at the risk of breaking firmware upgrades on
errors. Breaking the auto-check seems like the lesser evil.
In reality you can always go back to the status tab and re-create the issue by
clicking check for updates again after already having it clicked. That is why the
page actually switches to the updates tab on click. The update click is also delayed
to give the status call to fill the status tab first which immitates a normal page
render.
The issue actually appears because:
1. Backend options are detached and are dispatched, but since they run in the backround
we don't return any feedback because we don't have it. This then...
2. ... creates a parallel chain of trackStatus() calls which eventually reports the same
modal.
The issue only appears when no updates are found or triggering a separate error modal.
When updates are found this is handled gracefully.
Making the modals and errors static seems like overkill as well.
Keeping friction and magic out of this page is important too.
* dnsmasq: Add full dhcp-host support for IPv4 and IPv6
* dnsmasq: Cleanup previous in dnsmasq.inc
* dnsmasq: Change comma placement in template to reduce one condition
* dnsmasq: Add validation to client_id
* dnsmasq: There can be multiple hardware addresses so change label accordingly
* dnsmasq: Change hostname validation so that client_id is also a valid choice without hostname defined.
* dnsmasq: Add validation that prevents duplicate IP addresses in dhcp-host set
* remove one stray newline
* Services: Dnsmasq DNS & DHCP - minor cleanups in https://github.com/opnsense/core/pull/8497
o fix possible race condition in validations
o simplify jinja template
---------
Co-authored-by: Ad Schellevis <ad@opnsense.org>
Some may argue the hidden commands are not good, but they are really
only to be intended to be called upon request. None of these things
magically fix firmware updates on their own, but can be useful (and
copying console output into the forum can also be more difficult).
* dnsmasq: Add filter function for interfaces and tags with multiselect
* dnsmasq: Small cleanup in filter selectpicker previous
* Refactor search actions and tag filtering
- Use single helper function for building filter
- Use tag UUIDs instead of names for filtering
- Avoid building filter functions when filters are empty
- Pass null to searchBase() when no filtering is required
- Use UUID-based filtering for dhcp_tags via record attributes
* dnsmasq: Make tags and interfaces dropdown just a tad nicer
* Services: Dnsmasq DNS & DHCP - cleanups for https://github.com/opnsense/core/pull/8465
simplify recurring pattern for tag search and move select options generation into common jquery function.
---------
Co-authored-by: Ad Schellevis <ad@opnsense.org>
* dnsmasq: Require interface when ra_mode is selected due to ra-param interface requirement. Hide ra-param in dialog when ra_mode is default, since then the global enable_ra defaults are used instead.
* Update src/opnsense/mvc/app/controllers/OPNsense/Dnsmasq/forms/dialogDHCPrange.xml
Co-authored-by: Franco Fichtner <franco@opnsense.org>
* Update src/opnsense/mvc/app/models/OPNsense/Dnsmasq/Dnsmasq.php
Co-authored-by: Franco Fichtner <franco@opnsense.org>
* Update src/opnsense/mvc/app/views/OPNsense/Dnsmasq/settings.volt
Co-authored-by: Franco Fichtner <franco@opnsense.org>
---------
Co-authored-by: Franco Fichtner <franco@opnsense.org>
* Display OpenVPN virtual IPv6 addresses for OpenVPN clients
* Check for virtual IPv6 address
* Filtering client vars and join them
* Revert "Filtering client vars and join them"
This reverts commit 8914b39d82ebc50656884172c290d8e8db7a1137.
* Moved logic
* Revert "Moved logic"
This reverts commit c66182871031c64d938bc70bf4d0c57f00634c28.
* Moved ip address list logic
---------
Co-authored-by: lucaspalomodevelop <lucas.palomo@t-online.de>
