13212 Commits

Author SHA1 Message Date
kulikov-a
7e8ac1eb59
certs: misleading message (#6004) 2022-09-06 12:36:58 +02:00
Stephan de Wit
96229a2e23 traffic widget: fix missing tooltip 2022-09-06 09:36:11 +02:00
Ad Schellevis
9606957ef8 System: Trust: Revocation - phpseclib3 UnsupportedAlgorithmException() issue.
According to the notes in https://phpseclib.com/docs/x509 the signCRL() method previously set the signatureAlgorithm by default (sha1WithRSAEncryption), without specific request we now seem to be using SIGNATURE_PSS by default.

```
Note that whereas in the 1.0 and 2.0 branches, the signature algorithm was set by using an additional parameter in the sign method (or signCSR, signCRL, etc) in this case it's set based on the key. So if you want to create an rsaEncryption X509 cert you'd need to do $publicKey = $publicKey->withHashing(RSA::SIGNATURE_PKCS1) since, by default, RSA keys use RSA::SIGNATURE_PSS.
```

This commit implements the suggested approach to revert the default hashing back to what it was, which at least generates CRL's and is properly handled in validateSignature().

Most likely this fixes https://forum.opnsense.org/index.php?topic=30164.msg145633#msg145633

cc @swhite2
2022-09-04 15:13:29 +02:00
Ad Schellevis
76fb91f071 System: Trust: Revocation - Consider dates after 2050 as lifetime in GeneralizedTime format (rfc5280#section-4.1.2.5) to prevent generating invalid certificates.
Our current default of 9999 days will calculate to a date in 2050, we could either choose to cap on 20491231 here or set to lifetime, the latter seems to be more logical when the number of days is higher than a couple of years.

fix a small php 8 notice as well in the same scope.

noted here https://forum.opnsense.org/index.php?topic=30164.msg145665#msg145665
2022-09-04 11:28:40 +02:00
Ad Schellevis
e1d8b471d0 Interfaces/Other Types/VLAN - pass proto to vlan interface for 802.1ad (QinQ) interface types.
Currently this doesn't work (yet), likely needs https://reviews.freebsd.org/D35848 so vlanproto can be set after the interface creation phase (now it's only possible to set proto there).
If `ifconfig XXXX vlanproto 802.1ad` sets the property, we do need this code to make sure we set these on QinQ parent vlan tags. As a workaround we could pass proto in legacy_interface_create() as well to make this (only) work on boot, but looking at the upstream fix, this might be something easy to pull in the near future.

for https://github.com/opnsense/core/issues/5893
2022-09-03 15:31:25 +02:00
Stephan de Wit
f6cebb421b phpseclib: also include version 3 in certmanager for CSR parsing 2022-09-02 11:15:46 +02:00
Franco Fichtner
1f567a418a interfaces: ipfw(8) explains that ipfw0 is a logging device 2022-09-02 09:54:50 +02:00
Franco Fichtner
111540815d system: give autoloader a chance to try and load it 2022-09-01 20:08:25 +02:00
Ad Schellevis
fc46a52682 certs.inc - safeguard phpseclib3 loading in crl_update() 2022-09-01 17:24:44 +02:00
Ad Schellevis
3b39e2d1f6 OpenVPN / CRL - trap validateSignature() exceptions to syslog 2022-09-01 16:46:21 +02:00
Franco Fichtner
08e39cb0df src: style sweep 2022-09-01 12:41:26 +02:00
Ad Schellevis
006d79521f Interfaces / Traffic capture - help text fix in https://github.com/opnsense/core/issues/5981 2022-09-01 10:56:16 +02:00
Stephan de Wit
cc6efa4a16
Reporting / Traffic: Upgrade chart.js to v3.9.1 and improve UX (#6000)
* Reporting / Traffic: Bump chart.js version and improve UX
2022-09-01 10:21:15 +02:00
Franco Fichtner
8cb79d511b interfaces: fix warning in PHP 8
'group' property not set when parsing, likely also happens for 'remote'.
2022-08-31 20:50:22 +02:00
Franco Fichtner
7607a6d968 system: for consistency add -c argument (the default) to pluginctl invokes
Some facilities might overlap in naming so make it less confusing from
the internal scripting side. "webproxy" had me doubting for a second.
2022-08-31 09:19:01 +02:00
Franco Fichtner
c1ff59ea02 system: users might miss this so put it back
rc.resolv_conf_generate like most rc.* scripting magic should
eventually go way.
2022-08-31 09:05:07 +02:00
Franco Fichtner
683747ddb3 src: style sweep 2022-08-30 21:31:32 +02:00
Ad Schellevis
d8bf03d2e9 Interfaces/Diagnostics/Packet Capture - replace legacy version with new mvc variant. closes ehttps://github.com/opnsense/core/issues/5981 2022-08-30 17:35:45 +02:00
Franco Fichtner
5eb4ac6143 interaces: killed wrong note 2022-08-30 15:35:51 +02:00
Franco Fichtner
2f1a92c075 interfaces: interfaces_hardware() for interface settings page 2022-08-30 15:31:14 +02:00
Patrik Kernstock
07e684310d
ipsec: fixed widget link (#5994) 2022-08-30 15:18:33 +02:00
Franco Fichtner
a9c514d857 interfaces: we split on numeric ID so we have to give full prefix 2022-08-30 08:54:17 +02:00
Franco Fichtner
e82896026c system: tweak validation message 2022-08-30 08:49:49 +02:00
Franco Fichtner
366b7161f2 src: style sweep 2022-08-30 08:45:47 +02:00
Ad Schellevis
4070ad0e2e Interfaces/Diagnostics/Packet Capture - work in progress for https://github.com/opnsense/core/issues/5981
o host field logic validator
o add remove job action
o add view action (initial version)
2022-08-29 21:16:49 +02:00
Franco Fichtner
87b3d351ab dnsmasq: restart durng newwanip event
PR: https://forum.opnsense.org/index.php?topic=29956.0
2022-08-29 11:20:29 +02:00
Franco Fichtner
b114ed0125 interfaces: clear some removed devices
About _stf move it back to pattern in order to automate some of
this pattern stuff later.  Something like 'carp' or 'plip' etc.
might move to core definition as well since these are basic interfaces
we do not want to expose.
2022-08-29 10:08:24 +02:00
Franco Fichtner
46514ec7d5 interfaces: finally move plugin defintions to plugins 2022-08-29 09:43:32 +02:00
Franco Fichtner
2a3aaf9e06 interfaces: convert lagg and simplify assignment page
list_devices() shouldn't change in the way it's generated
pre- or post-write so just us a pre-write invoke to get the
list of assignable devices.

Not completely true for weird WLAN case with the parent
assignment but sooner or later we will be able to get rid
of that as well.
2022-08-29 09:36:52 +02:00
Franco Fichtner
e557ab6372 interfaces: move ppp assignments 2022-08-29 09:06:38 +02:00
Franco Fichtner
56f8bae72a interfaces: convert vlan assignments 2022-08-29 08:44:28 +02:00
Franco Fichtner
b9bdf760b8 interfaces: 'sections' are arcane now, simplify to type tag 2022-08-29 08:38:27 +02:00
Franco Fichtner
d095546dcb interfaces: convert openvpn assignments 2022-08-29 08:27:10 +02:00
Franco Fichtner
b22c205970 ipsec: pattern was already registered above 2022-08-29 08:14:04 +02:00
Franco Fichtner
494437c1b8 interfaces: convert vxlan 2022-08-29 08:12:44 +02:00
Franco Fichtner
6f91dc4683 interfaces: finish wireless/wlan rework #5987
* Devices are now configured inline or directly via pluginctl
* Try to use "wlan" underneath as shorter and upstream term
2022-08-29 07:46:31 +02:00
Franco Fichtner
471ae4b6bd interfaces: protect against calling missing reconfiguration 2022-08-29 07:46:26 +02:00
Franco Fichtner
84f0544af3 interfaces: pluggable assignments for gif/gre 2022-08-28 21:03:41 +02:00
Franco Fichtner
ffefc81cfe src: style sweep 2022-08-28 21:03:13 +02:00
Ad Schellevis
2941b4eb14 Interfaces/Diagnostics/Packet Capture - add frontend options for https://github.com/opnsense/core/issues/5981 2022-08-28 20:06:07 +02:00
Ad Schellevis
21232cc4bd Interfaces/Diagnostics/Packet Capture - boilerplace for https://github.com/opnsense/core/issues/5981
o add basic workflow (start/stop/list)
o basic configd actions + implementation in capture.py script
o grid without actions to show current capture jobs
2022-08-28 15:45:42 +02:00
Franco Fichtner
6738e5fa9e interfaces: bridges to pluggable assignments
Should all be taken care of in a morning with equal amounts
of coffee.
2022-08-28 14:30:44 +02:00
Franco Fichtner
b386e61d82 interfaces: convert ipsec devices
Removes them from get_interface_list() and shows their description
on the assignments page.  It's already in the interface name but
we should adhere to consistency in the select box.
2022-08-28 14:18:58 +02:00
Franco Fichtner
394d8e10f5 interfaces: flip 'names' arrays to merge 'assign' data
We can assign these from here when the name value is not null.
2022-08-28 13:44:48 +02:00
Franco Fichtner
9b2455c8ab interfaces: same for loopback 2022-08-28 13:28:58 +02:00
Franco Fichtner
64222bc06f interfaces: merge assign and names array contents
We only need one of them eventually.
2022-08-28 13:26:34 +02:00
Franco Fichtner
6a2f428e79 system: style sweep 2022-08-28 13:26:15 +02:00
Ad Schellevis
bf11949841 Interfaces/Diagnostics/Packet Capture - boilerplace for https://github.com/opnsense/core/issues/5981 2022-08-27 16:16:45 +02:00
kulikov-a
840ddc52f7
GUI: match cipher suites and commands (#5993) 2022-08-27 15:06:39 +02:00
Ad Schellevis
244cd1f040 rrd - fix php notice 'Warning: Undefined array key "description" in /usr/local/etc/inc/rrd.inc on line 132' 2022-08-27 14:50:39 +02:00