4781 Commits

Author SHA1 Message Date
Franco Fichtner
d2e7cbade5 system: improve debugging capability of dns static routes
We are progressing steadly here, but now we need more visibility
of the sources of DNS routes to summarize servers and sources.

Also try not to deduplicate routes prematurely so that dynamic
hosts get priority over config-based ones like the override
setting actually implies as currently the last one won.
2022-08-18 08:44:44 +02:00
Franco Fichtner
98b65dd8a0 system: lighttpd 1.4.66 config removal
WARNING: unknown config-key: server.dir-listing (ignored)
2022-08-17 14:46:22 +02:00
kulikov-a
3c53058805
crl management small adjustments (#5943)
add some debug info
dont add cert to crl if cert_revoke() / crl_update() failed
check if CA can sign anything before CRL create
set "method" param to set Method select value
2022-08-17 11:32:15 +02:00
Franco Fichtner
29e6e12d7c system: deal with ifctl internals for now #5933
Later we want ifctl to add the scope to the link-local gateway
by default which will remove a more code, but for now we are
bound to undo the internal magic.

Interface name stops with first ":" or last "_".  For the exclude
check use the correct array index, not the array itself.
2022-08-17 07:37:56 +02:00
Stephan de Wit
92a5a224dd
unbound: restrict creation of PTR records for both the system domain and host overrides (#5925)
In order to prevent the unpredictable behaviour of random PTR records being returned, which is not explicitly prohibited in RFC1035, it is best to restrict the creation of PTR records from every single host and alias (except for wildcard entries, no PTR records are created here), to only non-alias overrides (edit: the exception here is an alias whose parent does not create a PTR record, a wildcard entry). We also further restrict it to unique IP addresses so there can be no confusion in how to maintain the entries within the running Unbound instance.

Hopefully this can pave the way for adding PTR records as a separate type instead of generating them under the hood, as is done currently.

This change should at least address inconsistencies regarding random PTR records being returned as mentioned in https://github.com/opnsense/core/issues/5477

A slight refactor of the existing unbound code is also included here for code reduction purposes.
2022-08-16 13:51:58 +02:00
Franco Fichtner
539ae27af0 interfaces: update link-local matching pattern
In some instances a suboptimal pattern was used missing several
networks included in the actual fe80::/10.  The reference is
is_linklocal() function nowadays.  Sync all patterns.
2022-08-16 08:03:50 +02:00
Franco Fichtner
45b8b1acbe interfaces: fix typo in previous 2022-08-15 14:01:15 +02:00
Franco Fichtner
489ae2f3c6 interfaces: DHCP is our problem child #5933 2022-08-15 13:20:41 +02:00
Franco Fichtner
e6ef454fa8 interfaces: signal address flush through rc.newwanip #5933 2022-08-15 12:14:48 +02:00
Franco Fichtner
b58b7fed26 interfaces: align rc.newwanip with rc.newwanipv6, step one
PR: #5956 #5933
2022-08-15 11:57:00 +02:00
Franco Fichtner
46ca0aff06 interfaces: static handling is the same as dynamic
Tiptoeing around interface_configure() when the resulting
work is the same is counter-intuitive and the static ARP
case probably has some more side effects since we do not
check for static ARP flag?!

filter_configure() can take a long time.  Skip alias stuff.
2022-08-15 11:49:02 +02:00
Franco Fichtner
8b35e96395 interfaces: only remove static addresses in interface_bring_down() #5953
Seems to be more aligned with the original idea behind the function.
interface_configure() does clear any stray addresses afterwards anyway.
2022-08-15 10:09:35 +02:00
Franco Fichtner
6b8cfcb142 rc: _var_script support to be removed in favour of _setup 2022-08-12 13:11:29 +02:00
Franco Fichtner
72b04f0904 interfaces: fix interface name split for ifctl; closes #5929
Weird stuff such as "wififoo_wlan0" is now properly handled.
2022-08-12 12:07:42 +02:00
Franco Fichtner
85b223d00c interfaces: improve banner address return
primary will move to tracking interfaces or pick up any
SLAAC related address even though that is not being
actively configured.  Similar to the dashboard only print
the scoped address without the need to do the logic in
the caller.

Maybe we could even return the assigned prefix here for
clarity, but then the prefix isn't a reachable address.
2022-08-12 10:07:14 +02:00
Maurice Walker
6fb821666b dhcpd6: allow rapid-commit message exchange 2022-08-12 08:53:58 +02:00
Franco Fichtner
4bc0871c99 unbound: reduce code size a little #5944 2022-08-11 15:25:29 +02:00
Maurice Walker
98410aeede Unbound: add AAAA-only mode to config
Allows removing all A records from responses.
2022-08-11 15:08:12 +02:00
Franco Fichtner
e6d53a4f8e interfaces: employ gre trick here for gif as well
Also try to pin 128 bit net to use that immediately as the
configuration is already correct.
2022-08-11 14:29:19 +02:00
Franco Fichtner
6043b5b125 interfaces: make rc.newwanip the same as "dns reload"... #5933
... a.k.a. rc.resolv_conf_generate.  While here protect more
code with the IP change guard and clear the IP address if the
address lookup came up empty.
2022-08-11 13:53:04 +02:00
Franco Fichtner
d9609ec86a rc: move log message #5933 2022-08-11 13:31:13 +02:00
Franco Fichtner
475cb8ec7f interfaces: deal with problematic <wireless/> handling #5939
The wireless code "integration" is horrible even by moderate standards
in our code base.  In the future the best way would be to ditch all of
it and rebuild (parts) required by users.
2022-08-11 11:16:40 +02:00
Franco Fichtner
5fd1f962b3 dhcp: for better config structure 2022-08-11 09:34:29 +02:00
Franco Fichtner
4f21af48ef dhcp: cleanups 2022-08-11 08:55:41 +02:00
Franco Fichtner
85373c724d dhcp: pushed wrong servers to zone definition #5942 2022-08-11 08:55:41 +02:00
Franco Fichtner
47bff6840d system: console wireless assignment mismatch
Some code tries to do this on the fly but newer code does not
(and should not).

PR: https://forum.opnsense.org/index.php?topic=29559.0
2022-08-09 13:09:20 +02:00
Franco Fichtner
0b29f71cb1 interfaces: merge INFOREQ|REQUEST handling #5862
PDINFO should not be set and therefore only gets cleared.
2022-08-08 14:43:28 +02:00
Maurice Walker
f2c844e170
SLAAC WAN: add support for requesting DNS info via stateless DHCPv6 (#5937)
* Merge SLAAC interface dhcp6c config

Stateless DHCPv6 config for SLAAC WANs was generated, but not merged into dhcp6c.conf file.

* Add support for stateless DHCPv6 to dhcp6c script

Script had no code for processing stateless DHCPv6 replies (required for SLAAC without RDNSS / DNSSL).

* dhcp6c script, pass all search domains to ifctl

Only the first domain was used, all others were disregarded.
2022-08-08 14:41:42 +02:00
Franco Fichtner
e688d3b6fa firmware: revoke 22.1 fingerprint 2022-08-08 11:17:38 +02:00
Franco Fichtner
f8fdc8deac src: style sweep 2022-08-08 10:47:56 +02:00
Ad Schellevis
edcc29ab5c filter - cleanup some php8 warnings 2022-08-01 16:56:28 +02:00
Franco Fichtner
e5006e9e44 interfaces: bring routes back after reconfiguring IPv6 connectivity
PR: https://forum.opnsense.org/index.php?topic=29698.0
2022-08-05 11:00:05 +02:00
Franco Fichtner
d68d50caeb system: cosmetic newline at end of CRL text 2022-08-05 09:57:09 +02:00
Ad Schellevis
c903218cd8 authgui.inc -- remove old cruft, nohttpreferercheck is handled in check_security_http_referer_enforcement() which already bails via session_auth() 2022-08-01 06:21:39 +02:00
Franco Fichtner
d19cd6cdbf interfaces: get_interface_mac() not returning cached MAC result
Looks like this went unnoticed since 22.1.2.

PR: https://forum.opnsense.org/index.php?topic=29691.0
2022-08-04 23:39:46 +02:00
Franco Fichtner
83c1ce1b6f interfaces: fix warning 2022-08-04 22:39:39 +02:00
Franco Fichtner
d69ff4a16a interfaces: figure out point-to-point or subnet setup
PR: https://forum.opnsense.org/index.php?topic=29654.0
2022-08-04 22:25:56 +02:00
Franco Fichtner
e1e8abc03e rc: 750 for root fixup; closes #5475 2022-08-04 10:09:30 +02:00
Franco Fichtner
92cd0745e1 firewall: undefined key warning 2022-08-04 09:17:59 +02:00
Franco Fichtner
889420b652 interfaces: style update on GIF/GRE code
If we want to extend the feature here make room so we
don't have to deal with a single string concatenation.

Also disabled IPv6 inside GIF IPv4 tunnel.

PR: https://forum.opnsense.org/index.php?topic=29654.0
2022-08-04 08:53:14 +02:00
Franco Fichtner
9c6e5f0cfb dhcp: fix undefined key warnings 2022-08-04 08:51:54 +02:00
Franco Fichtner
abffe29b21 unbound: fix two undefined key warnings 2022-08-04 08:51:19 +02:00
Franco Fichtner
e76f15c357 system: refactor logic and populate hosts file a bit more
Already noticed that "ipsec" devices were throwing wrenches into
the engine here so try to match exactly on the pseudo-interface
names given by the GUI.
2022-08-03 09:06:20 +02:00
Franco Fichtner
b504bc8763 dhcp: extend search list pull from DHCPv6 and refactor #5919 2022-08-02 12:31:56 +02:00
Patrick M. Hausen
b319b1284f core/radvd - do not advertise DNS domain when DNS advertisments are disabled 2022-08-02 12:12:40 +02:00
Stephan de Wit
966e54011e
unbound: do not start DHCP watcher immediately after daemonizing unbound (#5920) 2022-08-02 10:33:59 +02:00
Stephan
2918f0e24e trust: use proper CRL id-ce-cRLReasons extension keyword 'unspecified' 2022-08-02 08:39:55 +02:00
Franco Fichtner
7aaa6a263b system: do not reload unbound/dnsmasq "hosts" by default
Number of people noted spurious restarts of Unbound and this seems
to be the cause.  However, the real cause of hammering rc.newwanip
is in 797c18641944 and to avoid other side effects like the GIF/GRE
stuff we should consider reverting part of it.
2022-08-02 08:22:26 +02:00
Franco Fichtner
8974c4661a dhcp: fix undefined key warning 2022-08-01 13:52:23 +02:00
Franco Fichtner
f9ea49ae31 interfaces: manual cache invalidate for previous
Purge the file on all known dynamic spots that run a deconfigure
of some sort.  We probably need something for a forced reload as
well but for now let's see if this works in general.
2022-08-01 13:45:18 +02:00