Franco Fichtner
6ff74b9511
interfaces: remove previously broken code
...
Since the code was only fixed in 024c7e1694 and the lookup is
questionable (especially on IPv4 real interface which is vanilla
as opposed to PPP IPv6 shifting).
The problem with e.g. a wan: pppoe0 -> em1 situation is that
if you assign em1 the answer to the query shifts from "wan" to
"opt1" so we would rather miss the situation to resolve "em1"
since the correct interface is "pppoe0" anyway.
Also looking at callers of convert_real_interface_to_friendly_interface_name()
there isn't a PPP-related call in there anyway that would require
this.
2021-12-06 17:10:51 +01:00
Franco Fichtner
88bc06006f
interfaces: restrict vlan selection
...
None of these support VLANs on top.
2021-12-06 15:42:49 +01:00
Franco Fichtner
1aee1b16c6
interfaces: whitespace again
2021-12-06 15:18:19 +01:00
Franco Fichtner
550f5e35b3
interafces: patch in parent devices for LAGG and bridge
2021-12-06 15:00:18 +01:00
Franco Fichtner
8578bd35a6
interfaces: split get_parent_interface() into its use cases
...
* Make it only react to PPP related lookups, no generic fallback
* Move the VLAN portion to a simplified dedicated function
* As a placeholder we shall see if bridges and LAGGs benefit from it
2021-12-06 14:37:10 +01:00
Franco Fichtner
024c7e1694
interfaces: return $ifname and decouple the search loop
...
This looks like a typo in the original code as we expect to return
a "wan|lan|optx" thingy.
"Parent" lookup isn't really very useful except for PPP types.
The question is if there is an edge case that would still allow
this to resolve when the other code preceeding it can not.
2021-12-06 14:05:22 +01:00
Franco Fichtner
351295ecba
interfaces: configure_interface_hardware() can take previous details
2021-12-06 13:48:52 +01:00
Ad Schellevis
6b29cc356b
configd - internal profiler fix incorrect enable call (probably a python 3 remnant)
2021-12-06 08:28:00 +01:00
Ad Schellevis
ce656d076b
Firewall / Aliases - add "Dynamic IPv6 Host" type. closes https://github.com/opnsense/core/issues/4923
2021-12-02 21:23:25 +01:00
Franco Fichtner
cc443a7061
dhcp: rewrite conditionals to adapt to configured reality
...
The trigger was filename + filename32 + filename64 which probably
doesn't work very well for newly added ARM types. Instead write
the conditional architectures as they are filled in. The GUI
certainly doesn't make any restrictions and I believe neiter does
isc-dhcp.
While here polish the GUI labels a little to make the requirements
clearer.
Apparently, Charlie Root was in a hurry when introducing this
back in 2014: https://github.com/pfsense/pfsense/commit/7023c602b
2021-12-01 13:39:48 +01:00
Ad Schellevis
cee094aa61
MVC - Models : improve error handling for missing fieldtype classes
2021-12-01 11:41:00 +01:00
Keith Cirkel
130b274b6c
Services / DHCPv4 - Allow for ARM architectures in DHCP Network Boot options ( #5361 )
2021-11-30 20:11:05 +01:00
Ad Schellevis
9f3b6e873a
IDPS - update classification.config with https://raw.githubusercontent.com/OISF/suricata/master/etc/classification.config
...
closes https://github.com/opnsense/core/issues/5384
2021-11-30 18:30:19 +01:00
Franco Fichtner
b6ffe6fa17
interfaces: just for fun
2021-11-29 12:05:09 +01:00
Franco Fichtner
f8757b441b
interfaces: put a fancy newline
2021-11-29 11:41:50 +01:00
Franco Fichtner
d1f942af64
intefaces: simplify this one as well #5367
2021-11-29 10:57:45 +01:00
Franco Fichtner
6704426c19
interfaces: repair getenv() breakage in ea6b5bda52409 the right way #5367
...
Moral of the story: don't try to call backend scripts to grab env
variables that you could easily read using the acual nameserver
script sort of like dhclient-script is doing it.
ALLOWOVERRIDE is silly as we guard against that in get_nameservers().
2021-11-29 10:57:40 +01:00
Franco Fichtner
08df2b0255
interfaces: align file names #5367
2021-11-29 07:37:29 +01:00
kulikov-a
bde62fc806
Firewall / Diagnostics / Sessions - typo in direction ( #5378 )
2021-11-28 16:48:17 +01:00
kulikov-a
c898111c6e
Firewall / Diagnostics / States - switch dst-src with direction ( #5377 )
2021-11-28 15:41:07 +01:00
Franco Fichtner
fa184ba539
interfaces: fix previous
2021-11-28 14:16:22 +01:00
Franco Fichtner
7cad3b63ae
interfaces: transform to heredoc for easier extension #5367
...
Yes we need to add a template but for let's try baby steps and
get the nameserver/searchdomain stuff right first. :)
2021-11-28 14:11:23 +01:00
Franco Fichtner
b28fa22d69
interfaces: nameserver can use same file format as others #5367
...
Also decouple searchdomain write from nameserver write in dhclient-script
and clear files properly.
2021-11-28 13:52:52 +01:00
Franco Fichtner
c6c7e9854d
interfaces: searchdomain can use same file format as others #5367
...
Other directory was slightly confusing, other name even more so.
2021-11-28 13:42:38 +01:00
Franco Fichtner
99a0f1a164
interfaces: move nameserver files to /tmp #5367
2021-11-28 13:37:41 +01:00
Franco Fichtner
cc0b1b3be9
interfaces: move searchdomain files to /tmp #5367
2021-11-28 13:25:37 +01:00
Franco Fichtner
713e2469cb
interfaces: move "cache" file to /tmp and rename for clarity #5367
...
Not sure about the name but since we move it we might as well
try to make the name more descriptive. In /tmp we don't have
to clear stuff on bootup.
2021-11-28 13:15:42 +01:00
Franco Fichtner
ec3f62840a
interfaces: wait a second, if $ip_file is never read remove it #5367
...
Stranger things have happened...
2021-11-27 13:56:09 +01:00
Franco Fichtner
49210b3da8
interfaces: rc.newwanip(v6) changes related to #5367
...
o Only operate the /var/db IP files via rc.newwanip(v6)
o Consistenly flush a cache IP on a triggered reload
o Remove IPv6 address removal workaround from https://redmine.pfsense.org/issues/2627
o Assume that IP is properly checked making $cacheip != $ip a valid assumption when $cacheip is empty
o Remove creation from dhclient script
2021-11-27 13:54:06 +01:00
Franco Fichtner
aa6ffc501d
interfaces: these ip files under /tmp are not being used #5367
2021-11-27 13:21:57 +01:00
Franco Fichtner
63f92e9d4c
interfaces: remove code that appears uncessary
...
States are not bound to routers and -i combo doesn't seem to
work very well either.
2021-11-26 12:35:52 +01:00
Franco Fichtner
bc0f921113
Revert "interfaces: use same approach as ppp-linkup script #5367 "
...
This reverts commit a8522b7243e6b0fe76c91ccf52a9128d5fa9d0f6.
2021-11-26 12:12:21 +01:00
Franco Fichtner
a8522b7243
interfaces: use same approach as ppp-linkup script #5367
2021-11-26 10:27:35 +01:00
Ad Schellevis
2cfd70b7eb
System: High Availability - optionally disconnect dailup interfaces when going into CARP backup mode. while here reformat the HA section a bit as state sync is only part of the options. closes https://github.com/opnsense/core/issues/3185
2021-11-24 20:05:46 +01:00
Franco Fichtner
ef551570e8
src: spacing on html inputs
2021-11-24 12:47:03 +01:00
Franco Fichtner
319ad1cac2
system: cron template whitespace adjustments
2021-11-24 10:27:16 +01:00
Ad Schellevis
e6f9b9a388
Interfaces - remove validation preventing an interface to be enabled when aliases are already assigned (introduced in 62a4abc92c), there doesn't seem to be a valid reason for requiring no aliases
2021-11-23 19:20:08 +01:00
Franco Fichtner
767d814636
interfaces: on a device node there is no parent to use
...
Seems to have been in the code for a while. dhcp6usev4iface should
have probably been the default all along since otherwise this seeps
into the default mode on IPv6 causing it to fail.
2021-11-23 16:18:14 +01:00
Franco Fichtner
62e9191ad2
interfaces: style sweep
2021-11-23 13:58:37 +01:00
Franco Fichtner
028302ae74
interfaces: avoid touching cacheip files and improve state kill #5367
2021-11-23 13:13:25 +01:00
Franco Fichtner
671ebddbe9
system: escape opportunistic matchig to provide the fallback always
...
PR: https://forum.opnsense.org/index.php?topic=25599.0
2021-11-23 13:04:46 +01:00
Franco Fichtner
6f052c3cbd
system: on IPv4 monitor fallback use the full lookup
...
PR: https://forum.opnsense.org/index.php?topic=25599.0
2021-11-23 12:56:32 +01:00
Franco Fichtner
7ada19dd4c
interfaces: deal with PPP device nodes
...
Some mwexecf() sanity on the side and notes for further work.
PR: https://forum.opnsense.org/index.php?topic=25599.0
2021-11-23 11:14:31 +01:00
Franco Fichtner
19d89e0fd9
system: add a tiny manual page for opnsense-log
2021-11-23 09:20:40 +01:00
Franco Fichtner
0b75c0c0a8
interfaces: simplify get_parent_interface()
2021-11-23 08:47:14 +01:00
Franco Fichtner
63408df158
system: improve opnsense-log a little
2021-11-23 08:30:00 +01:00
Franco Fichtner
9c122803be
interfaces: flatten the call stack and unify logging
2021-11-23 08:14:18 +01:00
Franco Fichtner
4b44917198
LICENSE: sync after discussion with author
2021-11-22 15:13:50 +01:00
Franco Fichtner
7ee755df75
interfaces: bring back old name from c30477bef708fa02
...
Same same but different. Eventually we want to remove it.
2021-11-22 14:43:47 +01:00
Franco Fichtner
e72954234d
interfaces: improve newwanip logging a bit
2021-11-22 14:31:25 +01:00