60 Commits

Author SHA1 Message Date
Franco Fichtner
41ab7fb9f5 system: several improvements to tunables; closes #5504
o Merge defaults and requirements.
o Get rid of get_default_sysctl_value().
o Manually set 'type' for e.g. boot enviroment tunables.
o Cache sysctl map once per boot.
o Edit system defaults for easier override.

While sysctls might change when (un)loading kernel modules the
risk of missing something vital is not given.  We could always
flush the cache file in that case later.
2022-02-01 12:23:00 +01:00
Franco Fichtner
a8c6bd924d system: display system tunables as well
This sort of completes the previous effort to improve the
sysctl handling.  The idea to embed sysctls into the config.xml
is certainly valid, but for some values we needed more leeway
for system defaults and changing them over time, which lead
to this state where we can drop config.xml default tunables
since the system will now apply and display then for the same
visibility but offer less incentive to change these values.

One thing missing here is adding a system tunable override
(plus sign) for system values, but we shall deal with this later
because for now they can always be added manually by copy+paste.
2022-01-05 09:33:22 +01:00
Franco Fichtner
4778d1429b system: use sysctl info to indicate nonexistent ones
Also it seems that sysctl -ad returns sysctls that the kernel
considers sysctls with no value.  These are likely read-only
of some type so bring them in as well with a blank value.

Mark unsupported and read-only with text-danger since their
use is not doing anything for the system.
2021-10-26 10:26:07 +02:00
Franco Fichtner
1ddeeca108 system: assorted improvements
o Only modify default sysctls when default is known
o Let user know a default is not available for tunable
o Parse system descripton and type and show in GUI
2021-10-26 10:06:00 +02:00
Franco Fichtner
da94d72fda ui: remove $main_button use #4216 2021-06-14 16:03:26 +02:00
Franco Fichtner
10646e04c6 system: retain index after sort; closes #4697 2021-02-11 14:27:57 +01:00
Franco Fichtner
5463a34928 system: sort tunables, noticed while fidding with hw.uart.console 2021-01-26 17:01:06 +01:00
Franco Fichtner
9299386602 system: fix PHP loop fail in tunable
Maybe 7.2.23 is broken, never seen this before.  oO

PR: https://forum.opnsense.org/index.php?topic=14652.0
2019-10-14 09:23:29 +02:00
Franco Fichtner
79732b440e system: this is the right fix for #3676 ;) 2019-08-29 08:17:22 +02:00
Franco Fichtner
060f9edad7 system: fix translation order of tunables description; closes #3676 2019-08-29 08:08:56 +02:00
Northguy
ed785a6612 Cosmetic changes to Tunables section (#3665)
Moved to apply notice, as this is the place where it is logical to be notified you might need to reboot after applying a tuneable
2019-08-23 12:46:10 +02:00
Ad Schellevis
7738ac0bb9 system_advanced_sysctl.php, don't try to translate empty string. closes https://github.com/opnsense/core/issues/3578 2019-07-17 21:20:23 +02:00
Ad Schellevis
393b18e740 missing exit() in 2006837d18 2019-03-06 17:52:20 +01:00
Ad Schellevis
2006837d18 system tunables, allow reset sysctl to factory defaults. between versions our defaults may vary, this provides an easy option to just use the current defaults. 2019-02-13 10:02:03 +01:00
Ad Schellevis
4a8e737ced fix some gettext() + html_safe, discussed c4c7f8d732 2019-02-03 20:04:08 +01:00
Ad Schellevis
7ad7f55bca fix some escape issues in legacy code 2019-01-29 19:05:33 +01:00
Alexander Shursha
2896c69d0d Translate tunables. 2018-06-06 17:50:30 +02:00
Franco Fichtner
f33f527cf1 system: rework style in remaining pages #2440 2018-06-04 11:20:59 +00:00
Franco Fichtner
9e11911289 www: some final styling with feedback from @adschellevis 2018-03-26 09:28:20 +00:00
Franco Fichtner
e9c3be35d6 www: visual cleanups, unused class/style zapping #2290 2018-03-25 13:10:27 +00:00
Franco Fichtner
b074216e93 www: style updates, less strong/bold markup #2290 2018-03-25 10:08:53 +00:00
Franco Fichtner
c2c4a24618 system: apply loader tunables, style for apply box #2083 2018-03-14 09:31:30 +00:00
Franco Fichtner
fdf4eccfaa system: cosmetic tweaks for #2083 2018-03-12 20:51:04 +00:00
NOYB
6ef9a127ff HTML Compliance - Attribute "type" on Element <script>
Warning: The type attribute is unnecessary for JavaScript resources.

HTML5: Edition for Web Authors
http://www.w3.org/TR/2014/REC-html5-20141028/scripting-1.html
The default, which is used if the attribute is absent, is "text/javascript".

The Script element
https://developer.mozilla.org/en-US/docs/Web/HTML/Element/script
HTML5 specification urges authors to omit the attribute rather than provide a redundant MIME type.
2018-01-22 19:13:34 +01:00
NOYB
76aab5cb52 HTML Compliance - Obsolete table attributes
width, align, valign, cellpadding, cellspacing, border, summary

Error: The width attribute on the table element is obsolete. Use CSS instead.
Error: The align attribute on the table element is obsolete. Use CSS instead.
Error: The valign attribute on the table element is obsolete. Use CSS instead.
Error: The cellpadding attribute on the table element is obsolete. Use CSS instead.
Error: The cellspacing attribute on the table element is obsolete. Use CSS instead.
Error: The border attribute on the table element is obsolete. Use CSS instead.
Error: The summary attribute on the table element is obsolete. Consider describing the structure of the table in a caption element or in a figure element containing the table; or, simplify the structure of the table so that no description is needed.
2018-01-04 18:26:02 +01:00
Franco Fichtner
398a335179 system: do not wrap action buttons 2017-12-29 15:31:10 +01:00
Franco Fichtner
c5d4002541 src: add Scott's e-mail everywhere 2017-08-05 20:57:29 +02:00
Franco Fichtner
d87c6ff556 Scripts: add a license generator for GitHub 2017-08-05 20:21:35 +02:00
Ad Schellevis
69510a5fad legacy ui pages cleanup for https://github.com/opnsense/core/issues/1733 2017-07-22 15:01:26 +02:00
Ad Schellevis
52b95b80c0 (legacy) cancel button behaviour, closes https://github.com/opnsense/core/issues/1099 2016-12-12 21:34:03 +01:00
Franco Fichtner
88aab655a4 rc: further boot rework 2016-11-29 08:06:07 +01:00
Franco Fichtner
c5ab052b67 system: url_safe() for #1168 2016-10-11 08:11:12 +02:00
Fabian Franz
8028daeee4 whitespace cleanup 2016-05-21 12:33:56 +02:00
Ad Schellevis
7ab0b3463f (legacy) www: strip action attribute from forms where not needed, closes https://github.com/opnsense/core/issues/929 2016-05-12 19:45:28 +02:00
Manuel Faux
cea23f8cae UX: moved tooltip position to top for most tooltips 2016-01-10 12:06:48 +01:00
Manuel Faux
87014246c0 UX: changed delete icon from "X" to "trash" 2016-01-10 12:06:48 +01:00
Fabian Franz
1d0f083d96 change dialog style 2015-12-31 18:00:31 +01:00
Franco Fichtner
d41b5a7456 src: reindent copyright block to four spaces 2015-12-29 20:22:41 +01:00
Ad Schellevis
4a674804a4 (legacy) refactor system_advanced_sysctl.php 2015-12-08 16:25:54 +01:00
Franco Fichtner
166c571b5e www: another batch for #461 2015-12-05 08:24:21 +01:00
Ad Schellevis
c975897d6e (legacy) remove redirectHeader, closes https://github.com/opnsense/core/issues/470 2015-12-01 19:34:55 +00:00
Ad Schellevis
3fcda5715d (legacy) remove isAjax 2015-11-22 19:03:18 +00:00
Ad Schellevis
f8b281e9bf (legacy) remove isAjax() 2015-11-22 17:02:51 +00:00
Franco Fichtner
7f75ddb851 www: eradiacate print_info_box_np() for #444 2015-10-31 23:35:17 +01:00
Franco Fichtner
6948906adf menu: convert settings tabs to submenu; closes #402 2015-09-26 09:00:49 +02:00
Ad Schellevis
a7ac26237f (legacy) remove unused parameter in get_std_save_message 2015-08-17 08:27:34 +00:00
Ad Schellevis
cbcf5927ca (legacy) more dependency moves, slowly pouring functions.inc empty.... 2015-07-22 13:08:05 +00:00
Ad Schellevis
7418af459b (legacy) add additional check on $input_errors as part of cleanup notices 2015-07-06 16:58:36 +00:00
Ad Schellevis
ba800ae6c8 (legacy) fix check on $savemsg and $input_errors 2015-07-06 14:43:02 +00:00
Franco Fichtner
1db49d7c47 system: apply PSR2 style 2015-06-04 20:41:15 +02:00