49 Commits

Author SHA1 Message Date
Franco Fichtner
30fa1c056c interfaces: keep boot order but invoke pre and post device hooks always #5540
OpenVPN was put on the "delayed" ("virtual") list in d090ccc3dceb4
but more out of convenience than common sense.  To make sense of it
now check if the assigned device is provided by the plugin system
except for a bridge which is still having a special role in the code.

The role of bridges is somewhat disputed.  We may be able to set them
up earlier detaching them from the older ordering logic but more tests
need to be done in order to pull it off.
2022-02-11 08:49:45 +01:00
Franco Fichtner
119d6e981b interfaces: clean up GRE same as GIF #5540
The IP alias implementation differs between GIF and GRE with
GRE being worse off since 'if' can be the IP alias and we have
no quick way of looking up the VIP.  Will address later...
2022-02-08 10:19:32 +01:00
Franco Fichtner
f5964434e6 interfaces: remove link remnants from GRE
CC: @adschellevis
2022-01-20 07:46:19 +01:00
Ad Schellevis
15230c70f6 Interfaces: Other Types: GRE - remove non-existing link parameters inherited back in 2014.
Although "link1" does include some code, 22.1 should be safe to drop this hardly used feature (people can add static routes if needed).
2022-01-19 14:14:09 +01:00
Franco Fichtner
0d5ef68694 interfaces: sync groups between possible create/destroy operations
Had to tiptope around f2769fe099 which seems useful but counter-
intuitive.  Renaming live groups is a bad concept.

PR: https://github.com/opnsense/core/issues/5189
2021-09-13 14:07:24 +02:00
Franco Fichtner
3498416734 interfaces: in a perfect world these do not need services.inc
Let's make it so.  :)
2019-04-25 09:37:34 +02:00
Ad Schellevis
4a8e737ced fix some gettext() + html_safe, discussed c4c7f8d732 2019-02-03 20:04:08 +01:00
Ad Schellevis
8c0683540d GRE + ip alias, for https://github.com/opnsense/core/pull/3080 2018-12-30 18:38:40 +01:00
Michael Steenbeek
7ad3d8dff6 Replace some trivial double quotes with single ones 2018-11-23 14:36:44 +01:00
Michael Steenbeek
19ce1c57a4 Replace uncommon <> notation with != 2018-11-23 14:36:44 +01:00
Franco Fichtner
b77b3a5782 interfaces: flip arguments of interface_configure() 2018-05-22 08:42:52 +02:00
Franco Fichtner
e9c3be35d6 www: visual cleanups, unused class/style zapping #2290 2018-03-25 13:10:27 +00:00
NOYB
9d96bdcbc7 Help For - Data For Attribute
Use original element (<div>/<small>) with "data-for" attribute.

The old jquery "for" attribute selectors can be removed once conversion to "data-for" attribute is complete (including plugins).

The old jquery selectors to remove once conversion is complete.
  opnsense_ui.js & head.inc
  $("*[for='" + $(this).attr('id') + "']")....
  $('[for*="help_for"]')....
2018-03-17 16:12:55 +01:00
NOYB
6ef9a127ff HTML Compliance - Attribute "type" on Element <script>
Warning: The type attribute is unnecessary for JavaScript resources.

HTML5: Edition for Web Authors
http://www.w3.org/TR/2014/REC-html5-20141028/scripting-1.html
The default, which is used if the attribute is absent, is "text/javascript".

The Script element
https://developer.mozilla.org/en-US/docs/Web/HTML/Element/script
HTML5 specification urges authors to omit the attribute rather than provide a redundant MIME type.
2018-01-22 19:13:34 +01:00
NOYB
4a7bcae7af HTML Compliance - Attribute "for" on Element <div>
Error: Attribute "for" not allowed on element "div" at this point.
Attributes for element "div": http://www.w3.org/html/wg/drafts/html/master/single-page.html#the-div-element

HTML attribute reference: https://developer.mozilla.org/en-US/docs/Web/HTML/Attributes
The "Output" element: https://developer.mozilla.org/en-US/docs/Web/HTML/Element/output

Attributes for element "output": http://www.w3.org/html/wg/drafts/html/master/single-page.html#the-output-element
2018-01-06 10:52:17 +01:00
NOYB
b2f4cfa7c1 HTML Compliance - Attribute "type" on Element <i>
Error: Attribute "type" not allowed on element <i> at this point.
2018-01-05 08:36:26 +01:00
NOYB
76aab5cb52 HTML Compliance - Obsolete table attributes
width, align, valign, cellpadding, cellspacing, border, summary

Error: The width attribute on the table element is obsolete. Use CSS instead.
Error: The align attribute on the table element is obsolete. Use CSS instead.
Error: The valign attribute on the table element is obsolete. Use CSS instead.
Error: The cellpadding attribute on the table element is obsolete. Use CSS instead.
Error: The cellspacing attribute on the table element is obsolete. Use CSS instead.
Error: The border attribute on the table element is obsolete. Use CSS instead.
Error: The summary attribute on the table element is obsolete. Consider describing the structure of the table in a caption element or in a figure element containing the table; or, simplify the structure of the table so that no description is needed.
2018-01-04 18:26:02 +01:00
Ad Schellevis
69510a5fad legacy ui pages cleanup for https://github.com/opnsense/core/issues/1733 2017-07-22 15:01:26 +02:00
Franco Fichtner
9b694b705d start to hide IPsec and OpenVPN for pluginification 2017-03-11 17:51:54 +01:00
Ad Schellevis
52b95b80c0 (legacy) cancel button behaviour, closes https://github.com/opnsense/core/issues/1099 2016-12-12 21:34:03 +01:00
Franco Fichtner
715b636793 unbound: clean up includes and function usage
o consolidate "unbound_" prefix for unbound.inc for pluginification
o services.inc includes unbound.inc rightfully, a bit like a
  plugin would do in the future, but this also means we can
  zap all requires from top pages, which are entirely spurious.
o get_dns_servers() moves to system.inc because it is used by
  status_interfaces.php
o RIP read_hosts()
2016-11-14 11:28:01 +01:00
Franco Fichtner
152141866b interfaces: url_safe() redirects for #1168 2016-10-09 18:26:39 +02:00
Franco Fichtner
224b5d8247 www: util.inc is provided by guiconfig.inc for #1065 2016-07-22 07:12:21 +02:00
Fabian Franz
f2b3d244ee remove gettext and add a dot 2016-07-10 20:04:24 +02:00
Fabian Franz
f80b48caa0 translation 2016-07-10 17:53:41 +02:00
Ad Schellevis
4e3b66c257 zapp pfsense-utils.inc 2016-06-20 16:59:19 +02:00
Ad Schellevis
65aa038255 (legacy) move is_private_ip() to util.inc 2016-06-20 14:33:30 +02:00
Ad Schellevis
0b31dc522f add opnsense_standard_table_form class to forms 2016-05-20 17:09:58 +02:00
Franco Fichtner
bec1cc375f interfaces: fix typo in GRE edit page 2016-03-18 16:22:59 +01:00
Ad Schellevis
67b827a84f html correction 2016-03-04 12:07:12 +01:00
Ad Schellevis
5033f1cfe5 (legacy) refactor interfaces_gre_edit.php 2016-01-03 20:12:43 +01:00
Franco Fichtner
86d50f8793 www: remove the need for manual $pgtitle #461 2015-12-08 19:45:59 +01:00
Franco Fichtner
e369c686aa src: php opening tag cleanup, the return 2015-11-10 08:29:55 +01:00
Franco Fichtner
b0926593fe interfaces: fix a crash report 2015-10-25 19:08:38 +01:00
Franco Fichtner
98a0662d07 interfaces: zap legacy shortcuts 2015-10-15 00:04:12 +02:00
Ad Schellevis
e556c306b7 (legacy) fix dependencies, related to crashreport "PHP Fatal error: Call to undefined function services_dnsmasq_configure() in /usr/local/etc/inc/interfaces.inc on line 3098" 2015-08-12 06:52:26 +00:00
Ad Schellevis
020ce673cd (legacy) more dependency cleanups 2015-07-23 09:45:57 +00:00
Ad Schellevis
4075a285eb (legacy) move openvpn.inc out of interfaces.inc 2015-07-23 08:27:56 +00:00
Ad Schellevis
465e699e71 (legacy) dependency cleanups related to functions.inc / interfaces.inc 2015-07-22 16:56:38 +00:00
Ad Schellevis
ea5dd43a31 (legacy) move pfsense-utils.inc dependency 2015-07-22 15:09:18 +00:00
Ad Schellevis
cbcf5927ca (legacy) more dependency moves, slowly pouring functions.inc empty.... 2015-07-22 13:08:05 +00:00
Ad Schellevis
7418af459b (legacy) add additional check on $input_errors as part of cleanup notices 2015-07-06 16:58:36 +00:00
Ad Schellevis
ba800ae6c8 (legacy) fix check on $savemsg and $input_errors 2015-07-06 14:43:02 +00:00
Ad Schellevis
fe5ae1b7b2 cleanup requires + small typo's 2015-03-23 20:47:12 +00:00
Franco Fichtner
968a31b33f src: whitespace cleanup and style error fix 2015-01-31 12:45:24 +01:00
Jos Schellevis
60a5170dc8 Several GUI fixes, including mobile presentation 2015-01-27 14:20:30 +00:00
Jos Schellevis
fb340fcd94 More cleanups, copyrights and links 2015-01-01 13:47:20 +00:00
Franco Fichtner
d389da3582 interfaces: apply whitespace cleanups 2014-12-28 09:36:37 +01:00
Franco Fichtner
727453c076 src: move all files (again)
Make "src" the implicit "/usr/local" so that nobody can
sneak in weird files in the base file system or potentially
overwrite them.

This is the last time, I swear...  :)
2014-12-10 16:42:39 +01:00