Ad Schellevis
4ef3c1fbe8
Interfaces: Virtual IPs: Settings - ip alias + vhid validation issue, likely fix for https://github.com/opnsense/core/issues/6422
2023-03-20 20:19:43 +01:00
Franco Fichtner
d22144e3a9
unbound: simplify description and remove hint
2023-03-20 10:44:36 +01:00
Stephan de Wit
bc05c8f59d
unbound: general: update port description and default to disabled
2023-03-20 10:06:54 +01:00
Stephan de Wit
e9285f254b
unbound: blocklists: adjust to rename
2023-03-20 09:15:49 +01:00
Franco Fichtner
e2d0376e0c
system: service API cleanups
2023-03-20 09:14:39 +01:00
Stephan de Wit
b8d3e6a7ef
unbound: blocklists: lowercase all domains
...
while here, also add size check to cached blocklists, as they might be empty
due to network errors.
2023-03-20 09:05:52 +01:00
Franco Fichtner
667b50d564
network time: fix minor warnings in code
2023-03-20 08:41:56 +01:00
Stephan de Wit
ffc1c438e0
unbound: fixup defaults in migration and namespace changes
2023-03-17 15:57:30 +01:00
Franco Fichtner
a50897b517
firmware: make error messages for subscriptions clearer #6373
...
These are the backend issues we have been having. We can improve the
messages later, perhaps add better instructions.
2023-03-17 10:03:41 +01:00
Franco Fichtner
42e519d089
firmware: add advanced/help toggles, cancel button #6373
2023-03-17 08:45:26 +01:00
Ad Schellevis
d1468a3f82
Interfaces: Diagnostics: Ping - minor adjustments for https://github.com/opnsense/core/issues/6378 , limit the maximum runtime to a day, fix form help an add source address
2023-03-16 21:35:15 +01:00
Franco Fichtner
ffcda5bd14
system: fix ACL, copied from @adschellevis ;)
2023-03-16 21:05:18 +01:00
Ad Schellevis
83ccec4330
Interfaces: Diagnostics: Ping - refactor diagnostics tool ( https://github.com/opnsense/core/issues/6378 )
2023-03-16 20:23:22 +01:00
Ad Schellevis
f7d7dafccd
stylefix
2023-03-16 17:30:42 +01:00
Franco Fichtner
617bd3faf5
system: convert widget to API use with aut-refresh; closes #6376
2023-03-16 12:56:47 +01:00
Ad Schellevis
b528952260
VPN/OpenVPN - add missing static-challenge parsing, should fix https://forum.opnsense.org/index.php?topic=32939.msg159861#msg159861
2023-03-16 10:26:43 +01:00
Ad Schellevis
3f7452cb0b
System: Settings: Tunables - prevent applying tunables which are already set, this should fix some issues with buggy drivers resetting when setting a tunable to the value it already had.
2023-03-16 10:19:22 +01:00
Ad Schellevis
4b2b600509
VPN/OpenVPN - reintroduce "cipher" keyword for older clients. closes https://github.com/opnsense/core/issues/6420 partly reverts 1e28d5b352 , only remove "none" cipher for now and assure its not being set by default for new connections.
2023-03-16 09:37:06 +01:00
Franco Fichtner
9f771860a7
system: disable checkboxes in service list but keep visually appealing padding
2023-03-16 09:07:06 +01:00
Franco Fichtner
e42b8a3018
unbound: move this here
...
Perhaps we should break with the "empty" default value as the model is
more capable of ensuring defaults and it avoids a bit of bootstrapping
in cases we need to read a value. Port 53 is not likely going to change
away for DNS.
2023-03-16 08:50:47 +01:00
Franco Fichtner
678368fa66
src: style sweep
2023-03-15 20:32:47 +01:00
Stephan de Wit
5492d4477c
Unbound: migrate General page to MVC ( #6418 )
2023-03-15 13:00:22 +01:00
Franco Fichtner
03ac997fa4
system: migrate services page to MVC #6376
...
Widget is next. While here set configd to 'locked'.
2023-03-15 12:29:07 +01:00
Franco Fichtner
3111b79d99
web proxy: cleanup
2023-03-15 10:06:57 +01:00
Franco Fichtner
4d2c1c2217
system: simplify dump, likely won't need plain boolean status #6376
...
It's easier to use but the MVC already runs on parsing for
"is running" so we don't have to change the world here and
introduce new things.
2023-03-15 09:24:05 +01:00
Franco Fichtner
2511790cb8
ipsec: same for strongswan status
2023-03-15 09:18:09 +01:00
Franco Fichtner
7b9b1a69ff
unbound: replace with portable call
...
The MVC mutable controller looks for "is running" which is
always given if enabled and running. If not enabled the control
will not show and if not running it will say so.
2023-03-15 09:14:39 +01:00
Franco Fichtner
179c6e4f37
system: fix service control bugs, dedup and oddities plus new #6376
...
service_name() and service_message() make this more usable. Also
add a status command for -s mode that emulates rc system output.
2023-03-15 09:06:43 +01:00
Franco Fichtner
0fc88f2d3d
system: yup yup #6376
...
Most likely this is backend material which needs to be filtered/
used to render page content and react on via formalized API request
in order to avoid leaking data.
The nice thing about the filtering is that we only ever have to look
up service status for matching services making the lookup faster.
2023-03-14 16:09:11 +01:00
Franco Fichtner
c56bb65762
system: small service list dump via pluginctl for #6376
...
We may have to fill out runtime information as well and filter
correctly just in case the API ever requires it as it's not a
lot of work.
2023-03-14 15:45:49 +01:00
Franco Fichtner
fa955f66bc
network time: migrate to PID file
2023-03-14 12:16:33 +01:00
Franco Fichtner
b60d7769b4
scripts: last bits of killbypid() converted
2023-03-14 10:45:13 +01:00
Franco Fichtner
6b719e9411
system: killbypid() in web GUI
2023-03-14 10:36:12 +01:00
Franco Fichtner
9316f4fbbd
system: killbypid() in RRD
2023-03-14 10:35:16 +01:00
Franco Fichtner
4a2fb77576
openvpn: simplify killbypid()
2023-03-14 10:28:42 +01:00
Franco Fichtner
9be3015c75
unbound: my favourite way to reduce future diffs is a trailing comma
2023-03-14 10:28:16 +01:00
Stephan de Wit
fff42a1264
Unbound: replace service hooks with configuration hooks
...
With the intent of migrating the general settings page to MVC, the service framework in its current state would be responsible for starting/stopping unbound. However, once the configuration states it isn't enabled the start/stop methods are not exposed anymore.
2023-03-14 10:24:28 +01:00
Franco Fichtner
393690bdb0
system: killbypid() in gateway monitors
2023-03-14 10:23:32 +01:00
Franco Fichtner
1af5c3b770
firewall: killbypid() simplification
2023-03-14 10:22:20 +01:00
Franco Fichtner
481db99fa5
dnsmasq: style and killbypid() simplification
2023-03-14 10:21:28 +01:00
Franco Fichtner
d60bf5ff9e
make: stray newline
2023-03-14 09:31:16 +01:00
Franco Fichtner
e2b7cdae45
unbound: improve restart experience by waiting for pid to be ready
...
OpenVPN uses a similar trick already.
2023-03-14 09:28:03 +01:00
Franco Fichtner
a59f8666a2
interfaces: fix an issue with a batch killbyname()
...
For 23.7 killbyname() should be removed. PID files are here to stay.
2023-03-14 08:12:22 +01:00
Franco Fichtner
4292bd3500
system: default to wait for pid during signaling
...
Except when HUP is used, which would wait forever.
2023-03-14 08:05:32 +01:00
Ad Schellevis
d1f981b6c3
Interfaces: Diagnostics: Packet Capture - minor cleanup
2023-03-13 21:41:25 +01:00
Ad Schellevis
651edfe7c4
Interfaces: Diagnostics: Packet Capture - make sure output buffering is disabled and add headers for the download. closes https://github.com/opnsense/core/issues/6321
2023-03-11 21:40:44 +01:00
Ad Schellevis
3725d70732
Firewall: Rules - missing [!] on inverted aliases.
2023-03-10 07:48:22 +01:00
Franco Fichtner
9b41ff8aff
pkg: fix plist
2023-03-09 18:10:01 +01:00
Ad Schellevis
febec04e28
Reporting/Health - simplify state collection for system-states.rrd which should increase performance and fixes the nat count
2023-03-09 17:35:58 +01:00
Ad Schellevis
8f9534c768
VPN: IPsec: Advanced Settings, make sure that hitting save on the settings store the proper values. https://docs.strongswan.org/docs/5.9/config/logging.html seems to suggest the default log level is 1 (Generic control flow), which should be our default as well then. 0 wasn't stored properly, 3f39ff8442 did fix the select but not the storing part (as 0 isn't the default we should store explicit)
2023-03-09 16:29:57 +01:00
