106 Commits

Author SHA1 Message Date
Ad Schellevis
4a8e737ced fix some gettext() + html_safe, discussed c4c7f8d732 2019-02-03 20:04:08 +01:00
Ad Schellevis
7ad7f55bca fix some escape issues in legacy code 2019-01-29 19:05:33 +01:00
Michael Steenbeek
71774ab376 Fix implicit Javascript global variable assignments (#2945) 2018-12-03 13:17:02 +01:00
Michael Steenbeek
98247373d0 Remove nonexistant CSS properties
The table attributes 'cellspacing' and 'cellpadding' were moved inside the style attribute via a script. However, they are not valid CSS properties, so browsers should (and do) ignore them.
This commit removes them. The 'table' class, set on most tables, should take care of proper formatting anyway.
2018-12-03 12:01:41 +01:00
Michael Steenbeek
7ad3d8dff6 Replace some trivial double quotes with single ones 2018-11-23 14:36:44 +01:00
Michael Steenbeek
19ce1c57a4 Replace uncommon <> notation with != 2018-11-23 14:36:44 +01:00
Franco Fichtner
a095c72857 firewall: avoid translating "by", remove excessive markup 2018-11-22 09:04:15 +01:00
Franco Fichtner
574bd308be src: remove trailing dot workaround by removing trailing dots 2018-09-16 11:44:13 +02:00
Franco Fichtner
a0e3630364 src: unify the label printing of interfaces
This annoyed me for a long time: always print the literal description
if found, only use uppercase on the interface key if no description
is available.
2018-05-04 08:15:52 +00:00
Franco Fichtner
10cf1bbcc2 www: more of the same typo 2018-05-03 21:34:29 +02:00
Franco Fichtner
b2d4863a5a firewall: two more 2018-03-30 14:43:47 +02:00
Franco Fichtner
f3cedc2a66 firewall: remove spurious line 2018-03-30 14:41:07 +02:00
Franco Fichtner
e9c3be35d6 www: visual cleanups, unused class/style zapping #2290 2018-03-25 13:10:27 +00:00
NOYB
9d96bdcbc7 Help For - Data For Attribute
Use original element (<div>/<small>) with "data-for" attribute.

The old jquery "for" attribute selectors can be removed once conversion to "data-for" attribute is complete (including plugins).

The old jquery selectors to remove once conversion is complete.
  opnsense_ui.js & head.inc
  $("*[for='" + $(this).attr('id') + "']")....
  $('[for*="help_for"]')....
2018-03-17 16:12:55 +01:00
Franco Fichtner
dd71f72b45 src: style fix 2018-03-11 00:13:02 +01:00
NOYB
6ef9a127ff HTML Compliance - Attribute "type" on Element <script>
Warning: The type attribute is unnecessary for JavaScript resources.

HTML5: Edition for Web Authors
http://www.w3.org/TR/2014/REC-html5-20141028/scripting-1.html
The default, which is used if the attribute is absent, is "text/javascript".

The Script element
https://developer.mozilla.org/en-US/docs/Web/HTML/Element/script
HTML5 specification urges authors to omit the attribute rather than provide a redundant MIME type.
2018-01-22 19:13:34 +01:00
NOYB
4a7bcae7af HTML Compliance - Attribute "for" on Element <div>
Error: Attribute "for" not allowed on element "div" at this point.
Attributes for element "div": http://www.w3.org/html/wg/drafts/html/master/single-page.html#the-div-element

HTML attribute reference: https://developer.mozilla.org/en-US/docs/Web/HTML/Attributes
The "Output" element: https://developer.mozilla.org/en-US/docs/Web/HTML/Element/output

Attributes for element "output": http://www.w3.org/html/wg/drafts/html/master/single-page.html#the-output-element
2018-01-06 10:52:17 +01:00
NOYB
b2f4cfa7c1 HTML Compliance - Attribute "type" on Element <i>
Error: Attribute "type" not allowed on element <i> at this point.
2018-01-05 08:36:26 +01:00
NOYB
76aab5cb52 HTML Compliance - Obsolete table attributes
width, align, valign, cellpadding, cellspacing, border, summary

Error: The width attribute on the table element is obsolete. Use CSS instead.
Error: The align attribute on the table element is obsolete. Use CSS instead.
Error: The valign attribute on the table element is obsolete. Use CSS instead.
Error: The cellpadding attribute on the table element is obsolete. Use CSS instead.
Error: The cellspacing attribute on the table element is obsolete. Use CSS instead.
Error: The border attribute on the table element is obsolete. Use CSS instead.
Error: The summary attribute on the table element is obsolete. Consider describing the structure of the table in a caption element or in a figure element containing the table; or, simplify the structure of the table so that no description is needed.
2018-01-04 18:26:02 +01:00
Franco Fichtner
db785c954f firewall: fix rules edit cancel menu behaviour #1928 2017-11-21 05:24:01 +00:00
Franco Fichtner
41f5a7fba4 firewall: better label for "main"; closes #1719 2017-08-06 00:24:36 +02:00
Ad Schellevis
69510a5fad legacy ui pages cleanup for https://github.com/opnsense/core/issues/1733 2017-07-22 15:01:26 +02:00
Ad Schellevis
2d2771acb3 filter, skip well-known ports for ranges, closes https://github.com/opnsense/core/issues/1605 2017-05-04 20:21:31 +02:00
Ad Schellevis
f296f6810c gwlb, found the use... 2dbc3ab259 2017-04-16 19:13:40 +02:00
Franco Fichtner
500539234d firewall: properly reload cron for scheduled rules; closes #1483 2017-03-20 08:45:18 +01:00
Franco Fichtner
87dfc1f126 firewall: add tag/tagged to port forwarding for #1423
It's a bit funny that the help text indicates we can use tag/tagged with
NAT rules as well, because this was never implemented although it really
works.
2017-03-05 20:09:27 +01:00
Ian Matyssik
d0b0ca28c2 Add modulate state as an option for state tracking 2017-02-24 14:59:23 +09:00
Franco Fichtner
eacf920fa8 firewall: feedback from @djGrrr 2017-02-13 07:50:41 +01:00
Franco Fichtner
ee0e0eaeed firewall: improve validation on previous 2017-02-12 19:33:46 +01:00
Franco Fichtner
c7ac2083f6 firewall: array_merge() throws off indices 2017-02-12 19:28:04 +01:00
Franco Fichtner
0c09631552 firewall: ints are confusing 2017-02-12 19:12:33 +01:00
Franco Fichtner
69f89b047b firewall: more work on prio matching 2017-02-12 19:08:36 +01:00
djGrrr
b0075a6f21 Add priority settings to advanced firewall rule options (#1392)
* Add priority settings to advanced firewall rule options

* fix all the previous issues with the priority rules patch and add support for the 2 prio setting

* make the advanced options auto expand, even with various priorities set to 0
2017-02-12 18:17:04 +01:00
Ad Schellevis
f44a60f9b0 firewall, fix validation, closes https://github.com/opnsense/core/issues/1381 2017-02-07 15:05:10 +01:00
Ad Schellevis
52b95b80c0 (legacy) cancel button behaviour, closes https://github.com/opnsense/core/issues/1099 2016-12-12 21:34:03 +01:00
Franco Fichtner
ec679740a5 system: move system_cron_configure() to new home 2016-11-20 11:22:49 +01:00
Franco Fichtner
b508d4d9f7 services: rename again for consistency 2016-11-20 11:16:10 +01:00
Fabian Franz
ab5a1ed7ae fix bug in firewall_rules_edit.php reported by tillsense in the forum at https://forum.opnsense.org/index.php?topic=3951.0;topicseen 2016-11-19 10:58:35 +01:00
Franco Fichtner
f16199ffe9 cron: prepend system_, but move to system.inc later 2016-11-14 23:09:22 +01:00
Franco Fichtner
029393adf2 firewall: url_safe() conversion, closes #1168
While there, kill "if (write_config())" constructs as this
really isn't a thing.
2016-10-12 08:36:16 +02:00
Fabian Franz
6411baeaa1 translation; closes #1069
Omit the console changes, we are not prepared for improving
the translation there.
2016-08-10 08:34:05 +02:00
Franco Fichtner
71f7d3c223 firwall: output nat logging GUI part for #916 2016-07-23 09:56:07 +02:00
Ad Schellevis
4e3b66c257 zapp pfsense-utils.inc 2016-06-20 16:59:19 +02:00
Ad Schellevis
c660d3ec8c firewall, formNetworks() is the same as get_specialnets() now 2016-06-01 13:40:25 +02:00
Ad Schellevis
c7d03899f5 firewall pages, normalize interface selection, using the new interface plugins 2016-06-01 13:21:01 +02:00
Ad Schellevis
a19f10fbb2 (firewall) zapp "match" 2016-05-30 15:11:08 +02:00
Ad Schellevis
4a0b1b8292 cleanup, remove unused in firewall_rules_edit.php 2016-05-27 16:01:02 +02:00
Ad Schellevis
58001db0cc (firewall) parse /etc/protocols for valid options, sort most used on top. 2016-05-25 16:12:34 +02:00
Ad Schellevis
16348d265e (firewall, ui) remove IPV6 as valid protocol selection 2016-05-24 13:17:09 +02:00
Ad Schellevis
0b31dc522f add opnsense_standard_table_form class to forms 2016-05-20 17:09:58 +02:00