This is for consistency with hard disk device visibility as it
could be mounted / active. While here, stop cleaning up MNT as
it is only a directory in /tmp that should cause issues...
We already have "kernel" and "base" and plugins also follow this
pattern by only registering its name once per devel or release
version. This kills ambiguity for "opnsense" vs. "opnsense-version"
and makes it more branding friendly. Suffice to say "core", "kernel"
and "base" are reserved names and also align with tools.git.
product_flavour is embedded in the release package but the
package itself does not insist on a particular flavour other
than having knowledge about the flavour the package was
built for originally. This is ok and direct crypto deps
seem to have failed to produce reliable upgrade / sidegrade
results in recent tests anyway.
Long story short: find out the real crypto flavour installed
from the OpenSSL binary or fall back to the metadata if said
binary cannot be found.
Otherwise we try to unload when it's there. Logic was
correct but -b assumtion was incorrect as we do not touch
drivers there or require any pool listing.
/dev/zfs/pool does not exist so we can do a "zfs/pool" input
in alignment with gmirror and graid inputs. Move the probing
after zfs load to be able to unload again also.
If the user's existing subnet isn't 192.168.1.1/xx, then telling the user to use this IP will fail. So tell the user how to set a different IP after reboot, rather than just telling them to use an IP that won't work for them.
Kept short this time - 1 line only :)
Also edited wording re certificate, to be clearer about this as well, by starting with what they will actually see (*"Your browser may..."* rather than *"You might need to..."*). Added just 1 line there as well.
Sorry for these - hopefully not overdoing it. (I'm a fan of making life fun for newcomers, and install is where newcomers first see if a thing works for them!) Perhaps they can be squashed down to save text space. If so please do.
For now only trigger on an explicit "zpool" input, because
otherwise we have to load ZFS earlier to probe for a particular
pool. There is no nice way to list all pools available for
input, at least not in a single, script friendly line per pool.
PR: https://github.com/opnsense/bsdinstaller/issues/12
The funny thing is su -m foobar -c "sh -c '$cmd'" could be as
short as su -m foobar -s /bin/sh -c "$cmd" but why bother selecting
a shell when you need to rely on a proper root shell to be set?
