35 Commits

Author SHA1 Message Date
Franco Fichtner
eb41f24d6a interafces: fix typo in previous 2023-09-14 21:56:05 +02:00
Franco Fichtner
49df30eb83 interfaces: do not annotate disabled state for members
Recently did the same for Unbound.  The context for the user is clear
and we shouldn't be too concerned for what the user thinks about disabled
interfaces since he disabled them in the first place.

Use the same interface description source in the overview page.
2023-09-14 21:46:52 +02:00
Franco Fichtner
189e3af29e interfaces: improve bridge code a bit
* Allow the bridge to come up without members.  While the GUI made sure
  to avoid empty bridges there is no reason for it and underneath if the
  interface was disabled the GUI made the interface disappear from the
  selection.  So now allow an empty bridge (may be nice for migration)
  and show disabled interfaces in the edit page.  Fix all callers to not
  assume the member property is always set.  Can probably go away once
  bridges are moved to MVC.
* Inline interface_bridge_add_member() since link_interface_to_bridge()
  is the only caller.  Improve the parameter passing a bit too.
* Add bridge interface return code to (_)interfaces_bridge_configure().
* Improve device resolution and a few mwexecf() replacements.
* Log the reason why a device could not be attached to bridge when one
  device is not there as expected.
2023-09-13 10:39:49 +02:00
Franco Fichtner
e6518fcd14 interfaces: simplify as others like gif and gre do #4622 2022-06-30 16:46:11 +02:00
Ad Schellevis
3bd36b5624 Interfaces - uniform test if interface is already assigned somewhere using new is_interface_assigned() funciton in utils.inc, implement check in openvpn client/server while here. closes https://github.com/opnsense/core/issues/5163 2021-08-17 12:30:42 +02:00
Franco Fichtner
c0757553a1 interfaces: remove $main_buttons use #4216 2021-06-15 12:05:04 +02:00
Franco Fichtner
db2b0ff27c interfaces: allow link-local address on bridges; closes #926 2019-04-25 09:25:40 +02:00
Ad Schellevis
75f74d83a9 php7.2, some more issues waiting to happen. closes https://github.com/opnsense/core/issues/3400 2019-04-09 14:06:31 +02:00
Franco Fichtner
c5ed71ad26 interfaces: style for #2440 2018-06-04 12:18:04 +00:00
NOYB
6ef9a127ff HTML Compliance - Attribute "type" on Element <script>
Warning: The type attribute is unnecessary for JavaScript resources.

HTML5: Edition for Web Authors
http://www.w3.org/TR/2014/REC-html5-20141028/scripting-1.html
The default, which is used if the attribute is absent, is "text/javascript".

The Script element
https://developer.mozilla.org/en-US/docs/Web/HTML/Element/script
HTML5 specification urges authors to omit the attribute rather than provide a redundant MIME type.
2018-01-22 19:13:34 +01:00
Ad Schellevis
69510a5fad legacy ui pages cleanup for https://github.com/opnsense/core/issues/1733 2017-07-22 15:01:26 +02:00
Franco Fichtner
152141866b interfaces: url_safe() redirects for #1168 2016-10-09 18:26:39 +02:00
Ad Schellevis
d082febd9c (legacy) refactor config->interface traversal 2016-05-26 18:05:09 +02:00
Franco Fichtner
abcb4cce31 src: start removal of visual clutter in the form of markup "hints" et al
This makes pages much easer on the eye, the messages are clear still.
2016-04-01 12:56:15 +02:00
Manuel Faux
cea23f8cae UX: moved tooltip position to top for most tooltips 2016-01-10 12:06:48 +01:00
Manuel Faux
87014246c0 UX: changed delete icon from "X" to "trash" 2016-01-10 12:06:48 +01:00
Ad Schellevis
22b2014897 Merge pull request #587 from fabianfrz/style
change dialog style
2016-01-01 12:01:01 +01:00
Fabian Franz
1d0f083d96 change dialog style 2015-12-31 18:00:31 +01:00
Ad Schellevis
0831629070 (legacy) remove form action= from interfaces_bridge.php 2015-12-31 15:51:08 +01:00
Ad Schellevis
9e07e78202 (legacy) refactor interfaces_bridge_edit.php 2015-12-30 17:26:24 +01:00
Franco Fichtner
86d50f8793 www: remove the need for manual $pgtitle #461 2015-12-08 19:45:59 +01:00
Franco Fichtner
0d2272ff37 www: interface and dns tools tabs gone for #461
Starting to get a life of its own...
2015-12-05 08:59:08 +01:00
Franco Fichtner
77ec6d5d38 Merge pull request #458 from fabianfrz/translation
work on #427
2015-11-07 22:01:31 +01:00
Franco Fichtner
1b03f583a7 www: transform $input_error strings to gettext()
Spotted by: @fabianfrz
2015-11-07 21:52:56 +01:00
Fabian Franz
1961849d74 fixes for #427 2015-11-07 19:46:14 +01:00
Franco Fichtner
98a0662d07 interfaces: zap legacy shortcuts 2015-10-15 00:04:12 +02:00
Ad Schellevis
465e699e71 (legacy) dependency cleanups related to functions.inc / interfaces.inc 2015-07-22 16:56:38 +00:00
Ad Schellevis
7418af459b (legacy) add additional check on $input_errors as part of cleanup notices 2015-07-06 16:58:36 +00:00
Ad Schellevis
ba800ae6c8 (legacy) fix check on $savemsg and $input_errors 2015-07-06 14:43:02 +00:00
Franco Fichtner
75cf7115a0 src: more is_array() -> isset() conversions 2015-04-15 14:57:32 +02:00
Ad Schellevis
fe5ae1b7b2 cleanup requires + small typo's 2015-03-23 20:47:12 +00:00
Jos Schellevis
60a5170dc8 Several GUI fixes, including mobile presentation 2015-01-27 14:20:30 +00:00
Jos Schellevis
fb340fcd94 More cleanups, copyrights and links 2015-01-01 13:47:20 +00:00
Franco Fichtner
d389da3582 interfaces: apply whitespace cleanups 2014-12-28 09:36:37 +01:00
Franco Fichtner
727453c076 src: move all files (again)
Make "src" the implicit "/usr/local" so that nobody can
sneak in weird files in the base file system or potentially
overwrite them.

This is the last time, I swear...  :)
2014-12-10 16:42:39 +01:00