We already do a more-or-less hybrid approach by starting rtsold
even if it isn't used at all. Now we also have ISPs which do
not seem to send router advertisements after successful connect
so that the reconnect misses the HUP for dhcp6c to fix the
connectivity again.
To change that remove the option and its only conditional to
behave unconditionally which has few reasons to cause regressions.
@Adschellvis and me wondered about this so I did a bit of
reseach and multiple workaround oddities exist to fix parts
of the issue. To be frank, fix the issue at the source and
do not let users otherwise configure these settings in tunnel
interfaces.
See: https://redmine.pfsense.org/issues/3280
Also see: https://redmine.pfsense.org/issues/8687
Some back and forth between explicit and implicit requires while here.
The code is helplessly glued together and no plugin facility to get
data from a function call currently exists.
It seems DHCP in 11.2 is honouring the ISPs MTU if it is sent. It
also seems there are some ISPs who send a stupid value. This fix
allows the user to ignore the ISP-supplied MTU (or not) with the
default set to ignore for compatibility with the previous behaviour.
PR: https://github.com/opnsense/core/issues/3173
This allows us to call a funcion which will generate the correct
credentials where they need to be hashed or not. In the function
in this PR, the function returns all of the request and send
options required for Orange France and fills in the client fields
automatically.
Also in the case of Orange France an extra entry box appears to
allow the entry of the LiveBox_ID.
The PR is a work in progress, but all that is needed to make it
work for Orange France is the hash routine.
It's also possible to use the functions create the hex strings
needed for other ISPs and auto fill the options as needed.
Section of code I've removed had been removed previously as during recent
PR's the ability to iterate through the interfaces was added. This 'solo'
bit of code appears to have made its way back in, don't know where and
don't know when as the song goes. Remove SLA_ID from Prefix interface.
It's collected from the LAN settings
This code keeps the legacy aliases functional until switched (migrated) to the new ones, improves isAlias() performance which was in 18.7r2 and removes some code duplication.
