lucaspalomodevelop/core
1
0
Fork 0
mirror of https://github.com/lucaspalomodevelop/core.git synced 2026-03-13 00:07:26 +00:00
Code Issues Packages Projects Releases Wiki Activity
18,203 Commits 1 Branch 0 Tags
Commit Graph

65 Commits

Author SHA1 Message Date
Franco Fichtner
35f46bbb11 firewall: remove unused function... 
... imported into pfSense in 2007... unused ;)

https://github.com/pfsense/pfsense/commit/615b27bc267a98e72
 2025-04-24 10:49:56 +02:00
kuya1284
b85f3d0ed1
Firewall Schedules - cleanups 2023-04-15 17:32:21 +02:00
Ad Schellevis
cb57e593a0 Firewall: Settings: Schedules - hopefully final attempt to fix the description escape issue for https://github.com/opnsense/core/issues/6348 
This code unfortunately is utterly broken, the plain Javascript code is lenghty and buggy, this only tries to solve the escape issue, but it would be much better if all of this would be replaced with some simple jQuery constructtions.
 2023-03-26 19:26:59 +02:00
Ad Schellevis
5dd83dd56a Firewall: Settings: Schedules - undo rawurldecode()/rawurlencode() magic, bringing back https://github.com/opnsense/core/issues/6348 2023-03-26 15:06:44 +02:00
kuya1284
29f1fadf80
Firewall: Settings: Schedules - usability improvements. 
closes https://github.com/opnsense/core/issues/6348 , https://github.com/opnsense/core/issues/6349
 2023-03-26 11:31:13 +02:00
Josh Soref
20a3c3da38
Spelling (#5885) 2022-07-18 13:59:03 +02:00
Ad Schellevis
a57abe792f legacy: ditch is_validaliasname() for good. closes https://github.com/opnsense/core/issues/4470 2021-01-08 17:33:00 +01:00
Ad Schellevis
4772e0c5db php7.2, count() issue in www/firewall_schedule_edit.php for https://github.com/opnsense/core/issues/3400 2019-04-09 13:39:54 +02:00
Ad Schellevis
80d94767a7 firewall_schedule_edit.php, escape issues 2019-02-26 20:16:00 +01:00
Franco Fichtner
0b879022ae www: d+f for #3218 2019-02-14 12:31:48 +01:00
Ad Schellevis
4a8e737ced fix some gettext() + html_safe, discussed c4c7f8d732 2019-02-03 20:04:08 +01:00
NOYB
f5d532a0f4 Legacy Browsers Accommodation (#3158) 2019-02-01 10:26:30 +01:00
Michael Steenbeek
97645093c3 Fix missing semicolons 2019-01-11 16:44:23 +01:00
Michael Steenbeek
69cc3895e6 Fix some JS errors 2019-01-04 08:39:22 +01:00
Michael Steenbeek
71774ab376 Fix implicit Javascript global variable assignments (#2945) 2018-12-03 13:17:02 +01:00
Michael Steenbeek
98247373d0 Remove nonexistant CSS properties 
The table attributes 'cellspacing' and 'cellpadding' were moved inside the style attribute via a script. However, they are not valid CSS properties, so browsers should (and do) ignore them.
This commit removes them. The 'table' class, set on most tables, should take care of proper formatting anyway.
 2018-12-03 12:01:41 +01:00
Franco Fichtner
4bd4990593 www: inline single-use *cmp() functions 2018-11-26 08:10:03 +01:00
Michael Steenbeek
7f09e04d81 Fix some HTML errors 2018-11-21 11:42:01 +01:00
Franco Fichtner
574bd308be src: remove trailing dot workaround by removing trailing dots 2018-09-16 11:44:13 +02:00
Franco Fichtner
97bb55ca67 firewall: style #2440 2018-06-13 06:49:39 +00:00
Fabian Franz BSc
435f2fa02b fix: move color settings from firewall_schedule_edit.php to theme (#2407) 2018-05-16 17:56:42 +02:00
Franco Fichtner
319a8bca28 firewall: inherit color for themes 
PR: https://forum.opnsense.org/index.php?topic=8699.0
 2018-05-15 17:33:00 +00:00
Franco Fichtner
e9c3be35d6 www: visual cleanups, unused class/style zapping #2290 2018-03-25 13:10:27 +00:00
Franco Fichtner
b074216e93 www: style updates, less strong/bold markup #2290 2018-03-25 10:08:53 +00:00
NOYB
9d96bdcbc7 Help For - Data For Attribute 
Use original element (<div>/<small>) with "data-for" attribute.

The old jquery "for" attribute selectors can be removed once conversion to "data-for" attribute is complete (including plugins).

The old jquery selectors to remove once conversion is complete.
  opnsense_ui.js & head.inc
  $("*[for='" + $(this).attr('id') + "']")....
  $('[for*="help_for"]')....
 2018-03-17 16:12:55 +01:00
NOYB
6ef9a127ff HTML Compliance - Attribute "type" on Element <script> 
Warning: The type attribute is unnecessary for JavaScript resources.

HTML5: Edition for Web Authors
http://www.w3.org/TR/2014/REC-html5-20141028/scripting-1.html
The default, which is used if the attribute is absent, is "text/javascript".

The Script element
https://developer.mozilla.org/en-US/docs/Web/HTML/Element/script
HTML5 specification urges authors to omit the attribute rather than provide a redundant MIME type.
 2018-01-22 19:13:34 +01:00
NOYB
4a7bcae7af HTML Compliance - Attribute "for" on Element <div> 
Error: Attribute "for" not allowed on element "div" at this point.
Attributes for element "div": http://www.w3.org/html/wg/drafts/html/master/single-page.html#the-div-element

HTML attribute reference: https://developer.mozilla.org/en-US/docs/Web/HTML/Attributes
The "Output" element: https://developer.mozilla.org/en-US/docs/Web/HTML/Element/output

Attributes for element "output": http://www.w3.org/html/wg/drafts/html/master/single-page.html#the-output-element
 2018-01-06 10:52:17 +01:00
NOYB
b2f4cfa7c1 HTML Compliance - Attribute "type" on Element <i> 
Error: Attribute "type" not allowed on element <i> at this point.
 2018-01-05 08:36:26 +01:00
NOYB
76aab5cb52 HTML Compliance - Obsolete table attributes 
width, align, valign, cellpadding, cellspacing, border, summary

Error: The width attribute on the table element is obsolete. Use CSS instead.
Error: The align attribute on the table element is obsolete. Use CSS instead.
Error: The valign attribute on the table element is obsolete. Use CSS instead.
Error: The cellpadding attribute on the table element is obsolete. Use CSS instead.
Error: The cellspacing attribute on the table element is obsolete. Use CSS instead.
Error: The border attribute on the table element is obsolete. Use CSS instead.
Error: The summary attribute on the table element is obsolete. Consider describing the structure of the table in a caption element or in a figure element containing the table; or, simplify the structure of the table so that no description is needed.
 2018-01-04 18:26:02 +01:00
Franco Fichtner
3ae9866ea7 src: consistent use of readonly as xhtml 2018-01-02 14:47:46 +01:00
Franco Fichtner
283fd7ac2a firewall: wrong double-encode, closes #1813 2017-09-09 08:26:04 +02:00
Franco Fichtner
c5d4002541 src: add Scott's e-mail everywhere 2017-08-05 20:57:29 +02:00
Ad Schellevis
69510a5fad legacy ui pages cleanup for https://github.com/opnsense/core/issues/1733 2017-07-22 15:01:26 +02:00
Franco Fichtner
68faafd185 aliases: improve validation messages; closes #1443 2017-04-12 07:36:56 +02:00
Ad Schellevis
9ce93f8266 (filter) remove unused parameter schedlabel 2017-03-05 13:50:54 +01:00
Ad Schellevis
52b95b80c0 (legacy) cancel button behaviour, closes https://github.com/opnsense/core/issues/1099 2016-12-12 21:34:03 +01:00
Franco Fichtner
029393adf2 firewall: url_safe() conversion, closes #1168 
While there, kill "if (write_config())" constructs as this
really isn't a thing.
 2016-10-12 08:36:16 +02:00
Franco Fichtner
f6b554f87e www: consistent use of <?=, some escapes while at it; closes #986 2016-06-11 07:45:49 +02:00
Franco Fichtner
cf274fef43 firewall: fix schedule clone when in use; closes #976 2016-05-30 22:43:21 +02:00
Ad Schellevis
0b31dc522f add opnsense_standard_table_form class to forms 2016-05-20 17:09:58 +02:00
Ad Schellevis
7ab0b3463f (legacy) www: strip action attribute from forms where not needed, closes https://github.com/opnsense/core/issues/929 2016-05-12 19:45:28 +02:00
Franco Fichtner
bdf66d4908 firewall: pimp schedule layout 2016-04-01 12:56:15 +02:00
Ad Schellevis
67b827a84f html correction 2016-03-04 12:07:12 +01:00
Franco Fichtner
6ee8eb7812 src: remove a whole lotta nop 
Lookie how far we've come...
 2016-02-03 08:43:06 +01:00
Manuel Faux
3f04c0a7e2 Firewall: schedule column: added tooltip and bugfix 
Added tooltip to show description of schedule and fixed editing capabilities of
schedules from page firewall_rules.php.
 2016-01-10 16:25:06 +01:00
Manuel Faux
87014246c0 UX: changed delete icon from "X" to "trash" 2016-01-10 12:06:48 +01:00
Ad Schellevis
6b48c19387 (legacy) fix header alignment for "Schedule repeat" section 2016-01-07 17:31:29 +01:00
Fabian Franz
c3cccbc101 translation fix 2015-12-31 18:34:13 +01:00
Franco Fichtner
86d50f8793 www: remove the need for manual $pgtitle #461 2015-12-08 19:45:59 +01:00
Ad Schellevis
972737ec18 (legacy) refactor firewall_schedule_edit.php 2015-08-25 18:46:25 +00:00