chart.js canvas elements default their display to block, which can
cause sub-pixel rounding errors, in turn causing flickering when
the canvas element is interacted with (reproducible on Firefox).
'display: inline-block' fixes this, and while one could specify this
in css, this would have to be combined with !important, as the style
ordering prefers styles either set hardcoded inline or via JS. This
has the obvious downside that a canvas element cannot be hidden anymore,
as it's display setting would always be forced.
The only solution in terms of ordering is to override the inline style
by setting it in the canvas element directly as this commit is doing.
All canvas elements used by widgets which fit the following criteria
must use this inline style:
- a canvas element is used by chart.js
- said canvas lives in a responsive container
- the chart must be resizable in height, which requires the 'canvas-container'
parent element.
We move the gateway recovery into the hook as a user and users
can do their on similar scripts to fetch current status and
inspect and react accordingly. We do so before filter reload
to avoid excessive reloads in the facility script(s).
What this loses is the ability to get the previous argments
for statistics, but OTOH it also reduces the risk for spurious
events as we only trigger on state transitions.
Allow import hooks to be overwritten or manipulated.
No functional changes but it allows to bootstrap a
/conf/config.xml before opnsense-importer (making it
skip import) or modifying the imported /conf/config.xml
afterwards.
I think I could have done this before. We don't need historic artefacts
in a config.xml copy that doesn't do anything with it (nor need it in any
way).
Although this isn't the prettiest option in the world, it does solve the issue. It would have been better if we had "keyed" the items in some way so input is less sensitive for issues like these
As discussed the wizard will be removed and the legacy component
it is feeding moved to a plugin for 25.7 so it makes no sense to
drag this along any further.
* mvc/view: Create layout_partials/base_apply_button to centralize design of the standard Apply button
* dhcp/kea: Example implementation of layout_partials/base_apply_button
* mvc/view: Change edit_alert_id to global static default, add data-grid-reload and dynamic ids to base_apply_button partial
