48 Commits

Author SHA1 Message Date
Franco Fichtner
2b265279e5 src: change all instances to "comma-separated" 2019-01-06 15:04:28 +01:00
Michael Steenbeek
2c61e068a2 Small fixes (#3096) 2019-01-04 09:26:16 +01:00
Franco Fichtner
3bb0e00e19 interfaces: loosely related cleanups #2707 2018-12-30 14:04:22 +01:00
Michael Steenbeek
00b6db04fb Fix: name attribute cannot be set on tr tags 2018-12-05 08:15:14 +01:00
Michael Steenbeek
6db6598c00 Fix more incorrect HTML tags (#3007) 2018-12-04 10:13:22 +01:00
Michael Steenbeek
71774ab376 Fix implicit Javascript global variable assignments (#2945) 2018-12-03 13:17:02 +01:00
Franco Fichtner
e9c3be35d6 www: visual cleanups, unused class/style zapping #2290 2018-03-25 13:10:27 +00:00
NOYB
9d96bdcbc7 Help For - Data For Attribute
Use original element (<div>/<small>) with "data-for" attribute.

The old jquery "for" attribute selectors can be removed once conversion to "data-for" attribute is complete (including plugins).

The old jquery selectors to remove once conversion is complete.
  opnsense_ui.js & head.inc
  $("*[for='" + $(this).attr('id') + "']")....
  $('[for*="help_for"]')....
2018-03-17 16:12:55 +01:00
NOYB
6ef9a127ff HTML Compliance - Attribute "type" on Element <script>
Warning: The type attribute is unnecessary for JavaScript resources.

HTML5: Edition for Web Authors
http://www.w3.org/TR/2014/REC-html5-20141028/scripting-1.html
The default, which is used if the attribute is absent, is "text/javascript".

The Script element
https://developer.mozilla.org/en-US/docs/Web/HTML/Element/script
HTML5 specification urges authors to omit the attribute rather than provide a redundant MIME type.
2018-01-22 19:13:34 +01:00
NOYB
4a7bcae7af HTML Compliance - Attribute "for" on Element <div>
Error: Attribute "for" not allowed on element "div" at this point.
Attributes for element "div": http://www.w3.org/html/wg/drafts/html/master/single-page.html#the-div-element

HTML attribute reference: https://developer.mozilla.org/en-US/docs/Web/HTML/Attributes
The "Output" element: https://developer.mozilla.org/en-US/docs/Web/HTML/Element/output

Attributes for element "output": http://www.w3.org/html/wg/drafts/html/master/single-page.html#the-output-element
2018-01-06 10:52:17 +01:00
NOYB
b2f4cfa7c1 HTML Compliance - Attribute "type" on Element <i>
Error: Attribute "type" not allowed on element <i> at this point.
2018-01-05 08:36:26 +01:00
NOYB
76aab5cb52 HTML Compliance - Obsolete table attributes
width, align, valign, cellpadding, cellspacing, border, summary

Error: The width attribute on the table element is obsolete. Use CSS instead.
Error: The align attribute on the table element is obsolete. Use CSS instead.
Error: The valign attribute on the table element is obsolete. Use CSS instead.
Error: The cellpadding attribute on the table element is obsolete. Use CSS instead.
Error: The cellspacing attribute on the table element is obsolete. Use CSS instead.
Error: The border attribute on the table element is obsolete. Use CSS instead.
Error: The summary attribute on the table element is obsolete. Consider describing the structure of the table in a caption element or in a figure element containing the table; or, simplify the structure of the table so that no description is needed.
2018-01-04 18:26:02 +01:00
Ad Schellevis
69510a5fad legacy ui pages cleanup for https://github.com/opnsense/core/issues/1733 2017-07-22 15:01:26 +02:00
velati
7681a2915d interfaces: Host-Uniq field in PPPoE connection; closes #1730
PR: https://forum.opnsense.org/index.php?topic=5307.0
2017-07-19 17:29:43 +02:00
Ad Schellevis
52b95b80c0 (legacy) cancel button behaviour, closes https://github.com/opnsense/core/issues/1099 2016-12-12 21:34:03 +01:00
Franco Fichtner
152141866b interfaces: url_safe() redirects for #1168 2016-10-09 18:26:39 +02:00
Ad Schellevis
1ccf6b4527 remove idletimeout requirement for ondemand connections 2016-09-14 20:08:37 +02:00
Franco Fichtner
ea31c80969 www: more php print issues 2016-06-15 06:32:40 +02:00
Ad Schellevis
449f506b27 (ppp, 4g) show modem descr when selecting a port, for https://github.com/opnsense/core/issues/1004 2016-06-09 12:46:03 +02:00
Franco Fichtner
d5654b79a6 interfaces: remove pppoe reset cron handling... #911
... Ad already annotated a few spots, the whole thing is beyond
repair and I dread extending it to PPP and others which has been
asked for a few times now.  We will have to find another way.

To paraphrase Star Trek: He's dead, Jim.

The upside is that the cron config items are flushed by default
now, later we can remove this as we don't care what is in that
unused config section anyway.
2016-05-27 00:02:20 +02:00
Ad Schellevis
0b31dc522f add opnsense_standard_table_form class to forms 2016-05-20 17:09:58 +02:00
Ad Schellevis
7ab0b3463f (legacy) www: strip action attribute from forms where not needed, closes https://github.com/opnsense/core/issues/929 2016-05-12 19:45:28 +02:00
Fabian Franz
ac6122eb0f interfaces_ppps_edit.php translation and html fix 2016-04-24 12:57:52 +02:00
Franco Fichtner
d81713dc44 interfaces: tweak previous
Requested by: coffee
2016-04-01 07:10:33 +02:00
Franco Fichtner
beab33e579 interfaces: fix a crash report 2016-04-01 07:06:10 +02:00
Ad Schellevis
67b827a84f html correction 2016-03-04 12:07:12 +01:00
Ad Schellevis
a7e4762b9c (legacy) fix html errors, remove $closehead 2016-01-27 18:18:05 +01:00
Franco Fichtner
015345c805 src: indent copyright header to 4 spaces 2016-01-03 11:52:30 +01:00
Ad Schellevis
1923ee6c13 (legacy) small style fix in interfaces_ppps_edit.php 2015-12-31 13:20:55 +01:00
Ad Schellevis
c8621485c2 (legacy) 0 vs null in interfaces_ppps_edit.php 2015-12-29 21:40:19 +01:00
Ad Schellevis
54b97b694b (legacy) refactor interfaces_ppps_edit.php 2015-12-29 20:27:40 +01:00
Ad Schellevis
da27fe7cee (legacy) refactor interfaces_ppps_edit.php, work in progress 2015-12-29 18:42:27 +01:00
Franco Fichtner
86d50f8793 www: remove the need for manual $pgtitle #461 2015-12-08 19:45:59 +01:00
Franco Fichtner
1b03f583a7 www: transform $input_error strings to gettext()
Spotted by: @fabianfrz
2015-11-07 21:52:56 +01:00
Franco Fichtner
98a0662d07 interfaces: zap legacy shortcuts 2015-10-15 00:04:12 +02:00
Franco Fichtner
829c503a9a src: last sweep through crash reports for 15.7.7 2015-08-05 08:59:57 +02:00
Franco Fichtner
e8496219a5 src: fix crash reports 2015-08-04 12:16:11 +02:00
Ad Schellevis
c55a7c50ed (legacy) remove services.inc dependency from interfaces.inc 2015-07-23 08:04:59 +00:00
Ad Schellevis
465e699e71 (legacy) dependency cleanups related to functions.inc / interfaces.inc 2015-07-22 16:56:38 +00:00
Ad Schellevis
7418af459b (legacy) add additional check on $input_errors as part of cleanup notices 2015-07-06 16:58:36 +00:00
Ad Schellevis
ba800ae6c8 (legacy) fix check on $savemsg and $input_errors 2015-07-06 14:43:02 +00:00
Franco Fichtner
4dbdf8e3e4 ppps: another php function gone 2015-04-03 21:35:53 +02:00
Franco Fichtner
b0156ef301 ppps: avoid more potential config issues 2015-04-03 13:14:46 +02:00
Ad Schellevis
fe5ae1b7b2 cleanup requires + small typo's 2015-03-23 20:47:12 +00:00
Jos Schellevis
60a5170dc8 Several GUI fixes, including mobile presentation 2015-01-27 14:20:30 +00:00
Jos Schellevis
fb340fcd94 More cleanups, copyrights and links 2015-01-01 13:47:20 +00:00
Franco Fichtner
d389da3582 interfaces: apply whitespace cleanups 2014-12-28 09:36:37 +01:00
Franco Fichtner
727453c076 src: move all files (again)
Make "src" the implicit "/usr/local" so that nobody can
sneak in weird files in the base file system or potentially
overwrite them.

This is the last time, I swear...  :)
2014-12-10 16:42:39 +01:00