73 Commits

Author SHA1 Message Date
Ad Schellevis
30931e5d6d Gateways/edit, escape issue which doesn't seem to add any value anymore 2019-02-26 19:46:54 +01:00
Franco Fichtner
9704e0d217 www: html_safe() for value=; closes #3218 2019-02-14 15:22:28 +01:00
Franco Fichtner
8f80173401 www: a few for #3218 2019-02-14 12:17:07 +01:00
Martin Wasley
7960f2ab77 Add validation check for time period for Dpinger (#3190) 2019-02-09 20:56:51 +01:00
Ad Schellevis
4a8e737ced fix some gettext() + html_safe, discussed c4c7f8d732 2019-02-03 20:04:08 +01:00
Franco Fichtner
aa5af0404c system: move gateway name and description up in the form 2018-12-30 10:50:14 +01:00
Franco Fichtner
445fea97a7 system: simplify gateway edit help 2018-12-30 10:47:35 +01:00
Martin Wasley
6dff027358 Add missing entries to Dpinger advanced section; closes #3077
It's only taken 8 months to do this.. impressive. :)

Modified by: @fichtner
2018-12-30 10:34:48 +01:00
Franco Fichtner
b6671c2b59 src: use new configdp_run() where appropriate 2018-12-25 09:27:47 +01:00
Michael Steenbeek
7ad3d8dff6 Replace some trivial double quotes with single ones 2018-11-23 14:36:44 +01:00
Michael Steenbeek
19ce1c57a4 Replace uncommon <> notation with != 2018-11-23 14:36:44 +01:00
Franco Fichtner
895605846a system: remove service control from gateway edit pages for clarity
We can only start / stop all, not selective gateways during edit
or even gateway groups.
2018-11-16 07:47:53 +01:00
Franco Fichtner
4f721fc0f2 dhcp: more conversion 2018-11-12 17:49:46 +01:00
Franco Fichtner
4be746a5cc system: convert gateways to new functions 2018-11-12 16:53:00 +01:00
Franco Fichtner
cae5ec3f69 system: remove apinger, dpinger takes over 2018-11-10 23:42:17 +01:00
Franco Fichtner
baa43590d7 src: remove get_configured_interface_with_descr()'s $withdisabled 2018-09-11 22:16:31 +02:00
Franco Fichtner
a35b40a4a7 src: remove unused $only_opt 2018-09-11 21:52:34 +02:00
Franco Fichtner
caabf014aa interfaces: ipv6 is in the next condition #2458 2018-06-25 16:10:02 +00:00
Franco Fichtner
4a825adc50 interfaces: ok, again #2458 2018-06-25 16:03:50 +00:00
Franco Fichtner
f15d106e51 interfaces: give first-time hint to ajax #2458 2018-06-25 15:55:39 +00:00
Franco Fichtner
0408e32f87 interfaces: add fargw knob, last bits of UX; closes #2458 2018-06-25 15:34:14 +00:00
Franco Fichtner
e741b9e450 system: unify selectpicker width 2018-06-02 12:38:10 +00:00
marjohn56
0df1c0dfef system: add dpinger monitoring option implementation #2326
stddev bits missing from status page / widget for clarity and
further discussion.  Other cleanups by @fichtner included.
2018-05-07 10:17:08 +02:00
Franco Fichtner
0a69a87dde system: gateways also have these typos 2018-05-03 21:40:12 +02:00
NOYB
9d96bdcbc7 Help For - Data For Attribute
Use original element (<div>/<small>) with "data-for" attribute.

The old jquery "for" attribute selectors can be removed once conversion to "data-for" attribute is complete (including plugins).

The old jquery selectors to remove once conversion is complete.
  opnsense_ui.js & head.inc
  $("*[for='" + $(this).attr('id') + "']")....
  $('[for*="help_for"]')....
2018-03-17 16:12:55 +01:00
NOYB
6ef9a127ff HTML Compliance - Attribute "type" on Element <script>
Warning: The type attribute is unnecessary for JavaScript resources.

HTML5: Edition for Web Authors
http://www.w3.org/TR/2014/REC-html5-20141028/scripting-1.html
The default, which is used if the attribute is absent, is "text/javascript".

The Script element
https://developer.mozilla.org/en-US/docs/Web/HTML/Element/script
HTML5 specification urges authors to omit the attribute rather than provide a redundant MIME type.
2018-01-22 19:13:34 +01:00
NOYB
4a7bcae7af HTML Compliance - Attribute "for" on Element <div>
Error: Attribute "for" not allowed on element "div" at this point.
Attributes for element "div": http://www.w3.org/html/wg/drafts/html/master/single-page.html#the-div-element

HTML attribute reference: https://developer.mozilla.org/en-US/docs/Web/HTML/Attributes
The "Output" element: https://developer.mozilla.org/en-US/docs/Web/HTML/Element/output

Attributes for element "output": http://www.w3.org/html/wg/drafts/html/master/single-page.html#the-output-element
2018-01-06 10:52:17 +01:00
NOYB
b2f4cfa7c1 HTML Compliance - Attribute "type" on Element <i>
Error: Attribute "type" not allowed on element <i> at this point.
2018-01-05 08:36:26 +01:00
NOYB
76aab5cb52 HTML Compliance - Obsolete table attributes
width, align, valign, cellpadding, cellspacing, border, summary

Error: The width attribute on the table element is obsolete. Use CSS instead.
Error: The align attribute on the table element is obsolete. Use CSS instead.
Error: The valign attribute on the table element is obsolete. Use CSS instead.
Error: The cellpadding attribute on the table element is obsolete. Use CSS instead.
Error: The cellspacing attribute on the table element is obsolete. Use CSS instead.
Error: The border attribute on the table element is obsolete. Use CSS instead.
Error: The summary attribute on the table element is obsolete. Consider describing the structure of the table in a caption element or in a figure element containing the table; or, simplify the structure of the table so that no description is needed.
2018-01-04 18:26:02 +01:00
Franco Fichtner
54ae88aea3 interfaces: correct content-type match, it can have ;charset etc. suffix
PR: https://forum.opnsense.org/index.php?topic=5709.0
2017-08-10 22:29:40 +02:00
Franco Fichtner
b0aa1be38d www: more cleanups possible for #1733 2017-07-22 16:52:50 +02:00
Ad Schellevis
69510a5fad legacy ui pages cleanup for https://github.com/opnsense/core/issues/1733 2017-07-22 15:01:26 +02:00
Franco Fichtner
68faafd185 aliases: improve validation messages; closes #1443 2017-04-12 07:36:56 +02:00
Franco Fichtner
c5ab052b67 system: url_safe() for #1168 2016-10-11 08:11:12 +02:00
Franco Fichtner
0652bd0675 src: gettext(sprintf()) corrections; closes #971 2016-05-29 18:27:13 +02:00
Ad Schellevis
0b31dc522f add opnsense_standard_table_form class to forms 2016-05-20 17:09:58 +02:00
Ad Schellevis
7ab0b3463f (legacy) www: strip action attribute from forms where not needed, closes https://github.com/opnsense/core/issues/929 2016-05-12 19:45:28 +02:00
Franco Fichtner
294c3801b7 system: set up a helper route through interface for far gateways
This finally concludes work on #880, left on -devel for a while
longer to double-check with the requesters.
2016-05-09 11:55:35 +02:00
Franco Fichtner
b3d1481797 gateways: pick up interface for manual route to far gateway; closes #880 2016-05-09 10:14:38 +02:00
Franco Fichtner
ed5c0ddeff gateways: allow far gateway outside of interface subnet; closes #880 2016-05-08 19:43:12 +02:00
Ad Schellevis
67b827a84f html correction 2016-03-04 12:07:12 +01:00
Ad Schellevis
ff7fce12c8 fix typo 2016-02-24 11:21:13 +01:00
Franco Fichtner
6e3e407d85 services: rename shorcut_section to better reflect its purpose; closes #674 2016-01-18 09:30:34 +01:00
Franco Fichtner
3d93e25ba0 services: remove indirect mapping and fix remaining services 2016-01-18 09:29:38 +01:00
Franco Fichtner
c037c55aaf gateways: try to purge disabled gateways, closes #557
The way the code is currently set up it will never truly rebuild the
routing table, so old gatway monitoring host entries may linger in
the system until properly rebooted or fully reconfigured.  But all
in all, routes are now skipped properly if no monitoring is needed.
2016-01-09 00:06:39 +01:00
Franco Fichtner
d41b5a7456 src: reindent copyright block to four spaces 2015-12-29 20:22:41 +01:00
Franco Fichtner
86d50f8793 www: remove the need for manual $pgtitle #461 2015-12-08 19:45:59 +01:00
Franco Fichtner
166c571b5e www: another batch for #461 2015-12-05 08:24:21 +01:00
Ad Schellevis
30b63eeb65 (legacy) fix system_gateways_edit.php 2015-12-04 13:57:01 +01:00
Ad Schellevis
688f657404 (legacy) respect defaults in system_gateways_edit.php 2015-12-04 11:35:53 +01:00