Use original element (<div>/<small>) with "data-for" attribute.
The old jquery "for" attribute selectors can be removed once conversion to "data-for" attribute is complete (including plugins).
The old jquery selectors to remove once conversion is complete.
opnsense_ui.js & head.inc
$("*[for='" + $(this).attr('id') + "']")....
$('[for*="help_for"]')....
width, align, valign, cellpadding, cellspacing, border, summary
Error: The width attribute on the table element is obsolete. Use CSS instead.
Error: The align attribute on the table element is obsolete. Use CSS instead.
Error: The valign attribute on the table element is obsolete. Use CSS instead.
Error: The cellpadding attribute on the table element is obsolete. Use CSS instead.
Error: The cellspacing attribute on the table element is obsolete. Use CSS instead.
Error: The border attribute on the table element is obsolete. Use CSS instead.
Error: The summary attribute on the table element is obsolete. Consider describing the structure of the table in a caption element or in a figure element containing the table; or, simplify the structure of the table so that no description is needed.
o group_source was removed as it was unused
o stop passing global authcfg through the ipsec config--wtf?
o if the mobile client section is disable, refuse authentication
o make xauth privilege optional, it will go away in 18.1
The day has come that this "bootstrap" logic broke horribly,
preventing us from upgrading to PHP 7.1 with the initial 17.7.
Add a config_read_array() function that emulates *all* potentially
required steps and grabs the array reference so that the code can
be migrated easily.
Hopefully this also works on PHP 7.0. ;)
This looks a bit odd when we have the full struct and pass it down,
but is way easier to maintain than to tell the underlying code
this is a server or a client or whatever, because it shouldn't
matter as the vpnid is unique anyway.
Looking at openvpn_configure_server() and openvpn_configure_client()
it becomes a bit clearer why they take a config.xml subset: it's beause
the write_config() ordering was flipped. We could probably now pass
an ID and let the code figure out if it is a client or server...
There may be more, at least I don't see the difference between
TLS and shared key for most settings, except certificate setup.
The client traffic redirect is probably also wrong, but for now
provide consistency with TLS.
PR: https://forum.opnsense.org/index.php?topic=3908.0
There is no need to visually overload the field descriptions with
stop chars like a slash, the help is sufficient in explaining that
multiple networks can be used and the chances are high that most
will only ever use one network here.
This wasn't completely right before, trying to plug into rules
reload paths and caused issues with people adding/deleting their
OpenVPN devices, but the rules tab not properly indicating this
since OpenVPN has become a pluggable interface.
