9632 Commits

Author SHA1 Message Date
Ad Schellevis
02fd4f4c7f Web proxy, switch to PAM, closes https://github.com/opnsense/core/issues/3261 2019-02-28 09:57:54 +01:00
Franco Fichtner
38919ec895 firmware: be more careful about parsing; closes #3254 2019-02-27 19:13:14 +01:00
Franco Fichtner
65a60c9d34 system: rename binary, rename service 2019-02-27 17:30:08 +01:00
Ad Schellevis
e4285e97fb Revert "System->Settings->Miscellaneous : add "Reset usb on boot" option"
This reverts commit 6dd8bbe14b1068d462654be46102a6f7f239c3c1.
2019-02-27 12:21:14 +01:00
Ad Schellevis
f5dade45cc Revert ""Reset usb on boot" add sleep, since we can't seem to detect the initial usb detection is still active...."
This reverts commit a0fb31c652386ef6d4f161950bf8a79c87035624.
2019-02-27 12:21:10 +01:00
Ad Schellevis
464996af84 Authentication framework, catch login, su, sudo pam services
- add aliases() to IService, so one service can be used for multiple pam services, eases implementation (pam has an include statement for this purpose)
- move logging to AuthenticationFactory->authenticate() and communicate more about choices taken, eases debugging
- remove OpnsenseAuthTest, Sshd, implemented by System

for https://github.com/opnsense/core/issues/3242
2019-02-27 11:20:29 +01:00
Ad Schellevis
d9eb9cb29a ACL::hasPrivilege() overlapping variable, related to https://github.com/opnsense/core/issues/3242 2019-02-27 10:41:37 +01:00
Ad Schellevis
538b74ca63 escaping, b24e7acf3f (commitcomment-32490347) 2019-02-27 09:00:48 +01:00
Franco Fichtner
69ff2fa8ad system: move opnsense-auth to libexec
... but keep a symlink for backwards compatibility
2019-02-27 01:26:15 +01:00
Franco Fichtner
64e74ce75b mvc: more close / cancel, translation 2019-02-27 00:53:05 +01:00
Franco Fichtner
66e6efccd8 firewall: alias close button is really cancel 2019-02-27 00:47:15 +01:00
Franco Fichtner
8724ba878d mvc: simplify save button label 2019-02-27 00:44:40 +01:00
Franco Fichtner
42e901ce6d src: another style sweep 2019-02-26 23:57:29 +01:00
Franco Fichtner
46de0646c9 src: style fix 2019-02-26 23:53:14 +01:00
Ad Schellevis
ae38c01d5d Merge branch 'master' of https://github.com/mimugmail/core into mimugmail-master 2019-02-26 20:55:19 +01:00
Ad Schellevis
80d94767a7 firewall_schedule_edit.php, escape issues 2019-02-26 20:16:00 +01:00
Ad Schellevis
b24e7acf3f legacy_html_escape_form_data() add ENT_QUOTES to avoid certain escaping issues 2019-02-26 19:58:42 +01:00
Ad Schellevis
30931e5d6d Gateways/edit, escape issue which doesn't seem to add any value anymore 2019-02-26 19:46:54 +01:00
Ad Schellevis
560a6cb79e MVC/field types, add sorting for list types. closes https://github.com/opnsense/core/issues/3251
We should refactor some code later, but there's no rush. issue in https://github.com/opnsense/core/issues/3252
2019-02-26 11:26:05 +01:00
Ad Schellevis
8170be76e6 squid + pam, for https://github.com/opnsense/core/issues/3242 2019-02-25 20:44:34 +01:00
Ad Schellevis
a0fb31c652 "Reset usb on boot" add sleep, since we can't seem to detect the initial usb detection is still active....
Sample errors while booting:
--------------------------------------------------------------------------------
usbd_setup_device_desc: getting device descriptor at addr X failed, USB_ERR_IOERROR
usbd_req_re_enumerate: addr=X, set address failed! (USB_ERR_IOERROR, ignored)
2019-02-25 18:38:53 +01:00
Ad Schellevis
6dd8bbe14b System->Settings->Miscellaneous : add "Reset usb on boot" option
While testing 4g modems, it seems that initial device detection isn't flawless leading to USB_ERR_IOERROR failures and non functional modems.
Most likely cause of these issues seems to be that some devices need a bit of time between powering the bus and performing registration.

This option adds an early boot script, which optionally performs a usbconfig reset on boot.
2019-02-25 16:49:25 +01:00
Ad Schellevis
dc7db7084b configd, python 2 --> 3, simplify search for program path 2019-02-25 10:14:14 +01:00
Ad Schellevis
22261d6614 configd, python 2 --> 3, type comparison issue (bytes, str) disabling our previous end of line fix 2019-02-25 10:05:19 +01:00
Ad Schellevis
ddca8d4350 web proxy, move pam to template 2019-02-25 09:55:41 +01:00
Franco Fichtner
7a6ccaf029 web proxy: simplify to avoid confusion 2019-02-25 08:41:58 +01:00
Franco Fichtner
8f9a89e643 interfaces: fix permission 2019-02-25 08:28:06 +01:00
Franco Fichtner
75c3100ba7 interfaces: move mpd.script to scripts dir
mpd5 is started with -d /var/etc so it expects mpd.script to be there.
Some small simplifications along the way.
2019-02-25 08:23:50 +01:00
Franco Fichtner
cfc95122f2 interfaces: move ppp-related scripts to proper location
sbin/ is for console-bound binaries.
2019-02-25 08:23:50 +01:00
Franco Fichtner
38be942639 firmware: move duty to return the correct name/id to opnsense-version
To be fixed there eventually without a stale note attached.
2019-02-25 08:16:21 +01:00
Franco Fichtner
63ed46dcea system: small cleanups in session file handling 2019-02-25 07:06:05 +01:00
Franco Fichtner
96683647f5 openvpn: try to "solve" get_failover_interface() issues
This seems to be a cosmetic cleanup.  get_failover_interface()
is used incorrectly but then merely seems to be used to look
up IPv4 connectivity to make a "smart" decision about resync
duties.

A few annoying and disabled line removals while here.
2019-02-25 05:42:21 +01:00
Franco Fichtner
6a4fa40e72 interfaces: small audit of get_failover_interface() 2019-02-24 20:58:36 +01:00
Franco Fichtner
bc1ff2f2f7 firmware: small note for the future 2019-02-24 20:32:10 +01:00
Ad Schellevis
c920004d12 proxy/auth, work in progress https://github.com/opnsense/core/issues/3242 create pam helper for squid
todo:
* add userHasPrivilege($user, "user-proxy-auth") replacement
* change squid template to pam, as long as the template isn't changed, this service doesn't do anything
2019-02-24 19:45:38 +01:00
Ad Schellevis
88ee92f63c Authentication framework, complete interface to support most currently known scenarios, for https://github.com/opnsense/core/issues/3242
* using setUserName() --> getUsername() we could support additional services per pam service registration (which would be needed for OpenVPN)
* checkConstraints() can be used to implement current "has group" patterns
2019-02-24 19:31:04 +01:00
Ad Schellevis
40f1662c62 theme, new icon-logo.svg and switch orange #EA7105 with #D94F00 as an experiment. 2019-02-24 11:46:39 +01:00
Ad Schellevis
91be9a6974 python 2-->3 / configd
First (functional) attempt, this needs to stay on devel for some time there might be dragons ;)

src/etc/rc.d/configd --> command_interpreter could cause restart issues after an upgrade, the rc system doesn't like command changes it seems. Maybe not a real world problem, just haven't tried it yet.
unit tests are somewhat functional, although generating all templates will likely fail, since the test config doesn't include all data involved.
2019-02-22 21:03:42 +01:00
Ad Schellevis
47a3b2419d python 2->3 iteritems() in core templates 2019-02-22 19:23:52 +01:00
Ad Schellevis
9e082449aa IDS, minor template cleanups using https://github.com/opnsense/core/issues/3100 2019-02-22 16:07:48 +01:00
Ad Schellevis
245513f970 configd, add helpers.empty(), closes https://github.com/opnsense/core/issues/3100 2019-02-22 16:06:42 +01:00
Ad Schellevis
cc2b41bf15 OpenVPN export, add auth-nocache option, closes https://github.com/opnsense/core/issues/3193 2019-02-22 15:29:48 +01:00
Ad Schellevis
a8d89dadc5 mvc/forms, add support for tokenize2 sortable tag, closes https://github.com/opnsense/core/issues/3145 2019-02-22 14:54:10 +01:00
Ad Schellevis
3a361f8e59 auth/pam, better CamelCase for https://github.com/opnsense/core/issues/3242 2019-02-21 21:29:37 +01:00
Ad Schellevis
2e14587955 Auth, add example authentication service and some filename cleansing. for https://github.com/opnsense/core/issues/3242 2019-02-21 21:04:05 +01:00
Ad Schellevis
bdd4c8db03 refresh logo, small scaling issue in previous 2019-02-20 15:08:58 +01:00
Ad Schellevis
63065a9f1f theme, sharpen our theme a bit 2019-02-20 09:16:19 +01:00
Ad Schellevis
f7213e84ea psec_mobile.php fix minor escaping issue 2019-02-20 08:44:18 +01:00
Ad Schellevis
5123277a85 config access, don't try to open config.xml in write mode when file is not writeable. closes https://github.com/opnsense/core/issues/3241 2019-02-19 16:28:00 +01:00
Ad Schellevis
dd1d8cba05 minor simplification for https://github.com/opnsense/core/issues/3242 2019-02-18 22:11:23 +01:00