lucaspalomodevelop/core
1
0
Fork 0
mirror of https://github.com/lucaspalomodevelop/core.git synced 2026-03-17 18:14:42 +00:00
Code Issues Packages Projects Releases Wiki Activity

crash_reporter: tweak the error reporting

Browse Source 
* add E_PARSE to show proper info about parse errors
* remove PHP 5.5 support, we've never shipped it
* fix textarea display width and disable send button
This commit is contained in:
Franco Fichtner 2015-03-03 07:21:25 +00:00
parent 7efba9edca
commit fd370c5712
2 changed files with 3 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
src/etc/rc.php_ini_setup
View File

@ -31,9 +31,6 @@ PLATFORM=`/bin/cat /usr/local/etc/platform`
if [ -d /usr/local/lib/php/20131226 ]; then
# PHP 5.6
EXTENSIONSDIR="/usr/local/lib/php/20131226/"
elif [ -d /usr/local/lib/php/20121212 ]; then
# PHP 5.5
EXTENSIONSDIR="/usr/local/lib/php/20121212/"
else
echo "No supported PHP version was found."
exit 1
@ -135,7 +132,7 @@ zlib.output_compression = Off
zlib.output_compression_level = 1
include_path = ".:/usr/local/etc/inc:/usr/local/www:/usr/local/captiveportal:/usr/local/pkg:/usr/local/opnsense/mvc:/usr/local/share/pear"
display_startup_errors=on
error_reporting = E_ERROR
error_reporting = E_ERROR | E_PARSE
display_errors=on
log_errors=on
error_log=/tmp/PHP_errors.log

4
src/www/crash_reporter.php
View File

@ -57,8 +57,8 @@ function output_crash_reporter_html($crash_reports) {
echo "<p>" . gettext("Would you like to submit the programming debug logs to the OPNsense developers for inspection?") . "</p>";
echo "<p><i>" . gettext("Please double check the contents to ensure you are comfortable sending this information before clicking Yes.") . "</i></p>";
echo "<p>" . gettext("Contents of crash reports") . ":<br />";
echo "<textarea readonly=\"readonly\" rows=\"40\" cols=\"65\" name=\"crashreports\">{$crash_reports}</textarea></p>";
echo "<p><input name=\"Submit\" type=\"submit\" class=\"btn btn-primary\" value=\"" . gettext("Yes") . "\" />" . gettext(" - Submit this to the developers for inspection") . "</p>";
echo "<textarea readonly=\"readonly\" style=\"max-width: none;\" rows=\"24\" cols=\"80\" name=\"crashreports\">{$crash_reports}</textarea></p>";
echo "<p><input disabled=\"disabled\" name=\"Submit\" type=\"submit\" class=\"btn btn-primary\" value=\"" . gettext("Yes") . "\" />" . gettext(" - Submit this to the developers for inspection") . "</p>";
echo "<p><input name=\"Submit\" type=\"submit\" class=\"btn btn-primary\" value=\"" . gettext("No") . "\" />" . gettext(" - Just delete the crash report and take me back to the Dashboard") . "</p>";
echo "</form>";
}